diff options
author | Ming Lei <ming.lei@canonical.com> | 2014-09-25 11:23:41 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-09-25 17:22:37 -0400 |
commit | 3c09676c12b1dabf84acbb5849bfc54acadaf092 (patch) | |
tree | 48dc1cd699cd175dc3370a464d34bd6d814fe1e7 /block | |
parent | f355265571440a7db16e784b6edf4e7d26971a03 (diff) |
block: move flush initialization to blk_flush_init
These fields are always used with the flush request, so
initialize them together.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/blk-core.c | 3 | ||||
-rw-r--r-- | block/blk-flush.c | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 0a9d17269957..222fe84d6ac4 100644 --- a/block/blk-core.c +++ b/block/blk-core.c | |||
@@ -600,9 +600,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) | |||
600 | #ifdef CONFIG_BLK_CGROUP | 600 | #ifdef CONFIG_BLK_CGROUP |
601 | INIT_LIST_HEAD(&q->blkg_list); | 601 | INIT_LIST_HEAD(&q->blkg_list); |
602 | #endif | 602 | #endif |
603 | INIT_LIST_HEAD(&q->flush_queue[0]); | ||
604 | INIT_LIST_HEAD(&q->flush_queue[1]); | ||
605 | INIT_LIST_HEAD(&q->flush_data_in_flight); | ||
606 | INIT_DELAYED_WORK(&q->delay_work, blk_delay_work); | 603 | INIT_DELAYED_WORK(&q->delay_work, blk_delay_work); |
607 | 604 | ||
608 | kobject_init(&q->kobj, &blk_queue_ktype); | 605 | kobject_init(&q->kobj, &blk_queue_ktype); |
diff --git a/block/blk-flush.c b/block/blk-flush.c index c72ab32fd8eb..a49ffbdcfcdc 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c | |||
@@ -488,6 +488,10 @@ static int blk_mq_init_flush(struct request_queue *q) | |||
488 | 488 | ||
489 | int blk_init_flush(struct request_queue *q) | 489 | int blk_init_flush(struct request_queue *q) |
490 | { | 490 | { |
491 | INIT_LIST_HEAD(&q->flush_queue[0]); | ||
492 | INIT_LIST_HEAD(&q->flush_queue[1]); | ||
493 | INIT_LIST_HEAD(&q->flush_data_in_flight); | ||
494 | |||
491 | if (q->mq_ops) | 495 | if (q->mq_ops) |
492 | return blk_mq_init_flush(q); | 496 | return blk_mq_init_flush(q); |
493 | 497 | ||