aboutsummaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorHarvey Harrison <harvey.harrison@gmail.com>2008-08-28 03:27:42 -0400
committerJens Axboe <jens.axboe@oracle.com>2008-10-09 02:56:11 -0400
commitaeb3d3a81e81c6323a17fe914e91eb228b3f1aa1 (patch)
tree9cacfa989eaad1611f61e5707fd432e7f1fde685 /block
parent01cfcddd98f09e05a2e36031654ed46643b76f23 (diff)
block: kmalloc args reversed, small function definition fixes
Noticed by sparse: block/blk-softirq.c:156:12: warning: symbol 'blk_softirq_init' was not declared. Should it be static? block/genhd.c:583:28: warning: function 'bdget_disk' with external linkage has definition block/genhd.c:659:17: warning: incorrect type in argument 1 (different base types) block/genhd.c:659:17: expected unsigned int [unsigned] [usertype] size block/genhd.c:659:17: got restricted gfp_t block/genhd.c:659:29: warning: incorrect type in argument 2 (different base types) block/genhd.c:659:29: expected restricted gfp_t [usertype] flags block/genhd.c:659:29: got unsigned int block: kmalloc args reversed Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r--block/blk-settings.c2
-rw-r--r--block/genhd.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/block/blk-settings.c b/block/blk-settings.c
index a60e959a12c4..d70692badcdb 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -443,7 +443,7 @@ void blk_queue_update_dma_alignment(struct request_queue *q, int mask)
443} 443}
444EXPORT_SYMBOL(blk_queue_update_dma_alignment); 444EXPORT_SYMBOL(blk_queue_update_dma_alignment);
445 445
446int __init blk_settings_init(void) 446static int __init blk_settings_init(void)
447{ 447{
448 blk_max_low_pfn = max_low_pfn - 1; 448 blk_max_low_pfn = max_low_pfn - 1;
449 blk_max_pfn = max_pfn - 1; 449 blk_max_pfn = max_pfn - 1;
diff --git a/block/genhd.c b/block/genhd.c
index d9de3e482d1e..32ee73c67560 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -578,7 +578,7 @@ struct gendisk *get_gendisk(dev_t devt, int *partno)
578 * RETURNS: 578 * RETURNS:
579 * Resulting block_device on success, NULL on failure. 579 * Resulting block_device on success, NULL on failure.
580 */ 580 */
581extern struct block_device *bdget_disk(struct gendisk *disk, int partno) 581struct block_device *bdget_disk(struct gendisk *disk, int partno)
582{ 582{
583 struct hd_struct *part; 583 struct hd_struct *part;
584 struct block_device *bdev = NULL; 584 struct block_device *bdev = NULL;
@@ -654,7 +654,7 @@ static void *disk_seqf_start(struct seq_file *seqf, loff_t *pos)
654 struct class_dev_iter *iter; 654 struct class_dev_iter *iter;
655 struct device *dev; 655 struct device *dev;
656 656
657 iter = kmalloc(GFP_KERNEL, sizeof(*iter)); 657 iter = kmalloc(sizeof(*iter), GFP_KERNEL);
658 if (!iter) 658 if (!iter)
659 return ERR_PTR(-ENOMEM); 659 return ERR_PTR(-ENOMEM);
660 660