diff options
| author | Joe Perches <joe@perches.com> | 2011-06-13 04:42:49 -0400 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2011-06-13 14:18:49 -0400 |
| commit | fd16d263194aa6b50b215eb593a567b59d744d6e (patch) | |
| tree | 555aac4bd0104ea85643f1a3550c9bc1cbac9256 /block | |
| parent | dd7740933842202fccaa9ebcba6bce0507b3f6d6 (diff) | |
block: Add __attribute__((format(printf...) and fix fallout
Use the compiler to verify format strings and arguments.
Fix fallout.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-throttle.c | 4 | ||||
| -rw-r--r-- | block/cfq-iosched.c | 11 |
2 files changed, 8 insertions, 7 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index a62be8d0dc1b..3689f833afdc 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c | |||
| @@ -927,7 +927,7 @@ static int throtl_dispatch(struct request_queue *q) | |||
| 927 | 927 | ||
| 928 | bio_list_init(&bio_list_on_stack); | 928 | bio_list_init(&bio_list_on_stack); |
| 929 | 929 | ||
| 930 | throtl_log(td, "dispatch nr_queued=%lu read=%u write=%u", | 930 | throtl_log(td, "dispatch nr_queued=%d read=%u write=%u", |
| 931 | total_nr_queued(td), td->nr_queued[READ], | 931 | total_nr_queued(td), td->nr_queued[READ], |
| 932 | td->nr_queued[WRITE]); | 932 | td->nr_queued[WRITE]); |
| 933 | 933 | ||
| @@ -1204,7 +1204,7 @@ int blk_throtl_bio(struct request_queue *q, struct bio **biop) | |||
| 1204 | } | 1204 | } |
| 1205 | 1205 | ||
| 1206 | queue_bio: | 1206 | queue_bio: |
| 1207 | throtl_log_tg(td, tg, "[%c] bio. bdisp=%u sz=%u bps=%llu" | 1207 | throtl_log_tg(td, tg, "[%c] bio. bdisp=%llu sz=%u bps=%llu" |
| 1208 | " iodisp=%u iops=%u queued=%d/%d", | 1208 | " iodisp=%u iops=%u queued=%d/%d", |
| 1209 | rw == READ ? 'R' : 'W', | 1209 | rw == READ ? 'R' : 'W', |
| 1210 | tg->bytes_disp[rw], bio->bi_size, tg->bps[rw], | 1210 | tg->bytes_disp[rw], bio->bi_size, tg->bps[rw], |
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 2b2d7a9a42ab..3d403a128971 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
| @@ -988,9 +988,10 @@ static void cfq_group_served(struct cfq_data *cfqd, struct cfq_group *cfqg, | |||
| 988 | 988 | ||
| 989 | cfq_log_cfqg(cfqd, cfqg, "served: vt=%llu min_vt=%llu", cfqg->vdisktime, | 989 | cfq_log_cfqg(cfqd, cfqg, "served: vt=%llu min_vt=%llu", cfqg->vdisktime, |
| 990 | st->min_vdisktime); | 990 | st->min_vdisktime); |
| 991 | cfq_log_cfqq(cfqq->cfqd, cfqq, "sl_used=%u disp=%u charge=%u iops=%u" | 991 | cfq_log_cfqq(cfqq->cfqd, cfqq, |
| 992 | " sect=%u", used_sl, cfqq->slice_dispatch, charge, | 992 | "sl_used=%u disp=%u charge=%u iops=%u sect=%lu", |
| 993 | iops_mode(cfqd), cfqq->nr_sectors); | 993 | used_sl, cfqq->slice_dispatch, charge, |
| 994 | iops_mode(cfqd), cfqq->nr_sectors); | ||
| 994 | cfq_blkiocg_update_timeslice_used(&cfqg->blkg, used_sl, | 995 | cfq_blkiocg_update_timeslice_used(&cfqg->blkg, used_sl, |
| 995 | unaccounted_sl); | 996 | unaccounted_sl); |
| 996 | cfq_blkiocg_set_start_empty_time(&cfqg->blkg); | 997 | cfq_blkiocg_set_start_empty_time(&cfqg->blkg); |
| @@ -2018,8 +2019,8 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd) | |||
| 2018 | */ | 2019 | */ |
| 2019 | if (sample_valid(cic->ttime_samples) && | 2020 | if (sample_valid(cic->ttime_samples) && |
| 2020 | (cfqq->slice_end - jiffies < cic->ttime_mean)) { | 2021 | (cfqq->slice_end - jiffies < cic->ttime_mean)) { |
| 2021 | cfq_log_cfqq(cfqd, cfqq, "Not idling. think_time:%d", | 2022 | cfq_log_cfqq(cfqd, cfqq, "Not idling. think_time:%lu", |
| 2022 | cic->ttime_mean); | 2023 | cic->ttime_mean); |
| 2023 | return; | 2024 | return; |
| 2024 | } | 2025 | } |
| 2025 | 2026 | ||
