diff options
author | Jens Axboe <axboe@fb.com> | 2014-06-04 12:23:49 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-06-04 12:23:49 -0400 |
commit | 0e62f51f8753b048f391ee2d7f2af1f7297b0be5 (patch) | |
tree | 3cd2ad45a7f0cb9e97995e57be61432e9f0d34d3 /block | |
parent | f899fed4421d6b098ed6a9d69303c70e590bf2c0 (diff) |
blk-mq: let blk_mq_tag_to_rq() take blk_mq_tags as the main parameter
We currently pass in the hardware queue, and get the tags from there.
But from scsi-mq, with a shared tag space, it's a lot more convenient
to pass in the blk_mq_tags instead as the hardware queue isn't always
directly available. So instead of having to re-map to a given
hardware queue from rq->mq_ctx, just pass in the tags structure.
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/blk-mq.c | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 4e8e8cf00815..4e4cd6208052 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c | |||
@@ -529,15 +529,20 @@ void blk_mq_kick_requeue_list(struct request_queue *q) | |||
529 | } | 529 | } |
530 | EXPORT_SYMBOL(blk_mq_kick_requeue_list); | 530 | EXPORT_SYMBOL(blk_mq_kick_requeue_list); |
531 | 531 | ||
532 | struct request *blk_mq_tag_to_rq(struct blk_mq_hw_ctx *hctx, unsigned int tag) | 532 | static inline bool is_flush_request(struct request *rq, unsigned int tag) |
533 | { | 533 | { |
534 | struct request_queue *q = hctx->queue; | 534 | return ((rq->cmd_flags & REQ_FLUSH_SEQ) && |
535 | rq->q->flush_rq->tag == tag); | ||
536 | } | ||
535 | 537 | ||
536 | if ((q->flush_rq->cmd_flags & REQ_FLUSH_SEQ) && | 538 | struct request *blk_mq_tag_to_rq(struct blk_mq_tags *tags, unsigned int tag) |
537 | q->flush_rq->tag == tag) | 539 | { |
538 | return q->flush_rq; | 540 | struct request *rq = tags->rqs[tag]; |
541 | |||
542 | if (!is_flush_request(rq, tag)) | ||
543 | return rq; | ||
539 | 544 | ||
540 | return hctx->tags->rqs[tag]; | 545 | return rq->q->flush_rq; |
541 | } | 546 | } |
542 | EXPORT_SYMBOL(blk_mq_tag_to_rq); | 547 | EXPORT_SYMBOL(blk_mq_tag_to_rq); |
543 | 548 | ||
@@ -566,7 +571,7 @@ static void blk_mq_timeout_check(void *__data, unsigned long *free_tags) | |||
566 | if (tag >= hctx->tags->nr_tags) | 571 | if (tag >= hctx->tags->nr_tags) |
567 | break; | 572 | break; |
568 | 573 | ||
569 | rq = blk_mq_tag_to_rq(hctx, tag++); | 574 | rq = blk_mq_tag_to_rq(hctx->tags, tag++); |
570 | if (rq->q != hctx->queue) | 575 | if (rq->q != hctx->queue) |
571 | continue; | 576 | continue; |
572 | if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags)) | 577 | if (!test_bit(REQ_ATOM_STARTED, &rq->atomic_flags)) |