diff options
author | Jens Axboe <jens.axboe@oracle.com> | 2007-01-18 20:01:16 -0500 |
---|---|---|
committer | Jens Axboe <axboe@carl.home.kernel.dk> | 2007-02-11 17:14:45 -0500 |
commit | cb8874119e9a3ec38c45942808c91cfbc014f402 (patch) | |
tree | 410562c9c72499ab208b5526fb35736c48520638 /block | |
parent | 1792669cc1acc2069869b7ca41a0195240de05e0 (diff) |
cfq-iosched: tweak the FIFO checking
We currently check the FIFO once per slice. Optimize that a bit and
only do it as the first thing for a new slice, so we don't end up
doing a single request and then seek to the FIFO requests.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/cfq-iosched.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 3df41a00b553..03b1e474b2bf 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -885,16 +885,17 @@ static inline struct request *cfq_check_fifo(struct cfq_queue *cfqq) | |||
885 | 885 | ||
886 | if (cfq_cfqq_fifo_expire(cfqq)) | 886 | if (cfq_cfqq_fifo_expire(cfqq)) |
887 | return NULL; | 887 | return NULL; |
888 | |||
889 | cfq_mark_cfqq_fifo_expire(cfqq); | ||
890 | |||
888 | if (list_empty(&cfqq->fifo)) | 891 | if (list_empty(&cfqq->fifo)) |
889 | return NULL; | 892 | return NULL; |
890 | 893 | ||
891 | fifo = cfq_cfqq_class_sync(cfqq); | 894 | fifo = cfq_cfqq_class_sync(cfqq); |
892 | rq = rq_entry_fifo(cfqq->fifo.next); | 895 | rq = rq_entry_fifo(cfqq->fifo.next); |
893 | 896 | ||
894 | if (time_after(jiffies, rq->start_time + cfqd->cfq_fifo_expire[fifo])) { | 897 | if (time_after(jiffies, rq->start_time + cfqd->cfq_fifo_expire[fifo])) |
895 | cfq_mark_cfqq_fifo_expire(cfqq); | ||
896 | return rq; | 898 | return rq; |
897 | } | ||
898 | 899 | ||
899 | return NULL; | 900 | return NULL; |
900 | } | 901 | } |