diff options
author | Mike Snitzer <snitzer@redhat.com> | 2010-11-08 08:39:12 -0500 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-11-10 08:40:53 -0500 |
commit | 77304d2abac6101f7249754ffdd4421258877ab0 (patch) | |
tree | 8ee5914529d70120528a630a8e904c22f8c4f98c /block/ioctl.c | |
parent | 90fdb0b98a62d78a0650b9fd3ddc58a48f71d740 (diff) |
block: read i_size with i_size_read()
Convert direct reads of an inode's i_size to using i_size_read().
i_size_{read,write} use a seqcount to protect reads from accessing
incomple writes. Concurrent i_size_write()s require mutual exclussion
to protect the seqcount that is used by i_size_{read,write}. But
i_size_read() callers do not need to use additional locking.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: NeilBrown <neilb@suse.de>
Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'block/ioctl.c')
-rw-r--r-- | block/ioctl.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/block/ioctl.c b/block/ioctl.c index d724ceb1d465..38aa194f63ec 100644 --- a/block/ioctl.c +++ b/block/ioctl.c | |||
@@ -125,7 +125,7 @@ static int blk_ioctl_discard(struct block_device *bdev, uint64_t start, | |||
125 | start >>= 9; | 125 | start >>= 9; |
126 | len >>= 9; | 126 | len >>= 9; |
127 | 127 | ||
128 | if (start + len > (bdev->bd_inode->i_size >> 9)) | 128 | if (start + len > (i_size_read(bdev->bd_inode) >> 9)) |
129 | return -EINVAL; | 129 | return -EINVAL; |
130 | if (secure) | 130 | if (secure) |
131 | flags |= BLKDEV_DISCARD_SECURE; | 131 | flags |= BLKDEV_DISCARD_SECURE; |
@@ -307,12 +307,12 @@ int blkdev_ioctl(struct block_device *bdev, fmode_t mode, unsigned cmd, | |||
307 | ret = blkdev_reread_part(bdev); | 307 | ret = blkdev_reread_part(bdev); |
308 | break; | 308 | break; |
309 | case BLKGETSIZE: | 309 | case BLKGETSIZE: |
310 | size = bdev->bd_inode->i_size; | 310 | size = i_size_read(bdev->bd_inode); |
311 | if ((size >> 9) > ~0UL) | 311 | if ((size >> 9) > ~0UL) |
312 | return -EFBIG; | 312 | return -EFBIG; |
313 | return put_ulong(arg, size >> 9); | 313 | return put_ulong(arg, size >> 9); |
314 | case BLKGETSIZE64: | 314 | case BLKGETSIZE64: |
315 | return put_u64(arg, bdev->bd_inode->i_size); | 315 | return put_u64(arg, i_size_read(bdev->bd_inode)); |
316 | case BLKTRACESTART: | 316 | case BLKTRACESTART: |
317 | case BLKTRACESTOP: | 317 | case BLKTRACESTOP: |
318 | case BLKTRACESETUP: | 318 | case BLKTRACESETUP: |