diff options
author | Gui Jianfeng <guijianfeng@cn.fujitsu.com> | 2010-02-26 02:56:15 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2010-02-26 02:56:15 -0500 |
commit | 024f9066165ffe9c8284431c78adcbcddd309831 (patch) | |
tree | 11b64dd7861985aca57bd7624cd25c804afd4b1a /block/cfq-iosched.c | |
parent | 7f03292ee16e68be96aa88904afc6152f8d37736 (diff) |
cfq: Remove useless css reference get
There's no need to take css reference here, for the caller
has already called rcu_read_lock() to prevent cgroup from
being removed.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block/cfq-iosched.c')
-rw-r--r-- | block/cfq-iosched.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index e3dedfd3bcb4..10eb286f1f49 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -951,10 +951,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create) | |||
951 | struct backing_dev_info *bdi = &cfqd->queue->backing_dev_info; | 951 | struct backing_dev_info *bdi = &cfqd->queue->backing_dev_info; |
952 | unsigned int major, minor; | 952 | unsigned int major, minor; |
953 | 953 | ||
954 | /* Do we need to take this reference */ | ||
955 | if (!blkiocg_css_tryget(blkcg)) | ||
956 | return NULL;; | ||
957 | |||
958 | cfqg = cfqg_of_blkg(blkiocg_lookup_group(blkcg, key)); | 954 | cfqg = cfqg_of_blkg(blkiocg_lookup_group(blkcg, key)); |
959 | if (cfqg || !create) | 955 | if (cfqg || !create) |
960 | goto done; | 956 | goto done; |
@@ -985,7 +981,6 @@ cfq_find_alloc_cfqg(struct cfq_data *cfqd, struct cgroup *cgroup, int create) | |||
985 | hlist_add_head(&cfqg->cfqd_node, &cfqd->cfqg_list); | 981 | hlist_add_head(&cfqg->cfqd_node, &cfqd->cfqg_list); |
986 | 982 | ||
987 | done: | 983 | done: |
988 | blkiocg_css_put(blkcg); | ||
989 | return cfqg; | 984 | return cfqg; |
990 | } | 985 | } |
991 | 986 | ||