diff options
author | Tejun Heo <tj@kernel.org> | 2012-03-05 16:14:54 -0500 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2012-03-06 15:27:21 -0500 |
commit | 32e380aedc3de454c06ce1c254fe3bea35a676e1 (patch) | |
tree | ae48ced36af22f020451cb05ecca835ff561dc9d /block/Kconfig.iosched | |
parent | b855b04a0b2213dbc1b59cf936056726e7ed97ad (diff) |
blkcg: make CONFIG_BLK_CGROUP bool
Block cgroup core can be built as module; however, it isn't too useful
as blk-throttle can only be built-in and cfq-iosched is usually the
default built-in scheduler. Scheduled blkcg cleanup requires calling
into blkcg from block core. To simplify that, disallow building blkcg
as module by making CONFIG_BLK_CGROUP bool.
If building blkcg core as module really matters, which I doubt, we can
revisit it after blkcg API cleanup.
-v2: Vivek pointed out that IOSCHED_CFQ was incorrectly updated to
depend on BLK_CGROUP. Fixed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/Kconfig.iosched')
-rw-r--r-- | block/Kconfig.iosched | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched index 3199b76f795d..421bef9c4c48 100644 --- a/block/Kconfig.iosched +++ b/block/Kconfig.iosched | |||
@@ -23,8 +23,6 @@ config IOSCHED_DEADLINE | |||
23 | 23 | ||
24 | config IOSCHED_CFQ | 24 | config IOSCHED_CFQ |
25 | tristate "CFQ I/O scheduler" | 25 | tristate "CFQ I/O scheduler" |
26 | # If BLK_CGROUP is a module, CFQ has to be built as module. | ||
27 | depends on (BLK_CGROUP=m && m) || !BLK_CGROUP || BLK_CGROUP=y | ||
28 | default y | 26 | default y |
29 | ---help--- | 27 | ---help--- |
30 | The CFQ I/O scheduler tries to distribute bandwidth equally | 28 | The CFQ I/O scheduler tries to distribute bandwidth equally |
@@ -34,8 +32,6 @@ config IOSCHED_CFQ | |||
34 | 32 | ||
35 | This is the default I/O scheduler. | 33 | This is the default I/O scheduler. |
36 | 34 | ||
37 | Note: If BLK_CGROUP=m, then CFQ can be built only as module. | ||
38 | |||
39 | config CFQ_GROUP_IOSCHED | 35 | config CFQ_GROUP_IOSCHED |
40 | bool "CFQ Group Scheduling support" | 36 | bool "CFQ Group Scheduling support" |
41 | depends on IOSCHED_CFQ && BLK_CGROUP | 37 | depends on IOSCHED_CFQ && BLK_CGROUP |