diff options
author | Andrea Arcangeli <aarcange@redhat.com> | 2015-02-11 18:27:23 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-11 20:06:05 -0500 |
commit | a7b780750e1a1c7833812681e1f8fa30bbb06802 (patch) | |
tree | e13f7ac217df9904b5cbc1cb624c9f7c9e2130ac /arch | |
parent | 0fd71a56f41d4ffabeda1dae9ff5ed4f34d4e935 (diff) |
mm: gup: use get_user_pages_unlocked within get_user_pages_fast
This allows the get_user_pages_fast slow path to release the mmap_sem
before blocking.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andres Lagar-Cavilla <andreslc@google.com>
Cc: Peter Feiner <pfeiner@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/mips/mm/gup.c | 8 | ||||
-rw-r--r-- | arch/s390/mm/gup.c | 6 | ||||
-rw-r--r-- | arch/sh/mm/gup.c | 6 | ||||
-rw-r--r-- | arch/sparc/mm/gup.c | 6 | ||||
-rw-r--r-- | arch/x86/mm/gup.c | 7 |
5 files changed, 12 insertions, 21 deletions
diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c index 70795a67a276..349995d19c7f 100644 --- a/arch/mips/mm/gup.c +++ b/arch/mips/mm/gup.c | |||
@@ -301,11 +301,9 @@ slow_irqon: | |||
301 | start += nr << PAGE_SHIFT; | 301 | start += nr << PAGE_SHIFT; |
302 | pages += nr; | 302 | pages += nr; |
303 | 303 | ||
304 | down_read(&mm->mmap_sem); | 304 | ret = get_user_pages_unlocked(current, mm, start, |
305 | ret = get_user_pages(current, mm, start, | 305 | (end - start) >> PAGE_SHIFT, |
306 | (end - start) >> PAGE_SHIFT, | 306 | write, 0, pages); |
307 | write, 0, pages, NULL); | ||
308 | up_read(&mm->mmap_sem); | ||
309 | 307 | ||
310 | /* Have to be a bit careful with return values */ | 308 | /* Have to be a bit careful with return values */ |
311 | if (nr > 0) { | 309 | if (nr > 0) { |
diff --git a/arch/s390/mm/gup.c b/arch/s390/mm/gup.c index 639fce464008..5c586c78ca8d 100644 --- a/arch/s390/mm/gup.c +++ b/arch/s390/mm/gup.c | |||
@@ -235,10 +235,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, | |||
235 | /* Try to get the remaining pages with get_user_pages */ | 235 | /* Try to get the remaining pages with get_user_pages */ |
236 | start += nr << PAGE_SHIFT; | 236 | start += nr << PAGE_SHIFT; |
237 | pages += nr; | 237 | pages += nr; |
238 | down_read(&mm->mmap_sem); | 238 | ret = get_user_pages_unlocked(current, mm, start, |
239 | ret = get_user_pages(current, mm, start, | 239 | nr_pages - nr, write, 0, pages); |
240 | nr_pages - nr, write, 0, pages, NULL); | ||
241 | up_read(&mm->mmap_sem); | ||
242 | /* Have to be a bit careful with return values */ | 240 | /* Have to be a bit careful with return values */ |
243 | if (nr > 0) | 241 | if (nr > 0) |
244 | ret = (ret < 0) ? nr : ret + nr; | 242 | ret = (ret < 0) ? nr : ret + nr; |
diff --git a/arch/sh/mm/gup.c b/arch/sh/mm/gup.c index 37458f38b220..e15f52a17b6c 100644 --- a/arch/sh/mm/gup.c +++ b/arch/sh/mm/gup.c | |||
@@ -257,10 +257,8 @@ slow_irqon: | |||
257 | start += nr << PAGE_SHIFT; | 257 | start += nr << PAGE_SHIFT; |
258 | pages += nr; | 258 | pages += nr; |
259 | 259 | ||
260 | down_read(&mm->mmap_sem); | 260 | ret = get_user_pages_unlocked(current, mm, start, |
261 | ret = get_user_pages(current, mm, start, | 261 | (end - start) >> PAGE_SHIFT, write, 0, pages); |
262 | (end - start) >> PAGE_SHIFT, write, 0, pages, NULL); | ||
263 | up_read(&mm->mmap_sem); | ||
264 | 262 | ||
265 | /* Have to be a bit careful with return values */ | 263 | /* Have to be a bit careful with return values */ |
266 | if (nr > 0) { | 264 | if (nr > 0) { |
diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c index ae6ce383d4df..2e5c4fc2daa9 100644 --- a/arch/sparc/mm/gup.c +++ b/arch/sparc/mm/gup.c | |||
@@ -249,10 +249,8 @@ slow: | |||
249 | start += nr << PAGE_SHIFT; | 249 | start += nr << PAGE_SHIFT; |
250 | pages += nr; | 250 | pages += nr; |
251 | 251 | ||
252 | down_read(&mm->mmap_sem); | 252 | ret = get_user_pages_unlocked(current, mm, start, |
253 | ret = get_user_pages(current, mm, start, | 253 | (end - start) >> PAGE_SHIFT, write, 0, pages); |
254 | (end - start) >> PAGE_SHIFT, write, 0, pages, NULL); | ||
255 | up_read(&mm->mmap_sem); | ||
256 | 254 | ||
257 | /* Have to be a bit careful with return values */ | 255 | /* Have to be a bit careful with return values */ |
258 | if (nr > 0) { | 256 | if (nr > 0) { |
diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c index 224b14235e96..89df70e0caa6 100644 --- a/arch/x86/mm/gup.c +++ b/arch/x86/mm/gup.c | |||
@@ -388,10 +388,9 @@ slow_irqon: | |||
388 | start += nr << PAGE_SHIFT; | 388 | start += nr << PAGE_SHIFT; |
389 | pages += nr; | 389 | pages += nr; |
390 | 390 | ||
391 | down_read(&mm->mmap_sem); | 391 | ret = get_user_pages_unlocked(current, mm, start, |
392 | ret = get_user_pages(current, mm, start, | 392 | (end - start) >> PAGE_SHIFT, |
393 | (end - start) >> PAGE_SHIFT, write, 0, pages, NULL); | 393 | write, 0, pages); |
394 | up_read(&mm->mmap_sem); | ||
395 | 394 | ||
396 | /* Have to be a bit careful with return values */ | 395 | /* Have to be a bit careful with return values */ |
397 | if (nr > 0) { | 396 | if (nr > 0) { |