diff options
author | Borislav Petkov <borislav.petkov@amd.com> | 2012-07-23 13:05:53 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2012-08-22 19:14:08 -0400 |
commit | 4dbf32c30f7e5379588a692c7bf80b05d9ef8026 (patch) | |
tree | da6d6bb8654b1dbd550b23f77233d4aad7baca1b /arch | |
parent | 36bf50d7697be18c6bfd0401e037df10bff1e573 (diff) |
x86, microcode: Save an indentation level in reload_for_cpu
Invert the uci->valid check so that the later block can be aligned on
the first indentation level of the function. No functional change.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Link: http://lkml.kernel.org/r/1344361461-10076-3-git-send-email-bp@amd64.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/microcode_core.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c index 4873e62db6a1..63a956865022 100644 --- a/arch/x86/kernel/microcode_core.c +++ b/arch/x86/kernel/microcode_core.c | |||
@@ -276,19 +276,18 @@ static struct platform_device *microcode_pdev; | |||
276 | static int reload_for_cpu(int cpu) | 276 | static int reload_for_cpu(int cpu) |
277 | { | 277 | { |
278 | struct ucode_cpu_info *uci = ucode_cpu_info + cpu; | 278 | struct ucode_cpu_info *uci = ucode_cpu_info + cpu; |
279 | enum ucode_state ustate; | ||
279 | int err = 0; | 280 | int err = 0; |
280 | 281 | ||
281 | if (uci->valid) { | 282 | if (!uci->valid) |
282 | enum ucode_state ustate; | 283 | return err; |
283 | |||
284 | ustate = microcode_ops->request_microcode_fw(cpu, µcode_pdev->dev); | ||
285 | if (ustate == UCODE_OK) | ||
286 | apply_microcode_on_target(cpu); | ||
287 | else | ||
288 | if (ustate == UCODE_ERROR) | ||
289 | err = -EINVAL; | ||
290 | } | ||
291 | 284 | ||
285 | ustate = microcode_ops->request_microcode_fw(cpu, µcode_pdev->dev); | ||
286 | if (ustate == UCODE_OK) | ||
287 | apply_microcode_on_target(cpu); | ||
288 | else | ||
289 | if (ustate == UCODE_ERROR) | ||
290 | err = -EINVAL; | ||
292 | return err; | 291 | return err; |
293 | } | 292 | } |
294 | 293 | ||