diff options
author | Christoph Lameter <clameter@sgi.com> | 2007-10-17 02:25:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:45 -0400 |
commit | 4ba9b9d0ba0a49d91fa6417c7510ee36f48cf957 (patch) | |
tree | 191b4f45f926e44b882b1e87a9a85dc12230b892 /arch | |
parent | b811c202a0edadaac7242ab834fe7ba409978ae7 (diff) |
Slab API: remove useless ctor parameter and reorder parameters
Slab constructors currently have a flags parameter that is never used. And
the order of the arguments is opposite to other slab functions. The object
pointer is placed before the kmem_cache pointer.
Convert
ctor(void *object, struct kmem_cache *s, unsigned long flags)
to
ctor(struct kmem_cache *s, void *object)
throughout the kernel
[akpm@linux-foundation.org: coupla fixes]
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/arm/plat-s3c24xx/dma.c | 2 | ||||
-rw-r--r-- | arch/powerpc/kernel/rtas_flash.c | 2 | ||||
-rw-r--r-- | arch/powerpc/mm/hugetlbpage.c | 2 | ||||
-rw-r--r-- | arch/powerpc/mm/init_64.c | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/spufs/inode.c | 2 | ||||
-rw-r--r-- | arch/sh/mm/pmb.c | 3 | ||||
-rw-r--r-- | arch/x86/mm/pgtable_32.c | 2 |
7 files changed, 7 insertions, 8 deletions
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 992ca435a922..29696e46ed65 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c | |||
@@ -1272,7 +1272,7 @@ struct sysdev_class dma_sysclass = { | |||
1272 | 1272 | ||
1273 | /* kmem cache implementation */ | 1273 | /* kmem cache implementation */ |
1274 | 1274 | ||
1275 | static void s3c2410_dma_cache_ctor(void *p, struct kmem_cache *c, unsigned long f) | 1275 | static void s3c2410_dma_cache_ctor(struct kmem_cache *c, void *p) |
1276 | { | 1276 | { |
1277 | memset(p, 0, sizeof(struct s3c2410_dma_buf)); | 1277 | memset(p, 0, sizeof(struct s3c2410_dma_buf)); |
1278 | } | 1278 | } |
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c index 62b7bf2f3eab..f2276593f416 100644 --- a/arch/powerpc/kernel/rtas_flash.c +++ b/arch/powerpc/kernel/rtas_flash.c | |||
@@ -286,7 +286,7 @@ static ssize_t rtas_flash_read(struct file *file, char __user *buf, | |||
286 | } | 286 | } |
287 | 287 | ||
288 | /* constructor for flash_block_cache */ | 288 | /* constructor for flash_block_cache */ |
289 | void rtas_block_ctor(void *ptr, struct kmem_cache *cache, unsigned long flags) | 289 | void rtas_block_ctor(struct kmem_cache *cache, void *ptr) |
290 | { | 290 | { |
291 | memset(ptr, 0, RTAS_BLK_SIZE); | 291 | memset(ptr, 0, RTAS_BLK_SIZE); |
292 | } | 292 | } |
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index 08f0d9ff7712..71efb38d599b 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c | |||
@@ -526,7 +526,7 @@ repeat: | |||
526 | return err; | 526 | return err; |
527 | } | 527 | } |
528 | 528 | ||
529 | static void zero_ctor(void *addr, struct kmem_cache *cache, unsigned long flags) | 529 | static void zero_ctor(struct kmem_cache *cache, void *addr) |
530 | { | 530 | { |
531 | memset(addr, 0, kmem_cache_size(cache)); | 531 | memset(addr, 0, kmem_cache_size(cache)); |
532 | } | 532 | } |
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c index 702d884a338a..e91da675bb3b 100644 --- a/arch/powerpc/mm/init_64.c +++ b/arch/powerpc/mm/init_64.c | |||
@@ -142,7 +142,7 @@ static int __init setup_kcore(void) | |||
142 | module_init(setup_kcore); | 142 | module_init(setup_kcore); |
143 | #endif | 143 | #endif |
144 | 144 | ||
145 | static void zero_ctor(void *addr, struct kmem_cache *cache, unsigned long flags) | 145 | static void zero_ctor(struct kmem_cache *cache, void *addr) |
146 | { | 146 | { |
147 | memset(addr, 0, kmem_cache_size(cache)); | 147 | memset(addr, 0, kmem_cache_size(cache)); |
148 | } | 148 | } |
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index 11098747d09b..0966d093db43 100644 --- a/arch/powerpc/platforms/cell/spufs/inode.c +++ b/arch/powerpc/platforms/cell/spufs/inode.c | |||
@@ -68,7 +68,7 @@ spufs_destroy_inode(struct inode *inode) | |||
68 | } | 68 | } |
69 | 69 | ||
70 | static void | 70 | static void |
71 | spufs_init_once(void *p, struct kmem_cache * cachep, unsigned long flags) | 71 | spufs_init_once(struct kmem_cache *cachep, void *p) |
72 | { | 72 | { |
73 | struct spufs_inode_info *ei = p; | 73 | struct spufs_inode_info *ei = p; |
74 | 74 | ||
diff --git a/arch/sh/mm/pmb.c b/arch/sh/mm/pmb.c index 7d43758dc244..1d45b82f0a63 100644 --- a/arch/sh/mm/pmb.c +++ b/arch/sh/mm/pmb.c | |||
@@ -292,8 +292,7 @@ void pmb_unmap(unsigned long addr) | |||
292 | } while (pmbe); | 292 | } while (pmbe); |
293 | } | 293 | } |
294 | 294 | ||
295 | static void pmb_cache_ctor(void *pmb, struct kmem_cache *cachep, | 295 | static void pmb_cache_ctor(struct kmem_cache *cachep, void *pmb) |
296 | unsigned long flags) | ||
297 | { | 296 | { |
298 | struct pmb_entry *pmbe = pmb; | 297 | struct pmb_entry *pmbe = pmb; |
299 | 298 | ||
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c index 01437c46baae..ef1f6cd3ea66 100644 --- a/arch/x86/mm/pgtable_32.c +++ b/arch/x86/mm/pgtable_32.c | |||
@@ -193,7 +193,7 @@ struct page *pte_alloc_one(struct mm_struct *mm, unsigned long address) | |||
193 | return pte; | 193 | return pte; |
194 | } | 194 | } |
195 | 195 | ||
196 | void pmd_ctor(void *pmd, struct kmem_cache *cache, unsigned long flags) | 196 | void pmd_ctor(struct kmem_cache *cache, void *pmd) |
197 | { | 197 | { |
198 | memset(pmd, 0, PTRS_PER_PMD*sizeof(pmd_t)); | 198 | memset(pmd, 0, PTRS_PER_PMD*sizeof(pmd_t)); |
199 | } | 199 | } |