diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2009-12-30 23:53:03 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-01-13 04:09:08 -0500 |
commit | 0fb8ee48d9dfff6a0913ceb0be2068d8be203763 (patch) | |
tree | a6178d0c99de3b4a9bdfce6757b79aafed0fe53b /arch | |
parent | 61405fea92c42d072d9b8bd189689f1502a838af (diff) |
perf: Drop useless check for ignored frame
The check that ignores the debug and nmi stack frames is useless
now that we have a frame pointer that makes us start at the
right place. We don't anymore have to deal with these.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1262235183-5320-2-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/include/asm/stacktrace.h | 2 | ||||
-rw-r--r-- | arch/x86/kernel/cpu/perf_event.c | 8 | ||||
-rw-r--r-- | arch/x86/kernel/dumpstack_32.c | 5 | ||||
-rw-r--r-- | arch/x86/kernel/dumpstack_64.c | 5 |
4 files changed, 0 insertions, 20 deletions
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h index 35e89122a42f..4dab78edbad9 100644 --- a/arch/x86/include/asm/stacktrace.h +++ b/arch/x86/include/asm/stacktrace.h | |||
@@ -3,8 +3,6 @@ | |||
3 | 3 | ||
4 | extern int kstack_depth_to_print; | 4 | extern int kstack_depth_to_print; |
5 | 5 | ||
6 | int x86_is_stack_id(int id, char *name); | ||
7 | |||
8 | struct thread_info; | 6 | struct thread_info; |
9 | struct stacktrace_ops; | 7 | struct stacktrace_ops; |
10 | 8 | ||
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c index d616c06e99b4..b1bb8c550526 100644 --- a/arch/x86/kernel/cpu/perf_event.c +++ b/arch/x86/kernel/cpu/perf_event.c | |||
@@ -2297,7 +2297,6 @@ void callchain_store(struct perf_callchain_entry *entry, u64 ip) | |||
2297 | 2297 | ||
2298 | static DEFINE_PER_CPU(struct perf_callchain_entry, pmc_irq_entry); | 2298 | static DEFINE_PER_CPU(struct perf_callchain_entry, pmc_irq_entry); |
2299 | static DEFINE_PER_CPU(struct perf_callchain_entry, pmc_nmi_entry); | 2299 | static DEFINE_PER_CPU(struct perf_callchain_entry, pmc_nmi_entry); |
2300 | static DEFINE_PER_CPU(int, in_ignored_frame); | ||
2301 | 2300 | ||
2302 | 2301 | ||
2303 | static void | 2302 | static void |
@@ -2313,10 +2312,6 @@ static void backtrace_warning(void *data, char *msg) | |||
2313 | 2312 | ||
2314 | static int backtrace_stack(void *data, char *name) | 2313 | static int backtrace_stack(void *data, char *name) |
2315 | { | 2314 | { |
2316 | per_cpu(in_ignored_frame, smp_processor_id()) = | ||
2317 | x86_is_stack_id(NMI_STACK, name) || | ||
2318 | x86_is_stack_id(DEBUG_STACK, name); | ||
2319 | |||
2320 | return 0; | 2315 | return 0; |
2321 | } | 2316 | } |
2322 | 2317 | ||
@@ -2324,9 +2319,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable) | |||
2324 | { | 2319 | { |
2325 | struct perf_callchain_entry *entry = data; | 2320 | struct perf_callchain_entry *entry = data; |
2326 | 2321 | ||
2327 | if (per_cpu(in_ignored_frame, smp_processor_id())) | ||
2328 | return; | ||
2329 | |||
2330 | if (reliable) | 2322 | if (reliable) |
2331 | callchain_store(entry, addr); | 2323 | callchain_store(entry, addr); |
2332 | } | 2324 | } |
diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c index ae775ca47b25..11540a189d93 100644 --- a/arch/x86/kernel/dumpstack_32.c +++ b/arch/x86/kernel/dumpstack_32.c | |||
@@ -18,11 +18,6 @@ | |||
18 | 18 | ||
19 | #include "dumpstack.h" | 19 | #include "dumpstack.h" |
20 | 20 | ||
21 | /* Just a stub for now */ | ||
22 | int x86_is_stack_id(int id, char *name) | ||
23 | { | ||
24 | return 0; | ||
25 | } | ||
26 | 21 | ||
27 | void dump_trace(struct task_struct *task, struct pt_regs *regs, | 22 | void dump_trace(struct task_struct *task, struct pt_regs *regs, |
28 | unsigned long *stack, unsigned long bp, | 23 | unsigned long *stack, unsigned long bp, |
diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c index 0ad9597073f5..676bc051252e 100644 --- a/arch/x86/kernel/dumpstack_64.c +++ b/arch/x86/kernel/dumpstack_64.c | |||
@@ -33,11 +33,6 @@ static char x86_stack_ids[][8] = { | |||
33 | #endif | 33 | #endif |
34 | }; | 34 | }; |
35 | 35 | ||
36 | int x86_is_stack_id(int id, char *name) | ||
37 | { | ||
38 | return x86_stack_ids[id - 1] == name; | ||
39 | } | ||
40 | |||
41 | static unsigned long *in_exception_stack(unsigned cpu, unsigned long stack, | 36 | static unsigned long *in_exception_stack(unsigned cpu, unsigned long stack, |
42 | unsigned *usedp, char **idp) | 37 | unsigned *usedp, char **idp) |
43 | { | 38 | { |