diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2005-06-25 17:57:43 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-25 19:24:46 -0400 |
commit | cee5dab4856f51c5cad3aecc630ad0a4d2217a85 (patch) | |
tree | 5798e045caf95519093d69609d7b8d2b20af4175 /arch | |
parent | 70adada4282b52130ef31c7722d3fd8d94dacbc2 (diff) |
[PATCH] kexec: x86: i8259 shutdown: disable interrupts
From: Eric W. Biederman <ebiederm@xmission.com>
This patch disables interrupt generation from the legacy pic on reboot. Now
that there is a sys_device class it should not be called while drivers are
still using interrupts.
There is a report about this breaking ACPI power off on some systems.
http://bugme.osdl.org/show_bug.cgi?id=4041
However the final comment seems to exonerate this code. So until
I get more information I believe that was a false positive.
Signed-off-by: Eric Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/i386/kernel/i8259.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/arch/i386/kernel/i8259.c b/arch/i386/kernel/i8259.c index 2c4813b47e57..178f4e9bac9d 100644 --- a/arch/i386/kernel/i8259.c +++ b/arch/i386/kernel/i8259.c | |||
@@ -268,10 +268,22 @@ static int i8259A_suspend(struct sys_device *dev, pm_message_t state) | |||
268 | return 0; | 268 | return 0; |
269 | } | 269 | } |
270 | 270 | ||
271 | static int i8259A_shutdown(struct sys_device *dev) | ||
272 | { | ||
273 | /* Put the i8259A into a quiescent state that | ||
274 | * the kernel initialization code can get it | ||
275 | * out of. | ||
276 | */ | ||
277 | outb(0xff, 0x21); /* mask all of 8259A-1 */ | ||
278 | outb(0xff, 0xA1); /* mask all of 8259A-1 */ | ||
279 | return 0; | ||
280 | } | ||
281 | |||
271 | static struct sysdev_class i8259_sysdev_class = { | 282 | static struct sysdev_class i8259_sysdev_class = { |
272 | set_kset_name("i8259"), | 283 | set_kset_name("i8259"), |
273 | .suspend = i8259A_suspend, | 284 | .suspend = i8259A_suspend, |
274 | .resume = i8259A_resume, | 285 | .resume = i8259A_resume, |
286 | .shutdown = i8259A_shutdown, | ||
275 | }; | 287 | }; |
276 | 288 | ||
277 | static struct sys_device device_i8259A = { | 289 | static struct sys_device device_i8259A = { |