x86: Create clflush() inline, remove hardcoded wbinvd

Create an inline function for clflush(), with the proper arguments,
and use it instead of hard-coding the instruction.

This also removes one instance of hard-coded wbinvd, based on a patch
by Bauder de Oliveira Costa.

[ tglx: arch/x86 adaptation ]

Cc: Andi Kleen <andi@firstfloor.org>
Cc: Glauber de Oliveira Costa <gcosta@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

3 files changed, 5 insertions, 5 deletions

diff --git a/arch/x86/kernel/tce_64.c b/arch/x86/kernel/tce_64.c
index e3f2569b2c44..9e540fee7009 100644
--- a/arch/x86/kernel/tce_64.c
+++ b/arch/x86/kernel/tce_64.c
@@ -40,9 +40,9 @@ static inline void flush_tce(void* tceaddr)
 {
         /* a single tce can't cross a cache line */
         if (cpu_has_clflush)
-                asm volatile("clflush (%0)" :: "r" (tceaddr));
+                clflush(tceaddr);
         else
-                asm volatile("wbinvd":::"memory");
+                wbinvd();
 }
 
 void tce_build(struct iommu_table *tbl, unsigned long index,
diff --git a/arch/x86/mm/pageattr_32.c b/arch/x86/mm/pageattr_32.c
index 4241a74d16c8..260073c07600 100644
--- a/arch/x86/mm/pageattr_32.c
+++ b/arch/x86/mm/pageattr_32.c
@@ -70,10 +70,10 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
 
 static void cache_flush_page(struct page *p)
 { 
-        unsigned long adr = (unsigned long)page_address(p);
+        void *adr = page_address(p);
         int i;
         for (i = 0; i < PAGE_SIZE; i += boot_cpu_data.x86_clflush_size)
-                asm volatile("clflush (%0)" :: "r" (adr + i));
+                clflush(adr+i);
 }
 
 static void flush_kernel_map(void *arg)
diff --git a/arch/x86/mm/pageattr_64.c b/arch/x86/mm/pageattr_64.c
index 93d795d7c2ae..8a4f65bf956e 100644
--- a/arch/x86/mm/pageattr_64.c
+++ b/arch/x86/mm/pageattr_64.c
@@ -65,7 +65,7 @@ static void cache_flush_page(void *adr)
 {
         int i;
         for (i = 0; i < PAGE_SIZE; i += boot_cpu_data.x86_clflush_size)
-                asm volatile("clflush (%0)" :: "r" (adr + i));
+                clflush(adr+i);
 }
 
 static void flush_kernel_map(void *arg)