diff options
author | Jeff Garzik <jeff@garzik.org> | 2008-04-18 19:23:01 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-05-12 11:46:52 -0400 |
commit | 1c9e919f48a49fda2ff2c607891cc17024e75122 (patch) | |
tree | bcd76fc9ca5def3babe2ba6fe2ae6fea3e1a3dba /arch | |
parent | a64063046026729a69ad06c94453f4ddaa562d60 (diff) |
[MIPS] msp_hwbutton.c: minor irq handler cleanups
- remove always-true test
- neaten request_irq() indentation
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c index ab96a2d7f4c4..11769b55438c 100644 --- a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c +++ b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | |||
@@ -126,9 +126,6 @@ static irqreturn_t hwbutton_handler(int irq, void *data) | |||
126 | struct hwbutton_interrupt *hirq = data; | 126 | struct hwbutton_interrupt *hirq = data; |
127 | unsigned long cic_ext = *CIC_EXT_CFG_REG; | 127 | unsigned long cic_ext = *CIC_EXT_CFG_REG; |
128 | 128 | ||
129 | if (irq != hirq->irq) | ||
130 | return IRQ_NONE; | ||
131 | |||
132 | if (CIC_EXT_IS_ACTIVE_HI(cic_ext, hirq->eirq)) { | 129 | if (CIC_EXT_IS_ACTIVE_HI(cic_ext, hirq->eirq)) { |
133 | /* Interrupt: pin is now HI */ | 130 | /* Interrupt: pin is now HI */ |
134 | CIC_EXT_SET_ACTIVE_LO(cic_ext, hirq->eirq); | 131 | CIC_EXT_SET_ACTIVE_LO(cic_ext, hirq->eirq); |
@@ -164,7 +161,7 @@ static int msp_hwbutton_register(struct hwbutton_interrupt *hirq) | |||
164 | *CIC_EXT_CFG_REG = cic_ext; | 161 | *CIC_EXT_CFG_REG = cic_ext; |
165 | 162 | ||
166 | return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED, | 163 | return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED, |
167 | hirq->name, (void *)hirq); | 164 | hirq->name, hirq); |
168 | } | 165 | } |
169 | 166 | ||
170 | static int __init msp_hwbutton_setup(void) | 167 | static int __init msp_hwbutton_setup(void) |