diff options
author | K.Prasad <prasad@linux.vnet.ibm.com> | 2010-03-29 19:59:25 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-04-07 00:44:38 -0400 |
commit | 9c7cc234dc5edf5379fbbab4973f6704f59bc57b (patch) | |
tree | 6129dffa0ffc36da27718059c9b2ff40b74aa16b /arch | |
parent | 578b7cd1518f8d1b17a7fb1671d3d756c9cb49f1 (diff) |
powerpc: Disable interrupts for data breakpoint exceptions
Data address breakpoint exceptions are currently handled along with page-faults
which require interrupts to remain in enabled state. Since exception handling
for data breakpoints aren't pre-empt safe, we handle them separately.
Signed-off-by: K.Prasad <prasad@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/powerpc/kernel/exceptions-64s.S | 13 | ||||
-rw-r--r-- | arch/powerpc/mm/fault.c | 5 |
2 files changed, 15 insertions, 3 deletions
diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index e3be98ffe2a7..3e423fbad6bc 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S | |||
@@ -735,8 +735,11 @@ _STATIC(do_hash_page) | |||
735 | std r3,_DAR(r1) | 735 | std r3,_DAR(r1) |
736 | std r4,_DSISR(r1) | 736 | std r4,_DSISR(r1) |
737 | 737 | ||
738 | andis. r0,r4,0xa450 /* weird error? */ | 738 | andis. r0,r4,0xa410 /* weird error? */ |
739 | bne- handle_page_fault /* if not, try to insert a HPTE */ | 739 | bne- handle_page_fault /* if not, try to insert a HPTE */ |
740 | andis. r0,r4,DSISR_DABRMATCH@h | ||
741 | bne- handle_dabr_fault | ||
742 | |||
740 | BEGIN_FTR_SECTION | 743 | BEGIN_FTR_SECTION |
741 | andis. r0,r4,0x0020 /* Is it a segment table fault? */ | 744 | andis. r0,r4,0x0020 /* Is it a segment table fault? */ |
742 | bne- do_ste_alloc /* If so handle it */ | 745 | bne- do_ste_alloc /* If so handle it */ |
@@ -823,6 +826,14 @@ END_FW_FTR_SECTION_IFCLR(FW_FEATURE_ISERIES) | |||
823 | bl .raw_local_irq_restore | 826 | bl .raw_local_irq_restore |
824 | b 11f | 827 | b 11f |
825 | 828 | ||
829 | /* We have a data breakpoint exception - handle it */ | ||
830 | handle_dabr_fault: | ||
831 | ld r4,_DAR(r1) | ||
832 | ld r5,_DSISR(r1) | ||
833 | addi r3,r1,STACK_FRAME_OVERHEAD | ||
834 | bl .do_dabr | ||
835 | b .ret_from_except_lite | ||
836 | |||
826 | /* Here we have a page fault that hash_page can't handle. */ | 837 | /* Here we have a page fault that hash_page can't handle. */ |
827 | handle_page_fault: | 838 | handle_page_fault: |
828 | ENABLE_INTS | 839 | ENABLE_INTS |
diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c index 26fb6b990b0a..83ac4935eb10 100644 --- a/arch/powerpc/mm/fault.c +++ b/arch/powerpc/mm/fault.c | |||
@@ -151,13 +151,14 @@ int __kprobes do_page_fault(struct pt_regs *regs, unsigned long address, | |||
151 | if (!user_mode(regs) && (address >= TASK_SIZE)) | 151 | if (!user_mode(regs) && (address >= TASK_SIZE)) |
152 | return SIGSEGV; | 152 | return SIGSEGV; |
153 | 153 | ||
154 | #if !(defined(CONFIG_4xx) || defined(CONFIG_BOOKE)) | 154 | #if !(defined(CONFIG_4xx) || defined(CONFIG_BOOKE) || \ |
155 | defined(CONFIG_PPC_BOOK3S_64)) | ||
155 | if (error_code & DSISR_DABRMATCH) { | 156 | if (error_code & DSISR_DABRMATCH) { |
156 | /* DABR match */ | 157 | /* DABR match */ |
157 | do_dabr(regs, address, error_code); | 158 | do_dabr(regs, address, error_code); |
158 | return 0; | 159 | return 0; |
159 | } | 160 | } |
160 | #endif /* !(CONFIG_4xx || CONFIG_BOOKE)*/ | 161 | #endif |
161 | 162 | ||
162 | if (in_atomic() || mm == NULL) { | 163 | if (in_atomic() || mm == NULL) { |
163 | if (!user_mode(regs)) | 164 | if (!user_mode(regs)) |