diff options
author | Guenter Roeck <linux@roeck-us.net> | 2014-08-31 14:14:26 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-31 20:08:12 -0400 |
commit | ca98565a6182a960cd857d7546267a0775154eb8 (patch) | |
tree | fd18f1e228d7386881b982bcd4c9a61cf6ca4c42 /arch | |
parent | 94559a4a81a6912f6ca22988e544a43401947c68 (diff) |
unicore32: Fix build error
unicore32 builds fail with
arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
arch/unicore32/kernel/signal.c:257: error: ‘usig’ undeclared (first use in this function)
arch/unicore32/kernel/signal.c:279: error: ‘usig’ undeclared (first use in this function)
arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
arch/unicore32/kernel/signal.c: In function ‘do_signal’:
arch/unicore32/kernel/signal.c:376: error: implicit declaration of function ‘get_signsl’
make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
make: *** [arch/unicore32/kernel/signal.o] Error 2
Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
signal_setup_done()").
This code never even compiled. Reverting the patch does not work, since
previously used functions no longer exist, so try to fix it up. Compile
tested only.
Fixes: 649671c90eaf ("unicore32: Use get_signal() signal_setup_done()")
Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/unicore32/kernel/signal.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/arch/unicore32/kernel/signal.c b/arch/unicore32/kernel/signal.c index 780d77388dec..7c8fb7018dc6 100644 --- a/arch/unicore32/kernel/signal.c +++ b/arch/unicore32/kernel/signal.c | |||
@@ -254,7 +254,8 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set, | |||
254 | 254 | ||
255 | err |= setup_sigframe(frame, regs, set); | 255 | err |= setup_sigframe(frame, regs, set); |
256 | if (err == 0) | 256 | if (err == 0) |
257 | err |= setup_return(regs, &ksig->ka, frame->retcode, frame, usig); | 257 | err |= setup_return(regs, &ksig->ka, frame->retcode, frame, |
258 | ksig->sig); | ||
258 | 259 | ||
259 | return err; | 260 | return err; |
260 | } | 261 | } |
@@ -276,7 +277,8 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set, | |||
276 | err |= __save_altstack(&frame->sig.uc.uc_stack, regs->UCreg_sp); | 277 | err |= __save_altstack(&frame->sig.uc.uc_stack, regs->UCreg_sp); |
277 | err |= setup_sigframe(&frame->sig, regs, set); | 278 | err |= setup_sigframe(&frame->sig, regs, set); |
278 | if (err == 0) | 279 | if (err == 0) |
279 | err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame, usig); | 280 | err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame, |
281 | ksig->sig); | ||
280 | 282 | ||
281 | if (err == 0) { | 283 | if (err == 0) { |
282 | /* | 284 | /* |
@@ -303,7 +305,6 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs, | |||
303 | int syscall) | 305 | int syscall) |
304 | { | 306 | { |
305 | struct thread_info *thread = current_thread_info(); | 307 | struct thread_info *thread = current_thread_info(); |
306 | struct task_struct *tsk = current; | ||
307 | sigset_t *oldset = sigmask_to_save(); | 308 | sigset_t *oldset = sigmask_to_save(); |
308 | int usig = ksig->sig; | 309 | int usig = ksig->sig; |
309 | int ret; | 310 | int ret; |
@@ -373,7 +374,7 @@ static void do_signal(struct pt_regs *regs, int syscall) | |||
373 | if (!user_mode(regs)) | 374 | if (!user_mode(regs)) |
374 | return; | 375 | return; |
375 | 376 | ||
376 | if (get_signsl(&ksig)) { | 377 | if (get_signal(&ksig)) { |
377 | handle_signal(&ksig, regs, syscall); | 378 | handle_signal(&ksig, regs, syscall); |
378 | return; | 379 | return; |
379 | } | 380 | } |