aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorDaniel Lezcano <daniel.lezcano@linaro.org>2013-04-12 08:35:49 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-04-21 19:05:16 -0400
commit3dcb9f1b17879534c80ccbf62fd13156f83ef799 (patch)
treefadb13d195e4f00b2ffe2d98f0ea064d0e1556e9 /arch
parent80d538b2754f1eed85296f0c7088f7157d543f89 (diff)
ARM: OMAP3: remove cpuidle_wrap_enter
In a previous commit the en_core_tk_irqen flag has been added but we missed the cpuidle_wrap_enter which was doing the job to measure the time for the 'omap3_enter_idle' function. Actually, I don't see any reason to use this wrapper in the code. In the better case, the time computation is not correctly done because of the different operations done in omap3_enter_idle_bm which were not taken into account before the en_core_tk_irqen flag was set. As the time is reflected for the state overridden by the omap3_enter_idle_bm, using the wrapper is pointless now, so removing it. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Kevin Hilman <khilman@linaro.org> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/mach-omap2/cpuidle34xx.c30
1 files changed, 9 insertions, 21 deletions
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
index a300122caddd..0ee39a8b1763 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++ b/arch/arm/mach-omap2/cpuidle34xx.c
@@ -99,11 +99,15 @@ static struct omap3_idle_statedata omap3_idle_data[] = {
99 }, 99 },
100}; 100};
101 101
102/* Private functions */ 102/**
103 103 * omap3_enter_idle - Programs OMAP3 to enter the specified state
104static int __omap3_enter_idle(struct cpuidle_device *dev, 104 * @dev: cpuidle device
105 struct cpuidle_driver *drv, 105 * @drv: cpuidle driver
106 int index) 106 * @index: the index of state to be entered
107 */
108static int omap3_enter_idle(struct cpuidle_device *dev,
109 struct cpuidle_driver *drv,
110 int index)
107{ 111{
108 struct omap3_idle_statedata *cx = &omap3_idle_data[index]; 112 struct omap3_idle_statedata *cx = &omap3_idle_data[index];
109 113
@@ -149,22 +153,6 @@ return_sleep_time:
149} 153}
150 154
151/** 155/**
152 * omap3_enter_idle - Programs OMAP3 to enter the specified state
153 * @dev: cpuidle device
154 * @drv: cpuidle driver
155 * @index: the index of state to be entered
156 *
157 * Called from the CPUidle framework to program the device to the
158 * specified target state selected by the governor.
159 */
160static inline int omap3_enter_idle(struct cpuidle_device *dev,
161 struct cpuidle_driver *drv,
162 int index)
163{
164 return cpuidle_wrap_enter(dev, drv, index, __omap3_enter_idle);
165}
166
167/**
168 * next_valid_state - Find next valid C-state 156 * next_valid_state - Find next valid C-state
169 * @dev: cpuidle device 157 * @dev: cpuidle device
170 * @drv: cpuidle driver 158 * @drv: cpuidle driver