diff options
author | Thomas Renninger <trenn@suse.de> | 2009-04-22 07:48:32 -0400 |
---|---|---|
committer | Dave Jones <davej@redhat.com> | 2009-05-26 12:04:51 -0400 |
commit | df1829770db415dc5a5ed5ada3bd70176c6f0a01 (patch) | |
tree | 6c9862b0c5dc58ab8d0093985a4fc56b820c0a69 /arch | |
parent | b14893a62c73af0eca414cfed505b8c09efc613c (diff) |
[CPUFREQ] powernow-k8 cleanup msg if BIOS does not export ACPI _PSS cpufreq data
- Make the message shorter and easier to grep for
- Use printk_once instead of WARN_ONCE (functionality of these was mixed)
Signed-off-by: Thomas Renninger <trenn@suse.de>
Cc: Langsdorf, Mark <mark.langsdorf@amd.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c index 4709ead2db52..feef10c085a1 100644 --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c | |||
@@ -1215,13 +1215,16 @@ static int powernowk8_verify(struct cpufreq_policy *pol) | |||
1215 | return cpufreq_frequency_table_verify(pol, data->powernow_table); | 1215 | return cpufreq_frequency_table_verify(pol, data->powernow_table); |
1216 | } | 1216 | } |
1217 | 1217 | ||
1218 | static const char ACPI_PSS_BIOS_BUG_MSG[] = | ||
1219 | KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n" | ||
1220 | KERN_ERR FW_BUG PFX "Try again with latest BIOS.\n"; | ||
1221 | |||
1218 | /* per CPU init entry point to the driver */ | 1222 | /* per CPU init entry point to the driver */ |
1219 | static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) | 1223 | static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) |
1220 | { | 1224 | { |
1221 | struct powernow_k8_data *data; | 1225 | struct powernow_k8_data *data; |
1222 | cpumask_t oldmask; | 1226 | cpumask_t oldmask; |
1223 | int rc; | 1227 | int rc; |
1224 | static int print_once; | ||
1225 | 1228 | ||
1226 | if (!cpu_online(pol->cpu)) | 1229 | if (!cpu_online(pol->cpu)) |
1227 | return -ENODEV; | 1230 | return -ENODEV; |
@@ -1244,19 +1247,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) | |||
1244 | * an UP version, and is deprecated by AMD. | 1247 | * an UP version, and is deprecated by AMD. |
1245 | */ | 1248 | */ |
1246 | if (num_online_cpus() != 1) { | 1249 | if (num_online_cpus() != 1) { |
1247 | /* | 1250 | printk_once(ACPI_PSS_BIOS_BUG_MSG); |
1248 | * Replace this one with print_once as soon as such a | ||
1249 | * thing gets introduced | ||
1250 | */ | ||
1251 | if (!print_once) { | ||
1252 | WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS " | ||
1253 | "does not provide ACPI _PSS objects " | ||
1254 | "in a way that Linux understands. " | ||
1255 | "Please report this to the Linux ACPI" | ||
1256 | " maintainers and complain to your " | ||
1257 | "BIOS vendor.\n"); | ||
1258 | print_once++; | ||
1259 | } | ||
1260 | goto err_out; | 1251 | goto err_out; |
1261 | } | 1252 | } |
1262 | if (pol->cpu != 0) { | 1253 | if (pol->cpu != 0) { |