diff options
author | Anton Blanchard <anton@samba.org> | 2010-01-04 10:26:33 -0500 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-01-14 21:20:07 -0500 |
commit | 92cb3694dd8da8769f9415790e169b9cf3a16fcb (patch) | |
tree | 8098b4b455879b4aa61cd9d8c7961e723c37d031 /arch | |
parent | e443ed35606cf921cbf9d6949010a5b36bbe747d (diff) |
powerpc/pseries: Fix xics interrupt affinity
Commit 57b150cce8e004ddd36330490a68bfb59b7271e9 (irq: only update affinity if
->set_affinity() is sucessfull) broke xics irq affinity.
We need to use the cpumask passed in, instead of accessing ->affinity directly.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/powerpc/platforms/pseries/xics.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c index b9b9e11609ec..d80f193cd871 100644 --- a/arch/powerpc/platforms/pseries/xics.c +++ b/arch/powerpc/platforms/pseries/xics.c | |||
@@ -163,14 +163,13 @@ static inline void lpar_qirr_info(int n_cpu , u8 value) | |||
163 | /* Interface to generic irq subsystem */ | 163 | /* Interface to generic irq subsystem */ |
164 | 164 | ||
165 | #ifdef CONFIG_SMP | 165 | #ifdef CONFIG_SMP |
166 | static int get_irq_server(unsigned int virq, unsigned int strict_check) | 166 | static int get_irq_server(unsigned int virq, cpumask_t cpumask, |
167 | unsigned int strict_check) | ||
167 | { | 168 | { |
168 | int server; | 169 | int server; |
169 | /* For the moment only implement delivery to all cpus or one cpu */ | 170 | /* For the moment only implement delivery to all cpus or one cpu */ |
170 | cpumask_t cpumask; | ||
171 | cpumask_t tmp = CPU_MASK_NONE; | 171 | cpumask_t tmp = CPU_MASK_NONE; |
172 | 172 | ||
173 | cpumask_copy(&cpumask, irq_to_desc(virq)->affinity); | ||
174 | if (!distribute_irqs) | 173 | if (!distribute_irqs) |
175 | return default_server; | 174 | return default_server; |
176 | 175 | ||
@@ -192,7 +191,8 @@ static int get_irq_server(unsigned int virq, unsigned int strict_check) | |||
192 | return default_server; | 191 | return default_server; |
193 | } | 192 | } |
194 | #else | 193 | #else |
195 | static int get_irq_server(unsigned int virq, unsigned int strict_check) | 194 | static int get_irq_server(unsigned int virq, cpumask_t cpumask, |
195 | unsigned int strict_check) | ||
196 | { | 196 | { |
197 | return default_server; | 197 | return default_server; |
198 | } | 198 | } |
@@ -211,7 +211,7 @@ static void xics_unmask_irq(unsigned int virq) | |||
211 | if (irq == XICS_IPI || irq == XICS_IRQ_SPURIOUS) | 211 | if (irq == XICS_IPI || irq == XICS_IRQ_SPURIOUS) |
212 | return; | 212 | return; |
213 | 213 | ||
214 | server = get_irq_server(virq, 0); | 214 | server = get_irq_server(virq, *(irq_to_desc(virq)->affinity), 0); |
215 | 215 | ||
216 | call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq, server, | 216 | call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq, server, |
217 | DEFAULT_PRIORITY); | 217 | DEFAULT_PRIORITY); |
@@ -405,7 +405,7 @@ static int xics_set_affinity(unsigned int virq, const struct cpumask *cpumask) | |||
405 | * For the moment only implement delivery to all cpus or one cpu. | 405 | * For the moment only implement delivery to all cpus or one cpu. |
406 | * Get current irq_server for the given irq | 406 | * Get current irq_server for the given irq |
407 | */ | 407 | */ |
408 | irq_server = get_irq_server(virq, 1); | 408 | irq_server = get_irq_server(virq, *cpumask, 1); |
409 | if (irq_server == -1) { | 409 | if (irq_server == -1) { |
410 | char cpulist[128]; | 410 | char cpulist[128]; |
411 | cpumask_scnprintf(cpulist, sizeof(cpulist), cpumask); | 411 | cpumask_scnprintf(cpulist, sizeof(cpulist), cpumask); |