diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2008-10-16 06:18:50 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-10-16 10:53:30 -0400 |
commit | 249f6d9eab372790579ada8991bba3384c204e06 (patch) | |
tree | 4af29e889c073ec317e7674f2165e49c9adab9b1 /arch | |
parent | 6b39ba771e3c78d00e0abcebad270bd4212b28bc (diff) |
x86: move ack_bad_irq() to irq.c
Share more duplicated code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/irq.c | 23 | ||||
-rw-r--r-- | arch/x86/kernel/irq_32.c | 23 | ||||
-rw-r--r-- | arch/x86/kernel/irq_64.c | 20 |
3 files changed, 23 insertions, 43 deletions
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 3b9128498976..ccf6c503fc3b 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c | |||
@@ -12,6 +12,29 @@ | |||
12 | 12 | ||
13 | atomic_t irq_err_count; | 13 | atomic_t irq_err_count; |
14 | 14 | ||
15 | /* | ||
16 | * 'what should we do if we get a hw irq event on an illegal vector'. | ||
17 | * each architecture has to answer this themselves. | ||
18 | */ | ||
19 | void ack_bad_irq(unsigned int irq) | ||
20 | { | ||
21 | printk(KERN_ERR "unexpected IRQ trap at vector %02x\n", irq); | ||
22 | |||
23 | #ifdef CONFIG_X86_LOCAL_APIC | ||
24 | /* | ||
25 | * Currently unexpected vectors happen only on SMP and APIC. | ||
26 | * We _must_ ack these because every local APIC has only N | ||
27 | * irq slots per priority level, and a 'hanging, unacked' IRQ | ||
28 | * holds up an irq slot - in excessive cases (when multiple | ||
29 | * unexpected vectors occur) that might lock up the APIC | ||
30 | * completely. | ||
31 | * But only ack when the APIC is enabled -AK | ||
32 | */ | ||
33 | if (cpu_has_apic) | ||
34 | ack_APIC_irq(); | ||
35 | #endif | ||
36 | } | ||
37 | |||
15 | #ifdef CONFIG_X86_32 | 38 | #ifdef CONFIG_X86_32 |
16 | # define irq_stats(x) (&per_cpu(irq_stat,x)) | 39 | # define irq_stats(x) (&per_cpu(irq_stat,x)) |
17 | #else | 40 | #else |
diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c index 6d9bf3936c78..a51382672de0 100644 --- a/arch/x86/kernel/irq_32.c +++ b/arch/x86/kernel/irq_32.c | |||
@@ -25,29 +25,6 @@ EXPORT_PER_CPU_SYMBOL(irq_stat); | |||
25 | DEFINE_PER_CPU(struct pt_regs *, irq_regs); | 25 | DEFINE_PER_CPU(struct pt_regs *, irq_regs); |
26 | EXPORT_PER_CPU_SYMBOL(irq_regs); | 26 | EXPORT_PER_CPU_SYMBOL(irq_regs); |
27 | 27 | ||
28 | /* | ||
29 | * 'what should we do if we get a hw irq event on an illegal vector'. | ||
30 | * each architecture has to answer this themselves. | ||
31 | */ | ||
32 | void ack_bad_irq(unsigned int irq) | ||
33 | { | ||
34 | printk(KERN_ERR "unexpected IRQ trap at vector %02x\n", irq); | ||
35 | |||
36 | #ifdef CONFIG_X86_LOCAL_APIC | ||
37 | /* | ||
38 | * Currently unexpected vectors happen only on SMP and APIC. | ||
39 | * We _must_ ack these because every local APIC has only N | ||
40 | * irq slots per priority level, and a 'hanging, unacked' IRQ | ||
41 | * holds up an irq slot - in excessive cases (when multiple | ||
42 | * unexpected vectors occur) that might lock up the APIC | ||
43 | * completely. | ||
44 | * But only ack when the APIC is enabled -AK | ||
45 | */ | ||
46 | if (cpu_has_apic) | ||
47 | ack_APIC_irq(); | ||
48 | #endif | ||
49 | } | ||
50 | |||
51 | #ifdef CONFIG_DEBUG_STACKOVERFLOW | 28 | #ifdef CONFIG_DEBUG_STACKOVERFLOW |
52 | /* Debugging check for stack overflow: is there less than 1KB free? */ | 29 | /* Debugging check for stack overflow: is there less than 1KB free? */ |
53 | static int check_stack_overflow(void) | 30 | static int check_stack_overflow(void) |
diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c index 39ef7feb9ea4..60eb84eb77a0 100644 --- a/arch/x86/kernel/irq_64.c +++ b/arch/x86/kernel/irq_64.c | |||
@@ -18,26 +18,6 @@ | |||
18 | #include <asm/idle.h> | 18 | #include <asm/idle.h> |
19 | #include <asm/smp.h> | 19 | #include <asm/smp.h> |
20 | 20 | ||
21 | /* | ||
22 | * 'what should we do if we get a hw irq event on an illegal vector'. | ||
23 | * each architecture has to answer this themselves. | ||
24 | */ | ||
25 | void ack_bad_irq(unsigned int irq) | ||
26 | { | ||
27 | printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq); | ||
28 | /* | ||
29 | * Currently unexpected vectors happen only on SMP and APIC. | ||
30 | * We _must_ ack these because every local APIC has only N | ||
31 | * irq slots per priority level, and a 'hanging, unacked' IRQ | ||
32 | * holds up an irq slot - in excessive cases (when multiple | ||
33 | * unexpected vectors occur) that might lock up the APIC | ||
34 | * completely. | ||
35 | * But don't ack when the APIC is disabled. -AK | ||
36 | */ | ||
37 | if (!disable_apic) | ||
38 | ack_APIC_irq(); | ||
39 | } | ||
40 | |||
41 | #ifdef CONFIG_DEBUG_STACKOVERFLOW | 21 | #ifdef CONFIG_DEBUG_STACKOVERFLOW |
42 | /* | 22 | /* |
43 | * Probabilistic stack overflow check: | 23 | * Probabilistic stack overflow check: |