diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-16 06:11:48 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-18 11:37:40 -0500 |
commit | 6d4561110a3e9fa742aeec6717248a491dfb1878 (patch) | |
tree | 689e2abf19940416ce597ba56ed31026ff59bd21 /arch | |
parent | 86926d0096279b9739ceeff40f68d3c33b9119a9 (diff) |
sysctl: Drop & in front of every proc_handler.
For consistency drop & in front of every proc_handler. Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/arm/kernel/isa.c | 6 | ||||
-rw-r--r-- | arch/arm/mach-bcmring/arch.c | 2 | ||||
-rw-r--r-- | arch/frv/kernel/pm.c | 8 | ||||
-rw-r--r-- | arch/frv/kernel/sysctl.c | 4 | ||||
-rw-r--r-- | arch/ia64/kernel/crash.c | 4 | ||||
-rw-r--r-- | arch/ia64/kernel/perfmon.c | 8 | ||||
-rw-r--r-- | arch/mips/lasat/sysctl.c | 22 | ||||
-rw-r--r-- | arch/powerpc/kernel/idle.c | 2 | ||||
-rw-r--r-- | arch/s390/appldata/appldata_base.c | 4 | ||||
-rw-r--r-- | arch/s390/kernel/debug.c | 4 | ||||
-rw-r--r-- | arch/s390/mm/cmm.c | 6 | ||||
-rw-r--r-- | arch/sh/kernel/traps_64.c | 6 |
12 files changed, 38 insertions, 38 deletions
diff --git a/arch/arm/kernel/isa.c b/arch/arm/kernel/isa.c index 738dfcc658ca..346485910732 100644 --- a/arch/arm/kernel/isa.c +++ b/arch/arm/kernel/isa.c | |||
@@ -26,19 +26,19 @@ static ctl_table ctl_isa_vars[4] = { | |||
26 | .data = &isa_membase, | 26 | .data = &isa_membase, |
27 | .maxlen = sizeof(isa_membase), | 27 | .maxlen = sizeof(isa_membase), |
28 | .mode = 0444, | 28 | .mode = 0444, |
29 | .proc_handler = &proc_dointvec, | 29 | .proc_handler = proc_dointvec, |
30 | }, { | 30 | }, { |
31 | .procname = "portbase", | 31 | .procname = "portbase", |
32 | .data = &isa_portbase, | 32 | .data = &isa_portbase, |
33 | .maxlen = sizeof(isa_portbase), | 33 | .maxlen = sizeof(isa_portbase), |
34 | .mode = 0444, | 34 | .mode = 0444, |
35 | .proc_handler = &proc_dointvec, | 35 | .proc_handler = proc_dointvec, |
36 | }, { | 36 | }, { |
37 | .procname = "portshift", | 37 | .procname = "portshift", |
38 | .data = &isa_portshift, | 38 | .data = &isa_portshift, |
39 | .maxlen = sizeof(isa_portshift), | 39 | .maxlen = sizeof(isa_portshift), |
40 | .mode = 0444, | 40 | .mode = 0444, |
41 | .proc_handler = &proc_dointvec, | 41 | .proc_handler = proc_dointvec, |
42 | }, {} | 42 | }, {} |
43 | }; | 43 | }; |
44 | 44 | ||
diff --git a/arch/arm/mach-bcmring/arch.c b/arch/arm/mach-bcmring/arch.c index f3c11199707a..fbe6fa02c882 100644 --- a/arch/arm/mach-bcmring/arch.c +++ b/arch/arm/mach-bcmring/arch.c | |||
@@ -58,7 +58,7 @@ static struct ctl_table bcmring_sysctl_warm_reboot[] = { | |||
58 | .data = &bcmring_arch_warm_reboot, | 58 | .data = &bcmring_arch_warm_reboot, |
59 | .maxlen = sizeof(int), | 59 | .maxlen = sizeof(int), |
60 | .mode = 0644, | 60 | .mode = 0644, |
61 | .proc_handler = &proc_dointvec}, | 61 | .proc_handler = proc_dointvec}, |
62 | {} | 62 | {} |
63 | }; | 63 | }; |
64 | 64 | ||
diff --git a/arch/frv/kernel/pm.c b/arch/frv/kernel/pm.c index 940d8bb486f8..5fa3889d858b 100644 --- a/arch/frv/kernel/pm.c +++ b/arch/frv/kernel/pm.c | |||
@@ -303,28 +303,28 @@ static struct ctl_table pm_table[] = | |||
303 | .data = NULL, | 303 | .data = NULL, |
304 | .maxlen = 0, | 304 | .maxlen = 0, |
305 | .mode = 0200, | 305 | .mode = 0200, |
306 | .proc_handler = &sysctl_pm_do_suspend, | 306 | .proc_handler = sysctl_pm_do_suspend, |
307 | }, | 307 | }, |
308 | { | 308 | { |
309 | .procname = "cmode", | 309 | .procname = "cmode", |
310 | .data = &clock_cmode_current, | 310 | .data = &clock_cmode_current, |
311 | .maxlen = sizeof(int), | 311 | .maxlen = sizeof(int), |
312 | .mode = 0644, | 312 | .mode = 0644, |
313 | .proc_handler = &cmode_procctl, | 313 | .proc_handler = cmode_procctl, |
314 | }, | 314 | }, |
315 | { | 315 | { |
316 | .procname = "p0", | 316 | .procname = "p0", |
317 | .data = &clock_p0_current, | 317 | .data = &clock_p0_current, |
318 | .maxlen = sizeof(int), | 318 | .maxlen = sizeof(int), |
319 | .mode = 0644, | 319 | .mode = 0644, |
320 | .proc_handler = &p0_procctl, | 320 | .proc_handler = p0_procctl, |
321 | }, | 321 | }, |
322 | { | 322 | { |
323 | .procname = "cm", | 323 | .procname = "cm", |
324 | .data = &clock_cm_current, | 324 | .data = &clock_cm_current, |
325 | .maxlen = sizeof(int), | 325 | .maxlen = sizeof(int), |
326 | .mode = 0644, | 326 | .mode = 0644, |
327 | .proc_handler = &cm_procctl, | 327 | .proc_handler = cm_procctl, |
328 | }, | 328 | }, |
329 | { } | 329 | { } |
330 | }; | 330 | }; |
diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sysctl.c index b30a4f2cda3e..035516cb7a97 100644 --- a/arch/frv/kernel/sysctl.c +++ b/arch/frv/kernel/sysctl.c | |||
@@ -180,7 +180,7 @@ static struct ctl_table frv_table[] = | |||
180 | .data = NULL, | 180 | .data = NULL, |
181 | .maxlen = 0, | 181 | .maxlen = 0, |
182 | .mode = 0644, | 182 | .mode = 0644, |
183 | .proc_handler = &procctl_frv_cachemode, | 183 | .proc_handler = procctl_frv_cachemode, |
184 | }, | 184 | }, |
185 | #ifdef CONFIG_MMU | 185 | #ifdef CONFIG_MMU |
186 | { | 186 | { |
@@ -188,7 +188,7 @@ static struct ctl_table frv_table[] = | |||
188 | .data = NULL, | 188 | .data = NULL, |
189 | .maxlen = 0, | 189 | .maxlen = 0, |
190 | .mode = 0644, | 190 | .mode = 0644, |
191 | .proc_handler = &procctl_frv_pin_cxnr | 191 | .proc_handler = procctl_frv_pin_cxnr |
192 | }, | 192 | }, |
193 | #endif | 193 | #endif |
194 | {} | 194 | {} |
diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c index 7c7d6a6dc0f7..b942f4032d7a 100644 --- a/arch/ia64/kernel/crash.c +++ b/arch/ia64/kernel/crash.c | |||
@@ -243,14 +243,14 @@ static ctl_table kdump_ctl_table[] = { | |||
243 | .data = &kdump_on_init, | 243 | .data = &kdump_on_init, |
244 | .maxlen = sizeof(int), | 244 | .maxlen = sizeof(int), |
245 | .mode = 0644, | 245 | .mode = 0644, |
246 | .proc_handler = &proc_dointvec, | 246 | .proc_handler = proc_dointvec, |
247 | }, | 247 | }, |
248 | { | 248 | { |
249 | .procname = "kdump_on_fatal_mca", | 249 | .procname = "kdump_on_fatal_mca", |
250 | .data = &kdump_on_fatal_mca, | 250 | .data = &kdump_on_fatal_mca, |
251 | .maxlen = sizeof(int), | 251 | .maxlen = sizeof(int), |
252 | .mode = 0644, | 252 | .mode = 0644, |
253 | .proc_handler = &proc_dointvec, | 253 | .proc_handler = proc_dointvec, |
254 | }, | 254 | }, |
255 | { } | 255 | { } |
256 | }; | 256 | }; |
diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c index ca30b3646405..402698b6689f 100644 --- a/arch/ia64/kernel/perfmon.c +++ b/arch/ia64/kernel/perfmon.c | |||
@@ -526,28 +526,28 @@ static ctl_table pfm_ctl_table[]={ | |||
526 | .data = &pfm_sysctl.debug, | 526 | .data = &pfm_sysctl.debug, |
527 | .maxlen = sizeof(int), | 527 | .maxlen = sizeof(int), |
528 | .mode = 0666, | 528 | .mode = 0666, |
529 | .proc_handler = &proc_dointvec, | 529 | .proc_handler = proc_dointvec, |
530 | }, | 530 | }, |
531 | { | 531 | { |
532 | .procname = "debug_ovfl", | 532 | .procname = "debug_ovfl", |
533 | .data = &pfm_sysctl.debug_ovfl, | 533 | .data = &pfm_sysctl.debug_ovfl, |
534 | .maxlen = sizeof(int), | 534 | .maxlen = sizeof(int), |
535 | .mode = 0666, | 535 | .mode = 0666, |
536 | .proc_handler = &proc_dointvec, | 536 | .proc_handler = proc_dointvec, |
537 | }, | 537 | }, |
538 | { | 538 | { |
539 | .procname = "fastctxsw", | 539 | .procname = "fastctxsw", |
540 | .data = &pfm_sysctl.fastctxsw, | 540 | .data = &pfm_sysctl.fastctxsw, |
541 | .maxlen = sizeof(int), | 541 | .maxlen = sizeof(int), |
542 | .mode = 0600, | 542 | .mode = 0600, |
543 | .proc_handler = &proc_dointvec, | 543 | .proc_handler = proc_dointvec, |
544 | }, | 544 | }, |
545 | { | 545 | { |
546 | .procname = "expert_mode", | 546 | .procname = "expert_mode", |
547 | .data = &pfm_sysctl.expert_mode, | 547 | .data = &pfm_sysctl.expert_mode, |
548 | .maxlen = sizeof(int), | 548 | .maxlen = sizeof(int), |
549 | .mode = 0600, | 549 | .mode = 0600, |
550 | .proc_handler = &proc_dointvec, | 550 | .proc_handler = proc_dointvec, |
551 | }, | 551 | }, |
552 | {} | 552 | {} |
553 | }; | 553 | }; |
diff --git a/arch/mips/lasat/sysctl.c b/arch/mips/lasat/sysctl.c index 1dbdd76a8c04..14b9a28a4aec 100644 --- a/arch/mips/lasat/sysctl.c +++ b/arch/mips/lasat/sysctl.c | |||
@@ -182,28 +182,28 @@ static ctl_table lasat_table[] = { | |||
182 | .data = &lasat_board_info.li_cpu_hz, | 182 | .data = &lasat_board_info.li_cpu_hz, |
183 | .maxlen = sizeof(int), | 183 | .maxlen = sizeof(int), |
184 | .mode = 0444, | 184 | .mode = 0444, |
185 | .proc_handler = &proc_dointvec, | 185 | .proc_handler = proc_dointvec, |
186 | }, | 186 | }, |
187 | { | 187 | { |
188 | .procname = "bus-hz", | 188 | .procname = "bus-hz", |
189 | .data = &lasat_board_info.li_bus_hz, | 189 | .data = &lasat_board_info.li_bus_hz, |
190 | .maxlen = sizeof(int), | 190 | .maxlen = sizeof(int), |
191 | .mode = 0444, | 191 | .mode = 0444, |
192 | .proc_handler = &proc_dointvec, | 192 | .proc_handler = proc_dointvec, |
193 | }, | 193 | }, |
194 | { | 194 | { |
195 | .procname = "bmid", | 195 | .procname = "bmid", |
196 | .data = &lasat_board_info.li_bmid, | 196 | .data = &lasat_board_info.li_bmid, |
197 | .maxlen = sizeof(int), | 197 | .maxlen = sizeof(int), |
198 | .mode = 0444, | 198 | .mode = 0444, |
199 | .proc_handler = &proc_dointvec, | 199 | .proc_handler = proc_dointvec, |
200 | }, | 200 | }, |
201 | { | 201 | { |
202 | .procname = "prid", | 202 | .procname = "prid", |
203 | .data = &lasat_board_info.li_prid, | 203 | .data = &lasat_board_info.li_prid, |
204 | .maxlen = sizeof(int), | 204 | .maxlen = sizeof(int), |
205 | .mode = 0644, | 205 | .mode = 0644, |
206 | .proc_handler = &proc_lasat_prid, | 206 | .proc_handler = proc_lasat_prid, |
207 | . }, | 207 | . }, |
208 | #ifdef CONFIG_INET | 208 | #ifdef CONFIG_INET |
209 | { | 209 | { |
@@ -211,14 +211,14 @@ static ctl_table lasat_table[] = { | |||
211 | .data = &lasat_board_info.li_eeprom_info.ipaddr, | 211 | .data = &lasat_board_info.li_eeprom_info.ipaddr, |
212 | .maxlen = sizeof(int), | 212 | .maxlen = sizeof(int), |
213 | .mode = 0644, | 213 | .mode = 0644, |
214 | .proc_handler = &proc_lasat_ip, | 214 | .proc_handler = proc_lasat_ip, |
215 | }, | 215 | }, |
216 | { | 216 | { |
217 | .procname = "netmask", | 217 | .procname = "netmask", |
218 | .data = &lasat_board_info.li_eeprom_info.netmask, | 218 | .data = &lasat_board_info.li_eeprom_info.netmask, |
219 | .maxlen = sizeof(int), | 219 | .maxlen = sizeof(int), |
220 | .mode = 0644, | 220 | .mode = 0644, |
221 | .proc_handler = &proc_lasat_ip, | 221 | .proc_handler = proc_lasat_ip, |
222 | }, | 222 | }, |
223 | #endif | 223 | #endif |
224 | { | 224 | { |
@@ -227,14 +227,14 @@ static ctl_table lasat_table[] = { | |||
227 | .maxlen = | 227 | .maxlen = |
228 | sizeof(lasat_board_info.li_eeprom_info.passwd_hash), | 228 | sizeof(lasat_board_info.li_eeprom_info.passwd_hash), |
229 | .mode = 0600, | 229 | .mode = 0600, |
230 | .proc_handler = &proc_dolasatstring, | 230 | .proc_handler = proc_dolasatstring, |
231 | }, | 231 | }, |
232 | { | 232 | { |
233 | .procname = "boot-service", | 233 | .procname = "boot-service", |
234 | .data = &lasat_boot_to_service, | 234 | .data = &lasat_boot_to_service, |
235 | .maxlen = sizeof(int), | 235 | .maxlen = sizeof(int), |
236 | .mode = 0644, | 236 | .mode = 0644, |
237 | .proc_handler = &proc_dointvec, | 237 | .proc_handler = proc_dointvec, |
238 | }, | 238 | }, |
239 | #ifdef CONFIG_DS1603 | 239 | #ifdef CONFIG_DS1603 |
240 | { | 240 | { |
@@ -242,7 +242,7 @@ static ctl_table lasat_table[] = { | |||
242 | .data = &rtctmp, | 242 | .data = &rtctmp, |
243 | .maxlen = sizeof(int), | 243 | .maxlen = sizeof(int), |
244 | .mode = 0644, | 244 | .mode = 0644, |
245 | .proc_handler = &proc_dolasatrtc, | 245 | .proc_handler = proc_dolasatrtc, |
246 | }, | 246 | }, |
247 | #endif | 247 | #endif |
248 | { | 248 | { |
@@ -250,14 +250,14 @@ static ctl_table lasat_table[] = { | |||
250 | .data = &lasat_board_info.li_namestr, | 250 | .data = &lasat_board_info.li_namestr, |
251 | .maxlen = sizeof(lasat_board_info.li_namestr), | 251 | .maxlen = sizeof(lasat_board_info.li_namestr), |
252 | .mode = 0444, | 252 | .mode = 0444, |
253 | .proc_handler = &proc_dostring, | 253 | .proc_handler = proc_dostring, |
254 | }, | 254 | }, |
255 | { | 255 | { |
256 | .procname = "typestr", | 256 | .procname = "typestr", |
257 | .data = &lasat_board_info.li_typestr, | 257 | .data = &lasat_board_info.li_typestr, |
258 | .maxlen = sizeof(lasat_board_info.li_typestr), | 258 | .maxlen = sizeof(lasat_board_info.li_typestr), |
259 | .mode = 0444, | 259 | .mode = 0444, |
260 | .proc_handler = &proc_dostring, | 260 | .proc_handler = proc_dostring, |
261 | }, | 261 | }, |
262 | {} | 262 | {} |
263 | }; | 263 | }; |
diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c index cece9e2cc5e4..049dda60e475 100644 --- a/arch/powerpc/kernel/idle.c +++ b/arch/powerpc/kernel/idle.c | |||
@@ -114,7 +114,7 @@ static ctl_table powersave_nap_ctl_table[]={ | |||
114 | .data = &powersave_nap, | 114 | .data = &powersave_nap, |
115 | .maxlen = sizeof(int), | 115 | .maxlen = sizeof(int), |
116 | .mode = 0644, | 116 | .mode = 0644, |
117 | .proc_handler = &proc_dointvec, | 117 | .proc_handler = proc_dointvec, |
118 | }, | 118 | }, |
119 | {} | 119 | {} |
120 | }; | 120 | }; |
diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c index b55fd7ed1c31..495589950dc7 100644 --- a/arch/s390/appldata/appldata_base.c +++ b/arch/s390/appldata/appldata_base.c | |||
@@ -61,12 +61,12 @@ static struct ctl_table appldata_table[] = { | |||
61 | { | 61 | { |
62 | .procname = "timer", | 62 | .procname = "timer", |
63 | .mode = S_IRUGO | S_IWUSR, | 63 | .mode = S_IRUGO | S_IWUSR, |
64 | .proc_handler = &appldata_timer_handler, | 64 | .proc_handler = appldata_timer_handler, |
65 | }, | 65 | }, |
66 | { | 66 | { |
67 | .procname = "interval", | 67 | .procname = "interval", |
68 | .mode = S_IRUGO | S_IWUSR, | 68 | .mode = S_IRUGO | S_IWUSR, |
69 | .proc_handler = &appldata_interval_handler, | 69 | .proc_handler = appldata_interval_handler, |
70 | }, | 70 | }, |
71 | { }, | 71 | { }, |
72 | }; | 72 | }; |
diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index adf11260260a..071c81f179ef 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c | |||
@@ -897,14 +897,14 @@ static struct ctl_table s390dbf_table[] = { | |||
897 | .data = &debug_stoppable, | 897 | .data = &debug_stoppable, |
898 | .maxlen = sizeof(int), | 898 | .maxlen = sizeof(int), |
899 | .mode = S_IRUGO | S_IWUSR, | 899 | .mode = S_IRUGO | S_IWUSR, |
900 | .proc_handler = &proc_dointvec, | 900 | .proc_handler = proc_dointvec, |
901 | }, | 901 | }, |
902 | { | 902 | { |
903 | .procname = "debug_active", | 903 | .procname = "debug_active", |
904 | .data = &debug_active, | 904 | .data = &debug_active, |
905 | .maxlen = sizeof(int), | 905 | .maxlen = sizeof(int), |
906 | .mode = S_IRUGO | S_IWUSR, | 906 | .mode = S_IRUGO | S_IWUSR, |
907 | .proc_handler = &s390dbf_procactive, | 907 | .proc_handler = s390dbf_procactive, |
908 | }, | 908 | }, |
909 | { } | 909 | { } |
910 | }; | 910 | }; |
diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index dab3e4a7582e..ff58779bf7e9 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c | |||
@@ -343,17 +343,17 @@ static struct ctl_table cmm_table[] = { | |||
343 | { | 343 | { |
344 | .procname = "cmm_pages", | 344 | .procname = "cmm_pages", |
345 | .mode = 0644, | 345 | .mode = 0644, |
346 | .proc_handler = &cmm_pages_handler, | 346 | .proc_handler = cmm_pages_handler, |
347 | }, | 347 | }, |
348 | { | 348 | { |
349 | .procname = "cmm_timed_pages", | 349 | .procname = "cmm_timed_pages", |
350 | .mode = 0644, | 350 | .mode = 0644, |
351 | .proc_handler = &cmm_pages_handler, | 351 | .proc_handler = cmm_pages_handler, |
352 | }, | 352 | }, |
353 | { | 353 | { |
354 | .procname = "cmm_timeout", | 354 | .procname = "cmm_timeout", |
355 | .mode = 0644, | 355 | .mode = 0644, |
356 | .proc_handler = &cmm_timeout_handler, | 356 | .proc_handler = cmm_timeout_handler, |
357 | }, | 357 | }, |
358 | { } | 358 | { } |
359 | }; | 359 | }; |
diff --git a/arch/sh/kernel/traps_64.c b/arch/sh/kernel/traps_64.c index 080c8ee2d862..75c0cbe2eda0 100644 --- a/arch/sh/kernel/traps_64.c +++ b/arch/sh/kernel/traps_64.c | |||
@@ -881,21 +881,21 @@ static ctl_table unaligned_table[] = { | |||
881 | .data = &kernel_mode_unaligned_fixup_count, | 881 | .data = &kernel_mode_unaligned_fixup_count, |
882 | .maxlen = sizeof(int), | 882 | .maxlen = sizeof(int), |
883 | .mode = 0644, | 883 | .mode = 0644, |
884 | .proc_handler = &proc_dointvec | 884 | .proc_handler = proc_dointvec |
885 | }, | 885 | }, |
886 | { | 886 | { |
887 | .procname = "user_reports", | 887 | .procname = "user_reports", |
888 | .data = &user_mode_unaligned_fixup_count, | 888 | .data = &user_mode_unaligned_fixup_count, |
889 | .maxlen = sizeof(int), | 889 | .maxlen = sizeof(int), |
890 | .mode = 0644, | 890 | .mode = 0644, |
891 | .proc_handler = &proc_dointvec | 891 | .proc_handler = proc_dointvec |
892 | }, | 892 | }, |
893 | { | 893 | { |
894 | .procname = "user_enable", | 894 | .procname = "user_enable", |
895 | .data = &user_mode_unaligned_fixup_enable, | 895 | .data = &user_mode_unaligned_fixup_enable, |
896 | .maxlen = sizeof(int), | 896 | .maxlen = sizeof(int), |
897 | .mode = 0644, | 897 | .mode = 0644, |
898 | .proc_handler = &proc_dointvec}, | 898 | .proc_handler = proc_dointvec}, |
899 | {} | 899 | {} |
900 | }; | 900 | }; |
901 | 901 | ||