diff options
author | Paul Walmsley <paul@pwsan.com> | 2012-09-23 19:28:18 -0400 |
---|---|---|
committer | Paul Walmsley <paul@pwsan.com> | 2012-09-23 19:28:18 -0400 |
commit | 3bb05dbf69018177c06ee09011e2d8bd183dd2ba (patch) | |
tree | 301199700198534b01c45159bbdc9ebe54122773 /arch | |
parent | 2b026d137b13047d01d426a61e2d50b5dcb58fd0 (diff) |
ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages
The decision was made a few months ago to allow struct omap_hwmod
records and struct clk records to omit clockdomain information if the
clockdomain is not software-controllable. See for example commit
868c157df9721675c19729eed2c96bac6c3f1d01 ("ARM: OMAP2+: hwmod: remove
prm_clkdm, cm_clkdm; allow hwmods to have no clockdomain").
So convert an existing pr_warning() to a pr_debug() (regarding missing
clockdomains in clocks), and add a pr_debug() for missing hwmod
clockdomains. It's still useful to enable these messages for
debugging, since missing clockdomains can cause hard-to-debug problems
with power management; see for example commit
6c4a057bffe9823221eab547e11fac181dc18a2b ("ARM: OMAP4: clock data:
Force a DPLL clkdm/pwrdm ON before a relock").
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: BenoƮt Cousson <b-cousson@ti.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/arm/mach-omap2/omap_hwmod.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 18a2df38265d..4f6b50f220c5 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c | |||
@@ -696,7 +696,7 @@ static int _init_main_clk(struct omap_hwmod *oh) | |||
696 | clk_prepare(oh->_clk); | 696 | clk_prepare(oh->_clk); |
697 | 697 | ||
698 | if (!oh->_clk->clkdm) | 698 | if (!oh->_clk->clkdm) |
699 | pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n", | 699 | pr_debug("omap_hwmod: %s: missing clockdomain for %s.\n", |
700 | oh->name, oh->main_clk); | 700 | oh->name, oh->main_clk); |
701 | 701 | ||
702 | return ret; | 702 | return ret; |
@@ -1454,8 +1454,10 @@ static struct omap_hwmod *_lookup(const char *name) | |||
1454 | */ | 1454 | */ |
1455 | static int _init_clkdm(struct omap_hwmod *oh) | 1455 | static int _init_clkdm(struct omap_hwmod *oh) |
1456 | { | 1456 | { |
1457 | if (!oh->clkdm_name) | 1457 | if (!oh->clkdm_name) { |
1458 | pr_debug("omap_hwmod: %s: missing clockdomain\n", oh->name); | ||
1458 | return 0; | 1459 | return 0; |
1460 | } | ||
1459 | 1461 | ||
1460 | oh->clkdm = clkdm_lookup(oh->clkdm_name); | 1462 | oh->clkdm = clkdm_lookup(oh->clkdm_name); |
1461 | if (!oh->clkdm) { | 1463 | if (!oh->clkdm) { |