diff options
author | Olof Johansson <olof@lixom.net> | 2013-12-05 12:29:35 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2013-12-29 07:32:37 -0500 |
commit | 1b0f6681fcbc0e6365f42ef11beb882c9f73c945 (patch) | |
tree | 7b9267839797426be6f2bf324f1a2ecaa184cfe3 /arch | |
parent | 23c34527a45885cd8f9dd58294de3cbaa32b10be (diff) |
ARM: 7911/2: Clean up setup printks a bit
Clean up the setup ARM printks a bit. Add printk level to a few
that were missing (CPU: <...> ones, in particular), and switch from
printk(KERN_* ..) to pr_*().
Finally, un-wrap some long lines since it makes it harder to grep the
sources from where an error came from and tweak some cases of indentation.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/arm/kernel/setup.c | 41 |
1 files changed, 20 insertions, 21 deletions
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 987a7f5bce5f..7a2dd4689a75 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c | |||
@@ -334,7 +334,7 @@ static void __init cacheid_init(void) | |||
334 | cacheid = CACHEID_VIVT; | 334 | cacheid = CACHEID_VIVT; |
335 | } | 335 | } |
336 | 336 | ||
337 | printk("CPU: %s data cache, %s instruction cache\n", | 337 | pr_info("CPU: %s data cache, %s instruction cache\n", |
338 | cache_is_vivt() ? "VIVT" : | 338 | cache_is_vivt() ? "VIVT" : |
339 | cache_is_vipt_aliasing() ? "VIPT aliasing" : | 339 | cache_is_vipt_aliasing() ? "VIPT aliasing" : |
340 | cache_is_vipt_nonaliasing() ? "PIPT / VIPT nonaliasing" : "unknown", | 340 | cache_is_vipt_nonaliasing() ? "PIPT / VIPT nonaliasing" : "unknown", |
@@ -416,7 +416,7 @@ void notrace cpu_init(void) | |||
416 | struct stack *stk = &stacks[cpu]; | 416 | struct stack *stk = &stacks[cpu]; |
417 | 417 | ||
418 | if (cpu >= NR_CPUS) { | 418 | if (cpu >= NR_CPUS) { |
419 | printk(KERN_CRIT "CPU%u: bad primary CPU number\n", cpu); | 419 | pr_crit("CPU%u: bad primary CPU number\n", cpu); |
420 | BUG(); | 420 | BUG(); |
421 | } | 421 | } |
422 | 422 | ||
@@ -484,7 +484,7 @@ void __init smp_setup_processor_id(void) | |||
484 | */ | 484 | */ |
485 | set_my_cpu_offset(0); | 485 | set_my_cpu_offset(0); |
486 | 486 | ||
487 | printk(KERN_INFO "Booting Linux on physical CPU 0x%x\n", mpidr); | 487 | pr_info("Booting Linux on physical CPU 0x%x\n", mpidr); |
488 | } | 488 | } |
489 | 489 | ||
490 | struct mpidr_hash mpidr_hash; | 490 | struct mpidr_hash mpidr_hash; |
@@ -564,8 +564,8 @@ static void __init setup_processor(void) | |||
564 | */ | 564 | */ |
565 | list = lookup_processor_type(read_cpuid_id()); | 565 | list = lookup_processor_type(read_cpuid_id()); |
566 | if (!list) { | 566 | if (!list) { |
567 | printk("CPU configuration botched (ID %08x), unable " | 567 | pr_err("CPU configuration botched (ID %08x), unable to continue.\n", |
568 | "to continue.\n", read_cpuid_id()); | 568 | read_cpuid_id()); |
569 | while (1); | 569 | while (1); |
570 | } | 570 | } |
571 | 571 | ||
@@ -585,9 +585,9 @@ static void __init setup_processor(void) | |||
585 | cpu_cache = *list->cache; | 585 | cpu_cache = *list->cache; |
586 | #endif | 586 | #endif |
587 | 587 | ||
588 | printk("CPU: %s [%08x] revision %d (ARMv%s), cr=%08lx\n", | 588 | pr_info("CPU: %s [%08x] revision %d (ARMv%s), cr=%08lx\n", |
589 | cpu_name, read_cpuid_id(), read_cpuid_id() & 15, | 589 | cpu_name, read_cpuid_id(), read_cpuid_id() & 15, |
590 | proc_arch[cpu_architecture()], cr_alignment); | 590 | proc_arch[cpu_architecture()], cr_alignment); |
591 | 591 | ||
592 | snprintf(init_utsname()->machine, __NEW_UTS_LEN + 1, "%s%c", | 592 | snprintf(init_utsname()->machine, __NEW_UTS_LEN + 1, "%s%c", |
593 | list->arch_name, ENDIANNESS); | 593 | list->arch_name, ENDIANNESS); |
@@ -629,8 +629,8 @@ int __init arm_add_memory(u64 start, u64 size) | |||
629 | u64 aligned_start; | 629 | u64 aligned_start; |
630 | 630 | ||
631 | if (meminfo.nr_banks >= NR_BANKS) { | 631 | if (meminfo.nr_banks >= NR_BANKS) { |
632 | printk(KERN_CRIT "NR_BANKS too low, " | 632 | pr_crit("NR_BANKS too low, ignoring memory at 0x%08llx\n", |
633 | "ignoring memory at 0x%08llx\n", (long long)start); | 633 | (long long)start); |
634 | return -EINVAL; | 634 | return -EINVAL; |
635 | } | 635 | } |
636 | 636 | ||
@@ -643,14 +643,14 @@ int __init arm_add_memory(u64 start, u64 size) | |||
643 | 643 | ||
644 | #ifndef CONFIG_ARCH_PHYS_ADDR_T_64BIT | 644 | #ifndef CONFIG_ARCH_PHYS_ADDR_T_64BIT |
645 | if (aligned_start > ULONG_MAX) { | 645 | if (aligned_start > ULONG_MAX) { |
646 | printk(KERN_CRIT "Ignoring memory at 0x%08llx outside " | 646 | pr_crit("Ignoring memory at 0x%08llx outside 32-bit physical address space\n", |
647 | "32-bit physical address space\n", (long long)start); | 647 | (long long)start); |
648 | return -EINVAL; | 648 | return -EINVAL; |
649 | } | 649 | } |
650 | 650 | ||
651 | if (aligned_start + size > ULONG_MAX) { | 651 | if (aligned_start + size > ULONG_MAX) { |
652 | printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in " | 652 | pr_crit("Truncating memory at 0x%08llx to fit in 32-bit physical address space\n", |
653 | "32-bit physical address space\n", (long long)start); | 653 | (long long)start); |
654 | /* | 654 | /* |
655 | * To ensure bank->start + bank->size is representable in | 655 | * To ensure bank->start + bank->size is representable in |
656 | * 32 bits, we use ULONG_MAX as the upper limit rather than 4GB. | 656 | * 32 bits, we use ULONG_MAX as the upper limit rather than 4GB. |
@@ -819,16 +819,15 @@ static void __init reserve_crashkernel(void) | |||
819 | 819 | ||
820 | ret = reserve_bootmem(crash_base, crash_size, BOOTMEM_EXCLUSIVE); | 820 | ret = reserve_bootmem(crash_base, crash_size, BOOTMEM_EXCLUSIVE); |
821 | if (ret < 0) { | 821 | if (ret < 0) { |
822 | printk(KERN_WARNING "crashkernel reservation failed - " | 822 | pr_warn("crashkernel reservation failed - memory is in use (0x%lx)\n", |
823 | "memory is in use (0x%lx)\n", (unsigned long)crash_base); | 823 | (unsigned long)crash_base); |
824 | return; | 824 | return; |
825 | } | 825 | } |
826 | 826 | ||
827 | printk(KERN_INFO "Reserving %ldMB of memory at %ldMB " | 827 | pr_info("Reserving %ldMB of memory at %ldMB for crashkernel (System RAM: %ldMB)\n", |
828 | "for crashkernel (System RAM: %ldMB)\n", | 828 | (unsigned long)(crash_size >> 20), |
829 | (unsigned long)(crash_size >> 20), | 829 | (unsigned long)(crash_base >> 20), |
830 | (unsigned long)(crash_base >> 20), | 830 | (unsigned long)(total_mem >> 20)); |
831 | (unsigned long)(total_mem >> 20)); | ||
832 | 831 | ||
833 | crashk_res.start = crash_base; | 832 | crashk_res.start = crash_base; |
834 | crashk_res.end = crash_base + crash_size - 1; | 833 | crashk_res.end = crash_base + crash_size - 1; |