diff options
author | Tejun Heo <htejun@gmail.com> | 2007-06-13 14:45:17 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-11 19:09:06 -0400 |
commit | 7b595756ec1f49e0049a9e01a1298d53a7faaa15 (patch) | |
tree | cd06687ab3e5c7a5a4ef91903dff207a18c4db76 /arch | |
parent | dbde0fcf9f8f6d477af3c32d9979e789ee680cde (diff) |
sysfs: kill unnecessary attribute->owner
sysfs is now completely out of driver/module lifetime game. After
deletion, a sysfs node doesn't access anything outside sysfs proper,
so there's no reason to hold onto the attribute owners. Note that
often the wrong modules were accounted for as owners leading to
accessing removed modules.
This patch kills now unnecessary attribute->owner. Note that with
this change, userland holding a sysfs node does not prevent the
backing module from being unloaded.
For more info regarding lifetime rule cleanup, please read the
following message.
http://article.gmane.org/gmane.linux.kernel/510293
(tweaked by Greg to not delete the field just yet, to make it easier to
merge things properly.)
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/ppc/syslib/mv64x60.c | 1 | ||||
-rw-r--r-- | arch/s390/kernel/ipl.c | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/arch/ppc/syslib/mv64x60.c b/arch/ppc/syslib/mv64x60.c index 8485a68cd475..032f4b7f4225 100644 --- a/arch/ppc/syslib/mv64x60.c +++ b/arch/ppc/syslib/mv64x60.c | |||
@@ -2415,7 +2415,6 @@ static struct bin_attribute mv64xxx_hs_reg_attr = { /* Hotswap register */ | |||
2415 | .attr = { | 2415 | .attr = { |
2416 | .name = "hs_reg", | 2416 | .name = "hs_reg", |
2417 | .mode = S_IRUGO | S_IWUSR, | 2417 | .mode = S_IRUGO | S_IWUSR, |
2418 | .owner = THIS_MODULE, | ||
2419 | }, | 2418 | }, |
2420 | .size = VAL_LEN_MAX, | 2419 | .size = VAL_LEN_MAX, |
2421 | .read = mv64xxx_hs_reg_read, | 2420 | .read = mv64xxx_hs_reg_read, |
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c index 82b131ddd7ff..9a13b24ee1ab 100644 --- a/arch/s390/kernel/ipl.c +++ b/arch/s390/kernel/ipl.c | |||
@@ -312,7 +312,6 @@ static struct bin_attribute ipl_parameter_attr = { | |||
312 | .attr = { | 312 | .attr = { |
313 | .name = "binary_parameter", | 313 | .name = "binary_parameter", |
314 | .mode = S_IRUGO, | 314 | .mode = S_IRUGO, |
315 | .owner = THIS_MODULE, | ||
316 | }, | 315 | }, |
317 | .size = PAGE_SIZE, | 316 | .size = PAGE_SIZE, |
318 | .read = &ipl_parameter_read, | 317 | .read = &ipl_parameter_read, |
@@ -336,7 +335,6 @@ static struct bin_attribute ipl_scp_data_attr = { | |||
336 | .attr = { | 335 | .attr = { |
337 | .name = "scp_data", | 336 | .name = "scp_data", |
338 | .mode = S_IRUGO, | 337 | .mode = S_IRUGO, |
339 | .owner = THIS_MODULE, | ||
340 | }, | 338 | }, |
341 | .size = PAGE_SIZE, | 339 | .size = PAGE_SIZE, |
342 | .read = &ipl_scp_data_read, | 340 | .read = &ipl_scp_data_read, |