diff options
author | Yasunori Goto <y-goto@jp.fujitsu.com> | 2006-06-27 05:53:39 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-27 20:32:37 -0400 |
commit | 7049027c6f0098eb6b23b8f6ca65a905541faf81 (patch) | |
tree | ab5528625be6e79c02767c6d9444599c1980cf0e /arch | |
parent | ae5a2c1c9b2bc3633032f97d02e60ae547a6047c (diff) |
[PATCH] pgdat allocation and update for ia64 of memory hotplug: update pgdat address array
This is to refresh node_data[] array for ia64. As I mentioned previous
patches, ia64 has copies of information of pgdat address array on each node as
per node data.
At v2 of node_add, this function used stop_machine_run() to update them. (I
wished that they were copied safety as much as possible.) But, in this patch,
this arrays are just copied simply, and set node_online_map bit after
completion of pgdat initialization.
So, kernel must touch NODE_DATA() macro after checking node_online_map().
(Current code has already done it.) This is more simple way for just
hot-add.....
Note : It will be problem when hot-remove will occur,
because, even if online_map bit is set, kernel may
touch NODE_DATA() due to race condition. :-(
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/ia64/mm/discontig.c | 24 |
1 files changed, 19 insertions, 5 deletions
diff --git a/arch/ia64/mm/discontig.c b/arch/ia64/mm/discontig.c index 83153ac18795..9153465d7fcc 100644 --- a/arch/ia64/mm/discontig.c +++ b/arch/ia64/mm/discontig.c | |||
@@ -308,6 +308,17 @@ static void __init reserve_pernode_space(void) | |||
308 | } | 308 | } |
309 | } | 309 | } |
310 | 310 | ||
311 | static void __meminit scatter_node_data(void) | ||
312 | { | ||
313 | pg_data_t **dst; | ||
314 | int node; | ||
315 | |||
316 | for_each_online_node(node) { | ||
317 | dst = LOCAL_DATA_ADDR(pgdat_list[node])->pg_data_ptrs; | ||
318 | memcpy(dst, pgdat_list, sizeof(pgdat_list)); | ||
319 | } | ||
320 | } | ||
321 | |||
311 | /** | 322 | /** |
312 | * initialize_pernode_data - fixup per-cpu & per-node pointers | 323 | * initialize_pernode_data - fixup per-cpu & per-node pointers |
313 | * | 324 | * |
@@ -320,11 +331,8 @@ static void __init initialize_pernode_data(void) | |||
320 | { | 331 | { |
321 | int cpu, node; | 332 | int cpu, node; |
322 | 333 | ||
323 | /* Copy the pg_data_t list to each node and init the node field */ | 334 | scatter_node_data(); |
324 | for_each_online_node(node) { | 335 | |
325 | memcpy(mem_data[node].node_data->pg_data_ptrs, pgdat_list, | ||
326 | sizeof(pgdat_list)); | ||
327 | } | ||
328 | #ifdef CONFIG_SMP | 336 | #ifdef CONFIG_SMP |
329 | /* Set the node_data pointer for each per-cpu struct */ | 337 | /* Set the node_data pointer for each per-cpu struct */ |
330 | for (cpu = 0; cpu < NR_CPUS; cpu++) { | 338 | for (cpu = 0; cpu < NR_CPUS; cpu++) { |
@@ -783,3 +791,9 @@ void __init paging_init(void) | |||
783 | 791 | ||
784 | zero_page_memmap_ptr = virt_to_page(ia64_imva(empty_zero_page)); | 792 | zero_page_memmap_ptr = virt_to_page(ia64_imva(empty_zero_page)); |
785 | } | 793 | } |
794 | |||
795 | void arch_refresh_nodedata(int update_node, pg_data_t *update_pgdat) | ||
796 | { | ||
797 | pgdat_list[update_node] = update_pgdat; | ||
798 | scatter_node_data(); | ||
799 | } | ||