diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2005-09-06 18:17:26 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-07 19:57:29 -0400 |
commit | 96d0821cacd095e25a39dfff5232a45b63ed18dd (patch) | |
tree | 76a7f44e4bbc17cbe4a989468add7ffb5c5d6de0 /arch | |
parent | f26fdd59929e1144c6caf72adcaf4561d6e682a4 (diff) |
[PATCH] Fix function/macro name collision on i386 oprofile
The i386 OProfile code has a function named nmi_exit(), which collides with
the nmi_exit() macro in linux/hardirq.h. At the moment, we get away with
it, because hardirq.h isn't included in the oprofile code. I hit this as a
bug when working with a patch which (indirectly) adds a #include of
hardirq.h to oprofile.
Regardless, the name collision is probably not a good idea, so this patch
fixes it, renaming the oprofile function to op_nmi_exit(). It also renames
the nmi_init() and nmi_timer_init() functions similarly, for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/i386/oprofile/init.c | 12 | ||||
-rw-r--r-- | arch/i386/oprofile/nmi_int.c | 4 | ||||
-rw-r--r-- | arch/i386/oprofile/nmi_timer_int.c | 2 |
3 files changed, 9 insertions, 9 deletions
diff --git a/arch/i386/oprofile/init.c b/arch/i386/oprofile/init.c index c90332de582b..5341d481d92f 100644 --- a/arch/i386/oprofile/init.c +++ b/arch/i386/oprofile/init.c | |||
@@ -15,9 +15,9 @@ | |||
15 | * with the NMI mode driver. | 15 | * with the NMI mode driver. |
16 | */ | 16 | */ |
17 | 17 | ||
18 | extern int nmi_init(struct oprofile_operations * ops); | 18 | extern int op_nmi_init(struct oprofile_operations * ops); |
19 | extern int nmi_timer_init(struct oprofile_operations * ops); | 19 | extern int op_nmi_timer_init(struct oprofile_operations * ops); |
20 | extern void nmi_exit(void); | 20 | extern void op_nmi_exit(void); |
21 | extern void x86_backtrace(struct pt_regs * const regs, unsigned int depth); | 21 | extern void x86_backtrace(struct pt_regs * const regs, unsigned int depth); |
22 | 22 | ||
23 | 23 | ||
@@ -28,11 +28,11 @@ int __init oprofile_arch_init(struct oprofile_operations * ops) | |||
28 | ret = -ENODEV; | 28 | ret = -ENODEV; |
29 | 29 | ||
30 | #ifdef CONFIG_X86_LOCAL_APIC | 30 | #ifdef CONFIG_X86_LOCAL_APIC |
31 | ret = nmi_init(ops); | 31 | ret = op_nmi_init(ops); |
32 | #endif | 32 | #endif |
33 | #ifdef CONFIG_X86_IO_APIC | 33 | #ifdef CONFIG_X86_IO_APIC |
34 | if (ret < 0) | 34 | if (ret < 0) |
35 | ret = nmi_timer_init(ops); | 35 | ret = op_nmi_timer_init(ops); |
36 | #endif | 36 | #endif |
37 | ops->backtrace = x86_backtrace; | 37 | ops->backtrace = x86_backtrace; |
38 | 38 | ||
@@ -43,6 +43,6 @@ int __init oprofile_arch_init(struct oprofile_operations * ops) | |||
43 | void oprofile_arch_exit(void) | 43 | void oprofile_arch_exit(void) |
44 | { | 44 | { |
45 | #ifdef CONFIG_X86_LOCAL_APIC | 45 | #ifdef CONFIG_X86_LOCAL_APIC |
46 | nmi_exit(); | 46 | op_nmi_exit(); |
47 | #endif | 47 | #endif |
48 | } | 48 | } |
diff --git a/arch/i386/oprofile/nmi_int.c b/arch/i386/oprofile/nmi_int.c index 255e4702d185..0493e8b8ec49 100644 --- a/arch/i386/oprofile/nmi_int.c +++ b/arch/i386/oprofile/nmi_int.c | |||
@@ -355,7 +355,7 @@ static int __init ppro_init(char ** cpu_type) | |||
355 | /* in order to get driverfs right */ | 355 | /* in order to get driverfs right */ |
356 | static int using_nmi; | 356 | static int using_nmi; |
357 | 357 | ||
358 | int __init nmi_init(struct oprofile_operations *ops) | 358 | int __init op_nmi_init(struct oprofile_operations *ops) |
359 | { | 359 | { |
360 | __u8 vendor = boot_cpu_data.x86_vendor; | 360 | __u8 vendor = boot_cpu_data.x86_vendor; |
361 | __u8 family = boot_cpu_data.x86; | 361 | __u8 family = boot_cpu_data.x86; |
@@ -420,7 +420,7 @@ int __init nmi_init(struct oprofile_operations *ops) | |||
420 | } | 420 | } |
421 | 421 | ||
422 | 422 | ||
423 | void nmi_exit(void) | 423 | void op_nmi_exit(void) |
424 | { | 424 | { |
425 | if (using_nmi) | 425 | if (using_nmi) |
426 | exit_driverfs(); | 426 | exit_driverfs(); |
diff --git a/arch/i386/oprofile/nmi_timer_int.c b/arch/i386/oprofile/nmi_timer_int.c index c58d0c14f274..ad93cdd55d63 100644 --- a/arch/i386/oprofile/nmi_timer_int.c +++ b/arch/i386/oprofile/nmi_timer_int.c | |||
@@ -40,7 +40,7 @@ static void timer_stop(void) | |||
40 | } | 40 | } |
41 | 41 | ||
42 | 42 | ||
43 | int __init nmi_timer_init(struct oprofile_operations * ops) | 43 | int __init op_nmi_timer_init(struct oprofile_operations * ops) |
44 | { | 44 | { |
45 | extern int nmi_active; | 45 | extern int nmi_active; |
46 | 46 | ||