diff options
author | Santosh Shilimkar <santosh.shilimkar@ti.com> | 2009-10-22 17:46:31 -0400 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2009-10-22 17:46:31 -0400 |
commit | 9da65a99e5e6a074c586474961dbf560e439df50 (patch) | |
tree | 26d32357113778bc7628405981db17f27954c9c4 /arch | |
parent | 6135434a54719c45fdc6add1ba4965dea89ab069 (diff) |
omap: SDMA: Fix omap_stop_dma() API for channel linking
OMAP sDMA driver API omap_stop_dma() doesn't really stop the dma when used
in linking scenario.
The DMA channel needs to be disabled before resetting the chain.
Also fix clearing of the OMAP_DMA_ACTIVE status in the linked case.
Cc: Hari n <hari.zoom@gmail.com>
Cc: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Venkatraman S <svenkatr@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/arm/plat-omap/dma.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 0eb676d7e807..b53125f41293 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c | |||
@@ -978,6 +978,14 @@ void omap_stop_dma(int lch) | |||
978 | { | 978 | { |
979 | u32 l; | 979 | u32 l; |
980 | 980 | ||
981 | /* Disable all interrupts on the channel */ | ||
982 | if (cpu_class_is_omap1()) | ||
983 | dma_write(0, CICR(lch)); | ||
984 | |||
985 | l = dma_read(CCR(lch)); | ||
986 | l &= ~OMAP_DMA_CCR_EN; | ||
987 | dma_write(l, CCR(lch)); | ||
988 | |||
981 | if (!omap_dma_in_1510_mode() && dma_chan[lch].next_lch != -1) { | 989 | if (!omap_dma_in_1510_mode() && dma_chan[lch].next_lch != -1) { |
982 | int next_lch, cur_lch = lch; | 990 | int next_lch, cur_lch = lch; |
983 | char dma_chan_link_map[OMAP_DMA4_LOGICAL_DMA_CH_COUNT]; | 991 | char dma_chan_link_map[OMAP_DMA4_LOGICAL_DMA_CH_COUNT]; |
@@ -995,18 +1003,8 @@ void omap_stop_dma(int lch) | |||
995 | next_lch = dma_chan[cur_lch].next_lch; | 1003 | next_lch = dma_chan[cur_lch].next_lch; |
996 | cur_lch = next_lch; | 1004 | cur_lch = next_lch; |
997 | } while (next_lch != -1); | 1005 | } while (next_lch != -1); |
998 | |||
999 | return; | ||
1000 | } | 1006 | } |
1001 | 1007 | ||
1002 | /* Disable all interrupts on the channel */ | ||
1003 | if (cpu_class_is_omap1()) | ||
1004 | dma_write(0, CICR(lch)); | ||
1005 | |||
1006 | l = dma_read(CCR(lch)); | ||
1007 | l &= ~OMAP_DMA_CCR_EN; | ||
1008 | dma_write(l, CCR(lch)); | ||
1009 | |||
1010 | dma_chan[lch].flags &= ~OMAP_DMA_ACTIVE; | 1008 | dma_chan[lch].flags &= ~OMAP_DMA_ACTIVE; |
1011 | } | 1009 | } |
1012 | EXPORT_SYMBOL(omap_stop_dma); | 1010 | EXPORT_SYMBOL(omap_stop_dma); |