diff options
author | David Rientjes <rientjes@google.com> | 2008-10-07 17:15:11 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-10-12 05:18:59 -0400 |
commit | e1e23bb0513520035ec934fa3483507cb6648b7c (patch) | |
tree | a05f96cf556599a3a0dbc0de852c57921ae6051f /arch | |
parent | fd048088306656824958e7783ffcee27e241b361 (diff) |
x86: avoid dereferencing beyond stack + THREAD_SIZE
It's possible for get_wchan() to dereference past task->stack + THREAD_SIZE
while iterating through instruction pointers if fp equals the upper boundary,
causing a kernel panic.
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/process_64.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 2a8ccb9238b4..b6b508ea7110 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c | |||
@@ -754,12 +754,12 @@ unsigned long get_wchan(struct task_struct *p) | |||
754 | if (!p || p == current || p->state == TASK_RUNNING) | 754 | if (!p || p == current || p->state == TASK_RUNNING) |
755 | return 0; | 755 | return 0; |
756 | stack = (unsigned long)task_stack_page(p); | 756 | stack = (unsigned long)task_stack_page(p); |
757 | if (p->thread.sp < stack || p->thread.sp > stack+THREAD_SIZE) | 757 | if (p->thread.sp < stack || p->thread.sp >= stack+THREAD_SIZE) |
758 | return 0; | 758 | return 0; |
759 | fp = *(u64 *)(p->thread.sp); | 759 | fp = *(u64 *)(p->thread.sp); |
760 | do { | 760 | do { |
761 | if (fp < (unsigned long)stack || | 761 | if (fp < (unsigned long)stack || |
762 | fp > (unsigned long)stack+THREAD_SIZE) | 762 | fp >= (unsigned long)stack+THREAD_SIZE) |
763 | return 0; | 763 | return 0; |
764 | ip = *(u64 *)(fp+8); | 764 | ip = *(u64 *)(fp+8); |
765 | if (!in_sched_functions(ip)) | 765 | if (!in_sched_functions(ip)) |