diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2008-06-25 00:19:25 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-08 07:11:12 -0400 |
commit | e04e0a630d8b5c621b3a8e70ff20db737d3a5728 (patch) | |
tree | 77ba90fcd186fa4fe5f8a8f488961301b13c20b7 /arch | |
parent | 478de5a9d691dd0c048ddce62dbec23722515636 (diff) |
x86: use __KERNEL_DS as SS when returning to a kernel thread
This is needed when the kernel is running on RING3, such as under Xen.
x86_64 has a weird feature that makes it #GP on iret when SS is a null
descriptor.
This need to be tested on bare metal to make sure it doesn't cause any
problems. AMD specs say SS is always ignored (except on iret?).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Cc: Stephen Tweedie <sct@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/entry_64.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index ff15ab552280..6d1101469e97 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86/kernel/entry_64.S | |||
@@ -104,7 +104,7 @@ ENTRY(native_irq_enable_syscall_ret) | |||
104 | .macro FAKE_STACK_FRAME child_rip | 104 | .macro FAKE_STACK_FRAME child_rip |
105 | /* push in order ss, rsp, eflags, cs, rip */ | 105 | /* push in order ss, rsp, eflags, cs, rip */ |
106 | xorl %eax, %eax | 106 | xorl %eax, %eax |
107 | pushq %rax /* ss */ | 107 | pushq $__KERNEL_DS /* ss */ |
108 | CFI_ADJUST_CFA_OFFSET 8 | 108 | CFI_ADJUST_CFA_OFFSET 8 |
109 | /*CFI_REL_OFFSET ss,0*/ | 109 | /*CFI_REL_OFFSET ss,0*/ |
110 | pushq %rax /* rsp */ | 110 | pushq %rax /* rsp */ |