diff options
author | Alexander Duyck <alexander.h.duyck@intel.com> | 2012-11-16 16:55:46 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2012-11-16 19:42:09 -0500 |
commit | 7d74275d39def4d3ccc8cf4725388bf79ef13861 (patch) | |
tree | afe6ed01aad5df44f82aa576151eeabd2e9b66b6 /arch | |
parent | 0bdf525f04afd3a32c14e5a8778771f9c9e0f074 (diff) |
x86: Make it so that __pa_symbol can only process kernel symbols on x86_64
I submitted an earlier patch that make __phys_addr an inline. This obviously
results in an increase in the code size. One step I can take to reduce that
is to make it so that the __pa_symbol call does a direct translation for
kernel addresses instead of covering all of virtual memory.
On my system this reduced the size for __pa_symbol from 5 instructions
totalling 30 bytes to 3 instructions totalling 16 bytes.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Link: http://lkml.kernel.org/r/20121116215356.8521.92472.stgit@ahduyck-cp1.jf.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/include/asm/page.h | 3 | ||||
-rw-r--r-- | arch/x86/include/asm/page_32.h | 1 | ||||
-rw-r--r-- | arch/x86/include/asm/page_64.h | 3 | ||||
-rw-r--r-- | arch/x86/mm/physaddr.c | 11 |
4 files changed, 17 insertions, 1 deletions
diff --git a/arch/x86/include/asm/page.h b/arch/x86/include/asm/page.h index 8ca82839288a..3698a6a0a940 100644 --- a/arch/x86/include/asm/page.h +++ b/arch/x86/include/asm/page.h | |||
@@ -44,7 +44,8 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr, | |||
44 | * case properly. Once all supported versions of gcc understand it, we can | 44 | * case properly. Once all supported versions of gcc understand it, we can |
45 | * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated) | 45 | * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated) |
46 | */ | 46 | */ |
47 | #define __pa_symbol(x) __pa(__phys_reloc_hide((unsigned long)(x))) | 47 | #define __pa_symbol(x) \ |
48 | __phys_addr_symbol(__phys_reloc_hide((unsigned long)(x))) | ||
48 | 49 | ||
49 | #define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET)) | 50 | #define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET)) |
50 | 51 | ||
diff --git a/arch/x86/include/asm/page_32.h b/arch/x86/include/asm/page_32.h index da4e762406f7..4d550d04b609 100644 --- a/arch/x86/include/asm/page_32.h +++ b/arch/x86/include/asm/page_32.h | |||
@@ -15,6 +15,7 @@ extern unsigned long __phys_addr(unsigned long); | |||
15 | #else | 15 | #else |
16 | #define __phys_addr(x) __phys_addr_nodebug(x) | 16 | #define __phys_addr(x) __phys_addr_nodebug(x) |
17 | #endif | 17 | #endif |
18 | #define __phys_addr_symbol(x) __phys_addr(x) | ||
18 | #define __phys_reloc_hide(x) RELOC_HIDE((x), 0) | 19 | #define __phys_reloc_hide(x) RELOC_HIDE((x), 0) |
19 | 20 | ||
20 | #ifdef CONFIG_FLATMEM | 21 | #ifdef CONFIG_FLATMEM |
diff --git a/arch/x86/include/asm/page_64.h b/arch/x86/include/asm/page_64.h index 5138174c2101..0f1ddee6a0ce 100644 --- a/arch/x86/include/asm/page_64.h +++ b/arch/x86/include/asm/page_64.h | |||
@@ -21,8 +21,11 @@ static inline unsigned long __phys_addr_nodebug(unsigned long x) | |||
21 | 21 | ||
22 | #ifdef CONFIG_DEBUG_VIRTUAL | 22 | #ifdef CONFIG_DEBUG_VIRTUAL |
23 | extern unsigned long __phys_addr(unsigned long); | 23 | extern unsigned long __phys_addr(unsigned long); |
24 | extern unsigned long __phys_addr_symbol(unsigned long); | ||
24 | #else | 25 | #else |
25 | #define __phys_addr(x) __phys_addr_nodebug(x) | 26 | #define __phys_addr(x) __phys_addr_nodebug(x) |
27 | #define __phys_addr_symbol(x) \ | ||
28 | ((unsigned long)(x) - __START_KERNEL_map + phys_base) | ||
26 | #endif | 29 | #endif |
27 | 30 | ||
28 | #define __phys_reloc_hide(x) (x) | 31 | #define __phys_reloc_hide(x) (x) |
diff --git a/arch/x86/mm/physaddr.c b/arch/x86/mm/physaddr.c index fd40d75109ef..c73feddd518d 100644 --- a/arch/x86/mm/physaddr.c +++ b/arch/x86/mm/physaddr.c | |||
@@ -28,6 +28,17 @@ unsigned long __phys_addr(unsigned long x) | |||
28 | return x; | 28 | return x; |
29 | } | 29 | } |
30 | EXPORT_SYMBOL(__phys_addr); | 30 | EXPORT_SYMBOL(__phys_addr); |
31 | |||
32 | unsigned long __phys_addr_symbol(unsigned long x) | ||
33 | { | ||
34 | unsigned long y = x - __START_KERNEL_map; | ||
35 | |||
36 | /* only check upper bounds since lower bounds will trigger carry */ | ||
37 | VIRTUAL_BUG_ON(y >= KERNEL_IMAGE_SIZE); | ||
38 | |||
39 | return y + phys_base; | ||
40 | } | ||
41 | EXPORT_SYMBOL(__phys_addr_symbol); | ||
31 | #endif | 42 | #endif |
32 | 43 | ||
33 | bool __virt_addr_valid(unsigned long x) | 44 | bool __virt_addr_valid(unsigned long x) |