diff options
author | Arnd Bergmann <arnd@arndb.de> | 2006-01-04 14:31:31 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-01-08 23:44:52 -0500 |
commit | 6ff730c33b42a6c68217fc6660728676aa8eeb9c (patch) | |
tree | 2522175fbaadd3f4d1bd433412f6bfb6e0631754 /arch | |
parent | f0831acc4b78e2d9737e8ed91b8b7505b21ddb83 (diff) |
[PATCH] spufs: fix sparse warnings
One local variable is missing an __iomem modifier,
in another place, we pass a completely unused argument
with a missing __user modifier.
Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/powerpc/platforms/cell/spu_base.c | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/spufs/inode.c | 5 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/spufs/spufs.h | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/spufs/syscalls.c | 2 |
4 files changed, 5 insertions, 6 deletions
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c index 081b3dcbaf14..7fe3fa3da0e9 100644 --- a/arch/powerpc/platforms/cell/spu_base.c +++ b/arch/powerpc/platforms/cell/spu_base.c | |||
@@ -357,7 +357,7 @@ static void spu_init_channels(struct spu *spu) | |||
357 | { 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, }, | 357 | { 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, }, |
358 | { 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, }, | 358 | { 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, }, |
359 | }; | 359 | }; |
360 | struct spu_priv2 *priv2; | 360 | struct spu_priv2 __iomem *priv2; |
361 | int i; | 361 | int i; |
362 | 362 | ||
363 | priv2 = spu->priv2; | 363 | priv2 = spu->priv2; |
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index 687f80d09f41..1f3507c75e90 100644 --- a/arch/powerpc/platforms/cell/spufs/inode.c +++ b/arch/powerpc/platforms/cell/spufs/inode.c | |||
@@ -293,9 +293,8 @@ out: | |||
293 | 293 | ||
294 | static struct file_system_type spufs_type; | 294 | static struct file_system_type spufs_type; |
295 | 295 | ||
296 | long | 296 | long spufs_create_thread(struct nameidata *nd, |
297 | spufs_create_thread(struct nameidata *nd, const char *name, | 297 | unsigned int flags, mode_t mode) |
298 | unsigned int flags, mode_t mode) | ||
299 | { | 298 | { |
300 | struct dentry *dentry; | 299 | struct dentry *dentry; |
301 | int ret; | 300 | int ret; |
diff --git a/arch/powerpc/platforms/cell/spufs/spufs.h b/arch/powerpc/platforms/cell/spufs/spufs.h index c715ed0c4014..db2601f0abd5 100644 --- a/arch/powerpc/platforms/cell/spufs/spufs.h +++ b/arch/powerpc/platforms/cell/spufs/spufs.h | |||
@@ -101,7 +101,7 @@ extern struct tree_descr spufs_dir_contents[]; | |||
101 | /* system call implementation */ | 101 | /* system call implementation */ |
102 | long spufs_run_spu(struct file *file, | 102 | long spufs_run_spu(struct file *file, |
103 | struct spu_context *ctx, u32 *npc, u32 *status); | 103 | struct spu_context *ctx, u32 *npc, u32 *status); |
104 | long spufs_create_thread(struct nameidata *nd, const char *name, | 104 | long spufs_create_thread(struct nameidata *nd, |
105 | unsigned int flags, mode_t mode); | 105 | unsigned int flags, mode_t mode); |
106 | extern struct file_operations spufs_context_fops; | 106 | extern struct file_operations spufs_context_fops; |
107 | 107 | ||
diff --git a/arch/powerpc/platforms/cell/spufs/syscalls.c b/arch/powerpc/platforms/cell/spufs/syscalls.c index 0c2896ac9518..d549aa7ebea6 100644 --- a/arch/powerpc/platforms/cell/spufs/syscalls.c +++ b/arch/powerpc/platforms/cell/spufs/syscalls.c | |||
@@ -85,7 +85,7 @@ asmlinkage long sys_spu_create(const char __user *pathname, | |||
85 | ret = path_lookup(tmp, LOOKUP_PARENT| | 85 | ret = path_lookup(tmp, LOOKUP_PARENT| |
86 | LOOKUP_OPEN|LOOKUP_CREATE, &nd); | 86 | LOOKUP_OPEN|LOOKUP_CREATE, &nd); |
87 | if (!ret) { | 87 | if (!ret) { |
88 | ret = spufs_create_thread(&nd, pathname, flags, mode); | 88 | ret = spufs_create_thread(&nd, flags, mode); |
89 | path_release(&nd); | 89 | path_release(&nd); |
90 | } | 90 | } |
91 | putname(tmp); | 91 | putname(tmp); |