diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2009-11-04 12:32:57 -0500 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2009-11-04 16:06:44 -0500 |
commit | 865df576e8fc70daf297b53e61a4fbefc719d065 (patch) | |
tree | 59abb13e1dd402bf8cb4496ab94bbceb2ac2ee2b /arch | |
parent | 0207c356ef0e2bae6ce4603080d42c130d7debc6 (diff) |
PCI: improve discovery/configuration messages
This makes PCI resource management messages more consistent and adds a few
new messages to aid debugging.
Whenever we assign resources to a device, update a BAR, or change a
bridge aperture, it's worth noting it.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/pci/i386.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c index d49d17de7b3f..b73c09f45210 100644 --- a/arch/x86/pci/i386.c +++ b/arch/x86/pci/i386.c | |||
@@ -129,7 +129,9 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list) | |||
129 | continue; | 129 | continue; |
130 | if (!r->start || | 130 | if (!r->start || |
131 | pci_claim_resource(dev, idx) < 0) { | 131 | pci_claim_resource(dev, idx) < 0) { |
132 | dev_info(&dev->dev, "BAR %d: can't allocate %pR\n", idx, r); | 132 | dev_info(&dev->dev, |
133 | "can't reserve window %pR\n", | ||
134 | r); | ||
133 | /* | 135 | /* |
134 | * Something is wrong with the region. | 136 | * Something is wrong with the region. |
135 | * Invalidate the resource to prevent | 137 | * Invalidate the resource to prevent |
@@ -165,10 +167,11 @@ static void __init pcibios_allocate_resources(int pass) | |||
165 | disabled = !(command & PCI_COMMAND_MEMORY); | 167 | disabled = !(command & PCI_COMMAND_MEMORY); |
166 | if (pass == disabled) { | 168 | if (pass == disabled) { |
167 | dev_dbg(&dev->dev, | 169 | dev_dbg(&dev->dev, |
168 | "BAR %d: claiming %pr (d=%d, p=%d)\n", | 170 | "BAR %d: reserving %pr (d=%d, p=%d)\n", |
169 | idx, r, disabled, pass); | 171 | idx, r, disabled, pass); |
170 | if (pci_claim_resource(dev, idx) < 0) { | 172 | if (pci_claim_resource(dev, idx) < 0) { |
171 | dev_info(&dev->dev, "BAR %d: can't claim %pR\n", idx, r); | 173 | dev_info(&dev->dev, |
174 | "can't reserve %pR\n", r); | ||
172 | /* We'll assign a new address later */ | 175 | /* We'll assign a new address later */ |
173 | r->end -= r->start; | 176 | r->end -= r->start; |
174 | r->start = 0; | 177 | r->start = 0; |