diff options
author | Yinghai Lu <yhlu.kernel@gmail.com> | 2008-07-21 04:38:14 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-21 07:03:12 -0400 |
commit | 9175fc06aee79c349790672178d3fd7507d75c86 (patch) | |
tree | 4b83a2ef781af89040a41b2432e32c6a3ec27689 /arch | |
parent | 6ac8d51f01d345af5ea4209004a9ea29b2f20891 (diff) |
x86: use setup_clear_cpu_cap() when disabling the lapic
... so don't need to call clear_cpu_cap again in early_identify_cpu,
and could use cleared_cpu_caps like other places.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/apic_32.c | 5 | ||||
-rw-r--r-- | arch/x86/kernel/apic_64.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/cpu/common_64.c | 4 |
3 files changed, 2 insertions, 9 deletions
diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c index a437d027f20b..e9a00e5074b2 100644 --- a/arch/x86/kernel/apic_32.c +++ b/arch/x86/kernel/apic_32.c | |||
@@ -1214,9 +1214,6 @@ int apic_version[MAX_APICS]; | |||
1214 | 1214 | ||
1215 | int __init APIC_init_uniprocessor(void) | 1215 | int __init APIC_init_uniprocessor(void) |
1216 | { | 1216 | { |
1217 | if (disable_apic) | ||
1218 | clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC); | ||
1219 | |||
1220 | if (!smp_found_config && !cpu_has_apic) | 1217 | if (!smp_found_config && !cpu_has_apic) |
1221 | return -1; | 1218 | return -1; |
1222 | 1219 | ||
@@ -1700,7 +1697,7 @@ early_param("lapic", parse_lapic); | |||
1700 | static int __init parse_nolapic(char *arg) | 1697 | static int __init parse_nolapic(char *arg) |
1701 | { | 1698 | { |
1702 | disable_apic = 1; | 1699 | disable_apic = 1; |
1703 | clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC); | 1700 | setup_clear_cpu_cap(X86_FEATURE_APIC); |
1704 | return 0; | 1701 | return 0; |
1705 | } | 1702 | } |
1706 | early_param("nolapic", parse_nolapic); | 1703 | early_param("nolapic", parse_nolapic); |
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c index 1e3d32e27c14..16e586cacbdc 100644 --- a/arch/x86/kernel/apic_64.c +++ b/arch/x86/kernel/apic_64.c | |||
@@ -1337,7 +1337,7 @@ early_param("apic", apic_set_verbosity); | |||
1337 | static __init int setup_disableapic(char *str) | 1337 | static __init int setup_disableapic(char *str) |
1338 | { | 1338 | { |
1339 | disable_apic = 1; | 1339 | disable_apic = 1; |
1340 | clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC); | 1340 | setup_clear_cpu_cap(X86_FEATURE_APIC); |
1341 | return 0; | 1341 | return 0; |
1342 | } | 1342 | } |
1343 | early_param("disableapic", setup_disableapic); | 1343 | early_param("disableapic", setup_disableapic); |
diff --git a/arch/x86/kernel/cpu/common_64.c b/arch/x86/kernel/cpu/common_64.c index 7b8cc72feb40..0485cf644520 100644 --- a/arch/x86/kernel/cpu/common_64.c +++ b/arch/x86/kernel/cpu/common_64.c | |||
@@ -324,10 +324,6 @@ static void __cpuinit early_identify_cpu(struct cpuinfo_x86 *c) | |||
324 | cpu_devs[c->x86_vendor]->c_early_init(c); | 324 | cpu_devs[c->x86_vendor]->c_early_init(c); |
325 | 325 | ||
326 | validate_pat_support(c); | 326 | validate_pat_support(c); |
327 | |||
328 | /* early_param could clear that, but recall get it set again */ | ||
329 | if (disable_apic) | ||
330 | clear_cpu_cap(c, X86_FEATURE_APIC); | ||
331 | } | 327 | } |
332 | 328 | ||
333 | /* | 329 | /* |