diff options
author | linas <linas@austin.ibm.com> | 2005-12-05 20:37:35 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-01-08 22:52:04 -0500 |
commit | e07102db63d10d9f9d94d21dfdb1178e65154b9e (patch) | |
tree | f73f504b9879468b9d5d98770dfacf4a989f113d /arch | |
parent | 398f68580f3edd99728028facf571e4a07f9a035 (diff) |
[PATCH] powerpc: minor cleanup of void ptr deref
Minor: use macro to perform void pointer deref; this may someday help
avoid pointer typecasting errors.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/powerpc/platforms/powermac/pci.c | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/pseries/iommu.c | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/arch/powerpc/platforms/powermac/pci.c b/arch/powerpc/platforms/powermac/pci.c index 443be526cde7..e0b66f55a5f8 100644 --- a/arch/powerpc/platforms/powermac/pci.c +++ b/arch/powerpc/platforms/powermac/pci.c | |||
@@ -326,7 +326,7 @@ static int u3_ht_skip_device(struct pci_controller *hose, | |||
326 | else | 326 | else |
327 | busdn = hose->arch_data; | 327 | busdn = hose->arch_data; |
328 | for (dn = busdn->child; dn; dn = dn->sibling) | 328 | for (dn = busdn->child; dn; dn = dn->sibling) |
329 | if (dn->data && PCI_DN(dn)->devfn == devfn) | 329 | if (PCI_DN(dn) && PCI_DN(dn)->devfn == devfn) |
330 | break; | 330 | break; |
331 | if (dn == NULL) | 331 | if (dn == NULL) |
332 | return -1; | 332 | return -1; |
diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c index 2043659ea7b1..169f9148789c 100644 --- a/arch/powerpc/platforms/pseries/iommu.c +++ b/arch/powerpc/platforms/pseries/iommu.c | |||
@@ -436,7 +436,7 @@ static void iommu_bus_setup_pSeriesLP(struct pci_bus *bus) | |||
436 | return; | 436 | return; |
437 | } | 437 | } |
438 | 438 | ||
439 | ppci = pdn->data; | 439 | ppci = PCI_DN(pdn); |
440 | if (!ppci->iommu_table) { | 440 | if (!ppci->iommu_table) { |
441 | /* Bussubno hasn't been copied yet. | 441 | /* Bussubno hasn't been copied yet. |
442 | * Do it now because iommu_table_setparms_lpar needs it. | 442 | * Do it now because iommu_table_setparms_lpar needs it. |
@@ -483,10 +483,10 @@ static void iommu_dev_setup_pSeries(struct pci_dev *dev) | |||
483 | * an already allocated iommu table is found and use that. | 483 | * an already allocated iommu table is found and use that. |
484 | */ | 484 | */ |
485 | 485 | ||
486 | while (dn && dn->data && PCI_DN(dn)->iommu_table == NULL) | 486 | while (dn && PCI_DN(dn) && PCI_DN(dn)->iommu_table == NULL) |
487 | dn = dn->parent; | 487 | dn = dn->parent; |
488 | 488 | ||
489 | if (dn && dn->data) { | 489 | if (dn && PCI_DN(dn)) { |
490 | PCI_DN(mydn)->iommu_table = PCI_DN(dn)->iommu_table; | 490 | PCI_DN(mydn)->iommu_table = PCI_DN(dn)->iommu_table; |
491 | } else { | 491 | } else { |
492 | DBG("iommu_dev_setup_pSeries, dev %p (%s) has no iommu table\n", dev, pci_name(dev)); | 492 | DBG("iommu_dev_setup_pSeries, dev %p (%s) has no iommu table\n", dev, pci_name(dev)); |
@@ -497,7 +497,7 @@ static int iommu_reconfig_notifier(struct notifier_block *nb, unsigned long acti | |||
497 | { | 497 | { |
498 | int err = NOTIFY_OK; | 498 | int err = NOTIFY_OK; |
499 | struct device_node *np = node; | 499 | struct device_node *np = node; |
500 | struct pci_dn *pci = np->data; | 500 | struct pci_dn *pci = PCI_DN(np); |
501 | 501 | ||
502 | switch (action) { | 502 | switch (action) { |
503 | case PSERIES_RECONFIG_REMOVE: | 503 | case PSERIES_RECONFIG_REMOVE: |
@@ -533,7 +533,7 @@ static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev) | |||
533 | */ | 533 | */ |
534 | dn = pci_device_to_OF_node(dev); | 534 | dn = pci_device_to_OF_node(dev); |
535 | 535 | ||
536 | for (pdn = dn; pdn && pdn->data && !PCI_DN(pdn)->iommu_table; | 536 | for (pdn = dn; pdn && PCI_DN(pdn) && !PCI_DN(pdn)->iommu_table; |
537 | pdn = pdn->parent) { | 537 | pdn = pdn->parent) { |
538 | dma_window = (unsigned int *) | 538 | dma_window = (unsigned int *) |
539 | get_property(pdn, "ibm,dma-window", NULL); | 539 | get_property(pdn, "ibm,dma-window", NULL); |
@@ -552,7 +552,7 @@ static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev) | |||
552 | DBG("Found DMA window, allocating table\n"); | 552 | DBG("Found DMA window, allocating table\n"); |
553 | } | 553 | } |
554 | 554 | ||
555 | pci = pdn->data; | 555 | pci = PCI_DN(pdn); |
556 | if (!pci->iommu_table) { | 556 | if (!pci->iommu_table) { |
557 | /* iommu_table_setparms_lpar needs bussubno. */ | 557 | /* iommu_table_setparms_lpar needs bussubno. */ |
558 | pci->bussubno = pci->phb->bus->number; | 558 | pci->bussubno = pci->phb->bus->number; |