aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86_64
diff options
context:
space:
mode:
authorAndi Kleen <ak@suse.de>2006-06-26 07:59:11 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-26 13:48:21 -0400
commit495ab9c045e1b0e5c82951b762257fe1c9d81564 (patch)
treef95c376015d340794f64f36fd52f8fa80a1daab7 /arch/x86_64
parentd9005b52de7bc9b20afa93e06d3e15843bafc12f (diff)
[PATCH] i386/x86-64/ia64: Move polling flag into thread_info_status
During some profiling I noticed that default_idle causes a lot of memory traffic. I think that is caused by the atomic operations to clear/set the polling flag in thread_info. There is actually no reason to make this atomic - only the idle thread does it to itself, other CPUs only read it. So I moved it into ti->status. Converted i386/x86-64/ia64 for now because that was the easiest way to fix ACPI which also manipulates these flags in its idle function. Cc: Nick Piggin <npiggin@novell.com> Cc: Tony Luck <tony.luck@intel.com> Cc: Len Brown <len.brown@intel.com> Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64')
-rw-r--r--arch/x86_64/kernel/process.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c
index d6fa41459c80..b596837a1527 100644
--- a/arch/x86_64/kernel/process.c
+++ b/arch/x86_64/kernel/process.c
@@ -110,7 +110,7 @@ static void default_idle(void)
110{ 110{
111 local_irq_enable(); 111 local_irq_enable();
112 112
113 clear_thread_flag(TIF_POLLING_NRFLAG); 113 current_thread_info()->status &= ~TS_POLLING;
114 smp_mb__after_clear_bit(); 114 smp_mb__after_clear_bit();
115 while (!need_resched()) { 115 while (!need_resched()) {
116 local_irq_disable(); 116 local_irq_disable();
@@ -119,7 +119,7 @@ static void default_idle(void)
119 else 119 else
120 local_irq_enable(); 120 local_irq_enable();
121 } 121 }
122 set_thread_flag(TIF_POLLING_NRFLAG); 122 current_thread_info()->status |= TS_POLLING;
123} 123}
124 124
125/* 125/*
@@ -202,8 +202,7 @@ static inline void play_dead(void)
202 */ 202 */
203void cpu_idle (void) 203void cpu_idle (void)
204{ 204{
205 set_thread_flag(TIF_POLLING_NRFLAG); 205 current_thread_info()->status |= TS_POLLING;
206
207 /* endless idle loop with no priority at all */ 206 /* endless idle loop with no priority at all */
208 while (1) { 207 while (1) {
209 while (!need_resched()) { 208 while (!need_resched()) {