diff options
author | Ingo Molnar <mingo@elte.hu> | 2006-10-17 03:10:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-17 11:18:45 -0400 |
commit | a460e745e8f9c75a0525ff94154a0629f9d3e05d (patch) | |
tree | 38ef71d81c2ca2f979319b0a91f34f0cf9998643 /arch/x86_64 | |
parent | 308ba5fcf89b6e328f9290067181c1e4d772fdc9 (diff) |
[PATCH] genirq: clean up irq-flow-type naming
Introduce desc->name and eliminate the handle_irq_name() hack. Add
set_irq_chip_and_handler_name() to set the flow type and name at once.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Matthew Wilcox <willy@debian.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64')
-rw-r--r-- | arch/x86_64/kernel/i8259.c | 7 | ||||
-rw-r--r-- | arch/x86_64/kernel/io_apic.c | 15 | ||||
-rw-r--r-- | arch/x86_64/kernel/irq.c | 2 |
3 files changed, 13 insertions, 11 deletions
diff --git a/arch/x86_64/kernel/i8259.c b/arch/x86_64/kernel/i8259.c index 0612a33bb896..c4ef801b765b 100644 --- a/arch/x86_64/kernel/i8259.c +++ b/arch/x86_64/kernel/i8259.c | |||
@@ -178,7 +178,8 @@ void make_8259A_irq(unsigned int irq) | |||
178 | { | 178 | { |
179 | disable_irq_nosync(irq); | 179 | disable_irq_nosync(irq); |
180 | io_apic_irqs &= ~(1<<irq); | 180 | io_apic_irqs &= ~(1<<irq); |
181 | set_irq_chip_and_handler(irq, &i8259A_chip, handle_level_irq); | 181 | set_irq_chip_and_handler_name(irq, &i8259A_chip, handle_level_irq, |
182 | "XT"); | ||
182 | enable_irq(irq); | 183 | enable_irq(irq); |
183 | } | 184 | } |
184 | 185 | ||
@@ -431,8 +432,8 @@ void __init init_ISA_irqs (void) | |||
431 | /* | 432 | /* |
432 | * 16 old-style INTA-cycle interrupts: | 433 | * 16 old-style INTA-cycle interrupts: |
433 | */ | 434 | */ |
434 | set_irq_chip_and_handler(i, &i8259A_chip, | 435 | set_irq_chip_and_handler_name(i, &i8259A_chip, |
435 | handle_level_irq); | 436 | handle_level_irq, "XT"); |
436 | } else { | 437 | } else { |
437 | /* | 438 | /* |
438 | * 'high' PCI IRQs filled in on demand | 439 | * 'high' PCI IRQs filled in on demand |
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c index 44b55f833875..49e94f7994c5 100644 --- a/arch/x86_64/kernel/io_apic.c +++ b/arch/x86_64/kernel/io_apic.c | |||
@@ -696,11 +696,11 @@ static void ioapic_register_intr(int irq, int vector, unsigned long trigger) | |||
696 | { | 696 | { |
697 | if ((trigger == IOAPIC_AUTO && IO_APIC_irq_trigger(irq)) || | 697 | if ((trigger == IOAPIC_AUTO && IO_APIC_irq_trigger(irq)) || |
698 | trigger == IOAPIC_LEVEL) | 698 | trigger == IOAPIC_LEVEL) |
699 | set_irq_chip_and_handler(irq, &ioapic_chip, | 699 | set_irq_chip_and_handler_name(irq, &ioapic_chip, |
700 | handle_fasteoi_irq); | 700 | handle_fasteoi_irq, "fasteoi"); |
701 | else | 701 | else |
702 | set_irq_chip_and_handler(irq, &ioapic_chip, | 702 | set_irq_chip_and_handler_name(irq, &ioapic_chip, |
703 | handle_edge_irq); | 703 | handle_edge_irq, "edge"); |
704 | } | 704 | } |
705 | 705 | ||
706 | static void __init setup_IO_APIC_irqs(void) | 706 | static void __init setup_IO_APIC_irqs(void) |
@@ -806,7 +806,7 @@ static void __init setup_ExtINT_IRQ0_pin(unsigned int apic, unsigned int pin, in | |||
806 | * The timer IRQ doesn't have to know that behind the | 806 | * The timer IRQ doesn't have to know that behind the |
807 | * scene we have a 8259A-master in AEOI mode ... | 807 | * scene we have a 8259A-master in AEOI mode ... |
808 | */ | 808 | */ |
809 | set_irq_chip_and_handler(0, &ioapic_chip, handle_edge_irq); | 809 | set_irq_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq, "edge"); |
810 | 810 | ||
811 | /* | 811 | /* |
812 | * Add it to the IO-APIC irq-routing table: | 812 | * Add it to the IO-APIC irq-routing table: |
@@ -1839,7 +1839,7 @@ int arch_setup_msi_irq(unsigned int irq, struct pci_dev *dev) | |||
1839 | 1839 | ||
1840 | write_msi_msg(irq, &msg); | 1840 | write_msi_msg(irq, &msg); |
1841 | 1841 | ||
1842 | set_irq_chip_and_handler(irq, &msi_chip, handle_edge_irq); | 1842 | set_irq_chip_and_handler_name(irq, &msi_chip, handle_edge_irq, "edge"); |
1843 | 1843 | ||
1844 | return 0; | 1844 | return 0; |
1845 | } | 1845 | } |
@@ -1936,7 +1936,8 @@ int arch_setup_ht_irq(unsigned int irq, struct pci_dev *dev) | |||
1936 | write_ht_irq_low(irq, low); | 1936 | write_ht_irq_low(irq, low); |
1937 | write_ht_irq_high(irq, high); | 1937 | write_ht_irq_high(irq, high); |
1938 | 1938 | ||
1939 | set_irq_chip_and_handler(irq, &ht_irq_chip, handle_edge_irq); | 1939 | set_irq_chip_and_handler_name(irq, &ht_irq_chip, |
1940 | handle_edge_irq, "edge"); | ||
1940 | } | 1941 | } |
1941 | return vector; | 1942 | return vector; |
1942 | } | 1943 | } |
diff --git a/arch/x86_64/kernel/irq.c b/arch/x86_64/kernel/irq.c index dff68eb2b787..e46c55856d40 100644 --- a/arch/x86_64/kernel/irq.c +++ b/arch/x86_64/kernel/irq.c | |||
@@ -75,7 +75,7 @@ int show_interrupts(struct seq_file *p, void *v) | |||
75 | seq_printf(p, "%10u ", kstat_cpu(j).irqs[i]); | 75 | seq_printf(p, "%10u ", kstat_cpu(j).irqs[i]); |
76 | #endif | 76 | #endif |
77 | seq_printf(p, " %8s", irq_desc[i].chip->name); | 77 | seq_printf(p, " %8s", irq_desc[i].chip->name); |
78 | seq_printf(p, "-%s", handle_irq_name(irq_desc[i].handle_irq)); | 78 | seq_printf(p, "-%-8s", irq_desc[i].name); |
79 | 79 | ||
80 | seq_printf(p, " %s", action->name); | 80 | seq_printf(p, " %s", action->name); |
81 | for (action=action->next; action; action = action->next) | 81 | for (action=action->next; action; action = action->next) |