diff options
author | Andi Kleen <ak@suse.de> | 2006-04-07 13:50:15 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-09 14:53:52 -0400 |
commit | 49c93e84d8b2d602a07c302c7e3cd4fa09095fbb (patch) | |
tree | a59d0bb7a9f1df9f3187e466e3937ea9ffd83343 /arch/x86_64/pci | |
parent | 8c30b1a74aed4041f183e183a149b7dfbdc6c20e (diff) |
[PATCH] i386/x86-64: Return defined error value for bad PCI config space accesses
Mostly to get better handling when a extended config space
access has to fallback to Type1.
Cc: gregkh@suse.de
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64/pci')
-rw-r--r-- | arch/x86_64/pci/mmconfig.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c index d4e25f38287d..b493ed977e7c 100644 --- a/arch/x86_64/pci/mmconfig.c +++ b/arch/x86_64/pci/mmconfig.c | |||
@@ -75,8 +75,10 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus, | |||
75 | char __iomem *addr; | 75 | char __iomem *addr; |
76 | 76 | ||
77 | /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ | 77 | /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ |
78 | if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) | 78 | if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) { |
79 | *value = -1; | ||
79 | return -EINVAL; | 80 | return -EINVAL; |
81 | } | ||
80 | 82 | ||
81 | addr = pci_dev_base(seg, bus, devfn); | 83 | addr = pci_dev_base(seg, bus, devfn); |
82 | if (!addr) | 84 | if (!addr) |