diff options
author | Andi Kleen <ak@suse.de> | 2006-04-11 06:54:48 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-11 09:38:57 -0400 |
commit | ecc16ba96fd5b1a1c1988f0a2b05ff954bdff728 (patch) | |
tree | 57a994d0741ddef2c869db0ef83d3456cc6a13df /arch/x86_64/pci | |
parent | 3d8a4d795cc1ffa6be5371629ca6c3431af4c2d5 (diff) |
[PATCH] i386/x86-64: Remove checks for value == NULL in PCI config space access
Nobody should pass NULL here. Could in theory make it a BUG,
but the NULL pointer oops will do as well.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64/pci')
-rw-r--r-- | arch/x86_64/pci/mmconfig.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c index b493ed977e7c..1a59a31bb740 100644 --- a/arch/x86_64/pci/mmconfig.c +++ b/arch/x86_64/pci/mmconfig.c | |||
@@ -75,7 +75,7 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus, | |||
75 | char __iomem *addr; | 75 | char __iomem *addr; |
76 | 76 | ||
77 | /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ | 77 | /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ |
78 | if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) { | 78 | if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) { |
79 | *value = -1; | 79 | *value = -1; |
80 | return -EINVAL; | 80 | return -EINVAL; |
81 | } | 81 | } |