diff options
author | Andi Kleen <ak@suse.de> | 2007-05-11 05:23:20 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-11 15:53:00 -0400 |
commit | 8bd994815987dda0947bd9afd887b1410713d4f7 (patch) | |
tree | b453238c4f2a14b557db0568e6ada733e5310ecd /arch/x86_64/kernel | |
parent | 547c5355d1b1167af39e315c82aa9ff1398596f4 (diff) |
x86_64: Don't call mtrr_bp_init from identify_cpu
The code was ok, but triggered warnings for calling __init from
__cpuinit. Instead call it from check_bugs instead.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/x86_64/kernel')
-rw-r--r-- | arch/x86_64/kernel/bugs.c | 1 | ||||
-rw-r--r-- | arch/x86_64/kernel/setup.c | 4 |
2 files changed, 2 insertions, 3 deletions
diff --git a/arch/x86_64/kernel/bugs.c b/arch/x86_64/kernel/bugs.c index 12b585b5345d..c141e7a7ff55 100644 --- a/arch/x86_64/kernel/bugs.c +++ b/arch/x86_64/kernel/bugs.c | |||
@@ -13,6 +13,7 @@ | |||
13 | void __init check_bugs(void) | 13 | void __init check_bugs(void) |
14 | { | 14 | { |
15 | identify_cpu(&boot_cpu_data); | 15 | identify_cpu(&boot_cpu_data); |
16 | mtrr_bp_init(); | ||
16 | #if !defined(CONFIG_SMP) | 17 | #if !defined(CONFIG_SMP) |
17 | printk("CPU: "); | 18 | printk("CPU: "); |
18 | print_cpu_info(&boot_cpu_data); | 19 | print_cpu_info(&boot_cpu_data); |
diff --git a/arch/x86_64/kernel/setup.c b/arch/x86_64/kernel/setup.c index db51577bda32..eb6524f3ac29 100644 --- a/arch/x86_64/kernel/setup.c +++ b/arch/x86_64/kernel/setup.c | |||
@@ -891,9 +891,7 @@ void __cpuinit identify_cpu(struct cpuinfo_x86 *c) | |||
891 | #ifdef CONFIG_X86_MCE | 891 | #ifdef CONFIG_X86_MCE |
892 | mcheck_init(c); | 892 | mcheck_init(c); |
893 | #endif | 893 | #endif |
894 | if (c == &boot_cpu_data) | 894 | if (c != &boot_cpu_data) |
895 | mtrr_bp_init(); | ||
896 | else | ||
897 | mtrr_ap_init(); | 895 | mtrr_ap_init(); |
898 | #ifdef CONFIG_NUMA | 896 | #ifdef CONFIG_NUMA |
899 | numa_add_cpu(smp_processor_id()); | 897 | numa_add_cpu(smp_processor_id()); |