diff options
author | Yinghai Lu <yinghai@kernel.org> | 2009-02-15 02:57:28 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-02-15 07:23:46 -0500 |
commit | 88d0f550d71493cd975a11a03c166211b2f3bd32 (patch) | |
tree | 2aadb97a1ac90358d9c38cd99611a3f32d4da3dd /arch/x86 | |
parent | b69bc3967445169ea4dc11171118b414eafab271 (diff) |
x86: make 32bit to call enable_IO_APIC early like 64bit
Impact: cleanup
So we remove some #ifdefs.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/kernel/apic.c | 8 | ||||
-rw-r--r-- | arch/x86/kernel/io_apic.c | 4 | ||||
-rw-r--r-- | arch/x86/kernel/smpboot.c | 3 |
3 files changed, 5 insertions, 10 deletions
diff --git a/arch/x86/kernel/apic.c b/arch/x86/kernel/apic.c index 8bd801db24d9..b8616aaa168d 100644 --- a/arch/x86/kernel/apic.c +++ b/arch/x86/kernel/apic.c | |||
@@ -1646,19 +1646,19 @@ int __init APIC_init_uniprocessor(void) | |||
1646 | physid_set_mask_of_physid(boot_cpu_physical_apicid, &phys_cpu_present_map); | 1646 | physid_set_mask_of_physid(boot_cpu_physical_apicid, &phys_cpu_present_map); |
1647 | setup_local_APIC(); | 1647 | setup_local_APIC(); |
1648 | 1648 | ||
1649 | #ifdef CONFIG_X86_64 | 1649 | #ifdef CONFIG_X86_IO_APIC |
1650 | /* | 1650 | /* |
1651 | * Now enable IO-APICs, actually call clear_IO_APIC | 1651 | * Now enable IO-APICs, actually call clear_IO_APIC |
1652 | * We need clear_IO_APIC before enabling vector on BP | 1652 | * We need clear_IO_APIC before enabling vector on BP |
1653 | */ | 1653 | */ |
1654 | if (!skip_ioapic_setup && nr_ioapics) | 1654 | if (!skip_ioapic_setup && nr_ioapics) |
1655 | enable_IO_APIC(); | 1655 | enable_IO_APIC(); |
1656 | #endif | ||
1657 | 1656 | ||
1658 | #ifdef CONFIG_X86_IO_APIC | ||
1659 | if (!smp_found_config || skip_ioapic_setup || !nr_ioapics) | 1657 | if (!smp_found_config || skip_ioapic_setup || !nr_ioapics) |
1660 | #endif | ||
1661 | localise_nmi_watchdog(); | 1658 | localise_nmi_watchdog(); |
1659 | #else | ||
1660 | localise_nmi_watchdog(); | ||
1661 | #endif | ||
1662 | end_local_APIC_setup(); | 1662 | end_local_APIC_setup(); |
1663 | 1663 | ||
1664 | #ifdef CONFIG_X86_IO_APIC | 1664 | #ifdef CONFIG_X86_IO_APIC |
diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c index 7248ca11bdcd..0b7cde3da48b 100644 --- a/arch/x86/kernel/io_apic.c +++ b/arch/x86/kernel/io_apic.c | |||
@@ -3057,13 +3057,9 @@ out: | |||
3057 | void __init setup_IO_APIC(void) | 3057 | void __init setup_IO_APIC(void) |
3058 | { | 3058 | { |
3059 | 3059 | ||
3060 | #ifdef CONFIG_X86_32 | ||
3061 | enable_IO_APIC(); | ||
3062 | #else | ||
3063 | /* | 3060 | /* |
3064 | * calling enable_IO_APIC() is moved to setup_local_APIC for BP | 3061 | * calling enable_IO_APIC() is moved to setup_local_APIC for BP |
3065 | */ | 3062 | */ |
3066 | #endif | ||
3067 | 3063 | ||
3068 | io_apic_irqs = ~PIC_IRQS; | 3064 | io_apic_irqs = ~PIC_IRQS; |
3069 | 3065 | ||
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index af57f88186e7..10834954e301 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c | |||
@@ -1154,13 +1154,12 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) | |||
1154 | */ | 1154 | */ |
1155 | setup_local_APIC(); | 1155 | setup_local_APIC(); |
1156 | 1156 | ||
1157 | #ifdef CONFIG_X86_64 | ||
1158 | /* | 1157 | /* |
1159 | * Enable IO APIC before setting up error vector | 1158 | * Enable IO APIC before setting up error vector |
1160 | */ | 1159 | */ |
1161 | if (!skip_ioapic_setup && nr_ioapics) | 1160 | if (!skip_ioapic_setup && nr_ioapics) |
1162 | enable_IO_APIC(); | 1161 | enable_IO_APIC(); |
1163 | #endif | 1162 | |
1164 | end_local_APIC_setup(); | 1163 | end_local_APIC_setup(); |
1165 | 1164 | ||
1166 | map_cpu_to_logical_apicid(); | 1165 | map_cpu_to_logical_apicid(); |