diff options
author | Glauber de Oliveira Costa <gcosta@redhat.com> | 2008-01-30 07:31:27 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:31:27 -0500 |
commit | 053de044411111da00272d1b4e174e7dd743f499 (patch) | |
tree | be44ae9b0ed878df7b83daa39bb89e01f3fdbe73 /arch/x86 | |
parent | 73018a66e70fa631935192e5ed6ef8fa2d20b22d (diff) |
x86: get rid of _MASK flags
There's no need for the *_MASK flags (TF_MASK, IF_MASK, etc), found in
processor.h (both _32 and _64). They have a one-to-one mapping with the
EFLAGS value. This patch removes the definitions, and use the already
existent X86_EFLAGS_ version when applicable.
[ roland@redhat.com: KVM build fixes. ]
Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/ia32/ia32_signal.c | 4 | ||||
-rw-r--r-- | arch/x86/kernel/kprobes.c | 18 | ||||
-rw-r--r-- | arch/x86/kernel/signal_64.c | 4 | ||||
-rw-r--r-- | arch/x86/kernel/traps_64.c | 2 |
4 files changed, 14 insertions, 14 deletions
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c index d03d43f32f4c..0e24e3fda3d7 100644 --- a/arch/x86/ia32/ia32_signal.c +++ b/arch/x86/ia32/ia32_signal.c | |||
@@ -501,7 +501,7 @@ int ia32_setup_frame(int sig, struct k_sigaction *ka, | |||
501 | regs->ss = __USER32_DS; | 501 | regs->ss = __USER32_DS; |
502 | 502 | ||
503 | set_fs(USER_DS); | 503 | set_fs(USER_DS); |
504 | regs->flags &= ~TF_MASK; | 504 | regs->flags &= ~X86_EFLAGS_TF; |
505 | if (test_thread_flag(TIF_SINGLESTEP)) | 505 | if (test_thread_flag(TIF_SINGLESTEP)) |
506 | ptrace_notify(SIGTRAP); | 506 | ptrace_notify(SIGTRAP); |
507 | 507 | ||
@@ -601,7 +601,7 @@ int ia32_setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, | |||
601 | regs->ss = __USER32_DS; | 601 | regs->ss = __USER32_DS; |
602 | 602 | ||
603 | set_fs(USER_DS); | 603 | set_fs(USER_DS); |
604 | regs->flags &= ~TF_MASK; | 604 | regs->flags &= ~X86_EFLAGS_TF; |
605 | if (test_thread_flag(TIF_SINGLESTEP)) | 605 | if (test_thread_flag(TIF_SINGLESTEP)) |
606 | ptrace_notify(SIGTRAP); | 606 | ptrace_notify(SIGTRAP); |
607 | 607 | ||
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c index 9aadd4d4a229..8de82c8cedd6 100644 --- a/arch/x86/kernel/kprobes.c +++ b/arch/x86/kernel/kprobes.c | |||
@@ -387,9 +387,9 @@ static void __kprobes set_current_kprobe(struct kprobe *p, struct pt_regs *regs, | |||
387 | { | 387 | { |
388 | __get_cpu_var(current_kprobe) = p; | 388 | __get_cpu_var(current_kprobe) = p; |
389 | kcb->kprobe_saved_flags = kcb->kprobe_old_flags | 389 | kcb->kprobe_saved_flags = kcb->kprobe_old_flags |
390 | = (regs->flags & (TF_MASK | IF_MASK)); | 390 | = (regs->flags & (X86_EFLAGS_TF | X86_EFLAGS_IF)); |
391 | if (is_IF_modifier(p->ainsn.insn)) | 391 | if (is_IF_modifier(p->ainsn.insn)) |
392 | kcb->kprobe_saved_flags &= ~IF_MASK; | 392 | kcb->kprobe_saved_flags &= ~X86_EFLAGS_IF; |
393 | } | 393 | } |
394 | 394 | ||
395 | static __always_inline void clear_btf(void) | 395 | static __always_inline void clear_btf(void) |
@@ -407,8 +407,8 @@ static __always_inline void restore_btf(void) | |||
407 | static void __kprobes prepare_singlestep(struct kprobe *p, struct pt_regs *regs) | 407 | static void __kprobes prepare_singlestep(struct kprobe *p, struct pt_regs *regs) |
408 | { | 408 | { |
409 | clear_btf(); | 409 | clear_btf(); |
410 | regs->flags |= TF_MASK; | 410 | regs->flags |= X86_EFLAGS_TF; |
411 | regs->flags &= ~IF_MASK; | 411 | regs->flags &= ~X86_EFLAGS_IF; |
412 | /*single step inline if the instruction is an int3*/ | 412 | /*single step inline if the instruction is an int3*/ |
413 | if (p->opcode == BREAKPOINT_INSTRUCTION) | 413 | if (p->opcode == BREAKPOINT_INSTRUCTION) |
414 | regs->ip = (unsigned long)p->addr; | 414 | regs->ip = (unsigned long)p->addr; |
@@ -454,7 +454,7 @@ static int __kprobes kprobe_handler(struct pt_regs *regs) | |||
454 | if (p) { | 454 | if (p) { |
455 | if (kcb->kprobe_status == KPROBE_HIT_SS && | 455 | if (kcb->kprobe_status == KPROBE_HIT_SS && |
456 | *p->ainsn.insn == BREAKPOINT_INSTRUCTION) { | 456 | *p->ainsn.insn == BREAKPOINT_INSTRUCTION) { |
457 | regs->flags &= ~TF_MASK; | 457 | regs->flags &= ~X86_EFLAGS_TF; |
458 | regs->flags |= kcb->kprobe_saved_flags; | 458 | regs->flags |= kcb->kprobe_saved_flags; |
459 | goto no_kprobe; | 459 | goto no_kprobe; |
460 | #ifdef CONFIG_X86_64 | 460 | #ifdef CONFIG_X86_64 |
@@ -749,10 +749,10 @@ static void __kprobes resume_execution(struct kprobe *p, | |||
749 | insn++; | 749 | insn++; |
750 | #endif | 750 | #endif |
751 | 751 | ||
752 | regs->flags &= ~TF_MASK; | 752 | regs->flags &= ~X86_EFLAGS_TF; |
753 | switch (*insn) { | 753 | switch (*insn) { |
754 | case 0x9c: /* pushfl */ | 754 | case 0x9c: /* pushfl */ |
755 | *tos &= ~(TF_MASK | IF_MASK); | 755 | *tos &= ~(X86_EFLAGS_TF | X86_EFLAGS_IF); |
756 | *tos |= kcb->kprobe_old_flags; | 756 | *tos |= kcb->kprobe_old_flags; |
757 | break; | 757 | break; |
758 | case 0xc2: /* iret/ret/lret */ | 758 | case 0xc2: /* iret/ret/lret */ |
@@ -852,7 +852,7 @@ out: | |||
852 | * will have TF set, in which case, continue the remaining processing | 852 | * will have TF set, in which case, continue the remaining processing |
853 | * of do_debug, as if this is not a probe hit. | 853 | * of do_debug, as if this is not a probe hit. |
854 | */ | 854 | */ |
855 | if (regs->flags & TF_MASK) | 855 | if (regs->flags & X86_EFLAGS_TF) |
856 | return 0; | 856 | return 0; |
857 | 857 | ||
858 | return 1; | 858 | return 1; |
@@ -982,7 +982,7 @@ int __kprobes setjmp_pre_handler(struct kprobe *p, struct pt_regs *regs) | |||
982 | */ | 982 | */ |
983 | memcpy(kcb->jprobes_stack, (kprobe_opcode_t *)addr, | 983 | memcpy(kcb->jprobes_stack, (kprobe_opcode_t *)addr, |
984 | MIN_STACK_SIZE(addr)); | 984 | MIN_STACK_SIZE(addr)); |
985 | regs->flags &= ~IF_MASK; | 985 | regs->flags &= ~X86_EFLAGS_IF; |
986 | trace_hardirqs_off(); | 986 | trace_hardirqs_off(); |
987 | regs->ip = (unsigned long)(jp->entry); | 987 | regs->ip = (unsigned long)(jp->entry); |
988 | return 1; | 988 | return 1; |
diff --git a/arch/x86/kernel/signal_64.c b/arch/x86/kernel/signal_64.c index 1c9bca56fb55..4eb751c60390 100644 --- a/arch/x86/kernel/signal_64.c +++ b/arch/x86/kernel/signal_64.c | |||
@@ -295,7 +295,7 @@ static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, | |||
295 | see include/asm-x86_64/uaccess.h for details. */ | 295 | see include/asm-x86_64/uaccess.h for details. */ |
296 | set_fs(USER_DS); | 296 | set_fs(USER_DS); |
297 | 297 | ||
298 | regs->flags &= ~TF_MASK; | 298 | regs->flags &= ~X86_EFLAGS_TF; |
299 | if (test_thread_flag(TIF_SINGLESTEP)) | 299 | if (test_thread_flag(TIF_SINGLESTEP)) |
300 | ptrace_notify(SIGTRAP); | 300 | ptrace_notify(SIGTRAP); |
301 | #ifdef DEBUG_SIG | 301 | #ifdef DEBUG_SIG |
@@ -463,7 +463,7 @@ do_notify_resume(struct pt_regs *regs, void *unused, __u32 thread_info_flags) | |||
463 | 463 | ||
464 | /* Pending single-step? */ | 464 | /* Pending single-step? */ |
465 | if (thread_info_flags & _TIF_SINGLESTEP) { | 465 | if (thread_info_flags & _TIF_SINGLESTEP) { |
466 | regs->flags |= TF_MASK; | 466 | regs->flags |= X86_EFLAGS_TF; |
467 | clear_thread_flag(TIF_SINGLESTEP); | 467 | clear_thread_flag(TIF_SINGLESTEP); |
468 | } | 468 | } |
469 | 469 | ||
diff --git a/arch/x86/kernel/traps_64.c b/arch/x86/kernel/traps_64.c index cf90ceb48f5f..7118fa0320ae 100644 --- a/arch/x86/kernel/traps_64.c +++ b/arch/x86/kernel/traps_64.c | |||
@@ -904,7 +904,7 @@ clear_dr7: | |||
904 | 904 | ||
905 | clear_TF_reenable: | 905 | clear_TF_reenable: |
906 | set_tsk_thread_flag(tsk, TIF_SINGLESTEP); | 906 | set_tsk_thread_flag(tsk, TIF_SINGLESTEP); |
907 | regs->flags &= ~TF_MASK; | 907 | regs->flags &= ~X86_EFLAGS_TF; |
908 | preempt_conditional_cli(regs); | 908 | preempt_conditional_cli(regs); |
909 | } | 909 | } |
910 | 910 | ||