aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86
diff options
context:
space:
mode:
authorHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>2009-06-15 04:20:57 -0400
committerH. Peter Anvin <hpa@zytor.com>2009-06-16 19:56:06 -0400
commit1020bcbcc7da36001d9226c5d57e999949cb80c5 (patch)
tree608da1dd9bfa7ef28103bc4cc9a6de7bdea7b8b1 /arch/x86
parent4e5b3e690dda890523e93af9c545261f5916a3a6 (diff)
x86, mce: rename static variables around trigger
"trigger" is not straight forward name for valiable that holds name of user mode helper program which triggered by machine check events. This patch renames this valiable and kins to more recognizable names. trigger => mce_helper trigger_argv => mce_helper_argv notify_user => mce_need_notify No functional changes. Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/kernel/cpu/mcheck/mce.c27
1 files changed, 14 insertions, 13 deletions
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 2d2e0b565a9c..e8b893e880ed 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -88,9 +88,10 @@ int mce_cmci_disabled __read_mostly;
88int mce_ignore_ce __read_mostly; 88int mce_ignore_ce __read_mostly;
89int mce_ser __read_mostly; 89int mce_ser __read_mostly;
90 90
91static unsigned long notify_user; 91/* User mode helper program triggered by machine check event */
92static char trigger[128]; 92static unsigned long mce_need_notify;
93static char *trigger_argv[2] = { trigger, NULL }; 93static char mce_helper[128];
94static char *mce_helper_argv[2] = { mce_helper, NULL };
94 95
95static unsigned long dont_init_banks; 96static unsigned long dont_init_banks;
96 97
@@ -180,7 +181,7 @@ void mce_log(struct mce *mce)
180 wmb(); 181 wmb();
181 182
182 mce->finished = 1; 183 mce->finished = 1;
183 set_bit(0, &notify_user); 184 set_bit(0, &mce_need_notify);
184} 185}
185 186
186static void print_mce(struct mce *m) 187static void print_mce(struct mce *m)
@@ -1122,7 +1123,7 @@ static void mcheck_timer(unsigned long data)
1122 1123
1123static void mce_do_trigger(struct work_struct *work) 1124static void mce_do_trigger(struct work_struct *work)
1124{ 1125{
1125 call_usermodehelper(trigger, trigger_argv, NULL, UMH_NO_WAIT); 1126 call_usermodehelper(mce_helper, mce_helper_argv, NULL, UMH_NO_WAIT);
1126} 1127}
1127 1128
1128static DECLARE_WORK(mce_trigger_work, mce_do_trigger); 1129static DECLARE_WORK(mce_trigger_work, mce_do_trigger);
@@ -1139,7 +1140,7 @@ int mce_notify_irq(void)
1139 1140
1140 clear_thread_flag(TIF_MCE_NOTIFY); 1141 clear_thread_flag(TIF_MCE_NOTIFY);
1141 1142
1142 if (test_and_clear_bit(0, &notify_user)) { 1143 if (test_and_clear_bit(0, &mce_need_notify)) {
1143 wake_up_interruptible(&mce_wait); 1144 wake_up_interruptible(&mce_wait);
1144 1145
1145 /* 1146 /*
@@ -1147,7 +1148,7 @@ int mce_notify_irq(void)
1147 * work_pending is always cleared before the function is 1148 * work_pending is always cleared before the function is
1148 * executed. 1149 * executed.
1149 */ 1150 */
1150 if (trigger[0] && !work_pending(&mce_trigger_work)) 1151 if (mce_helper[0] && !work_pending(&mce_trigger_work))
1151 schedule_work(&mce_trigger_work); 1152 schedule_work(&mce_trigger_work);
1152 1153
1153 if (__ratelimit(&ratelimit)) 1154 if (__ratelimit(&ratelimit))
@@ -1664,9 +1665,9 @@ static ssize_t set_bank(struct sys_device *s, struct sysdev_attribute *attr,
1664static ssize_t 1665static ssize_t
1665show_trigger(struct sys_device *s, struct sysdev_attribute *attr, char *buf) 1666show_trigger(struct sys_device *s, struct sysdev_attribute *attr, char *buf)
1666{ 1667{
1667 strcpy(buf, trigger); 1668 strcpy(buf, mce_helper);
1668 strcat(buf, "\n"); 1669 strcat(buf, "\n");
1669 return strlen(trigger) + 1; 1670 return strlen(mce_helper) + 1;
1670} 1671}
1671 1672
1672static ssize_t set_trigger(struct sys_device *s, struct sysdev_attribute *attr, 1673static ssize_t set_trigger(struct sys_device *s, struct sysdev_attribute *attr,
@@ -1675,10 +1676,10 @@ static ssize_t set_trigger(struct sys_device *s, struct sysdev_attribute *attr,
1675 char *p; 1676 char *p;
1676 int len; 1677 int len;
1677 1678
1678 strncpy(trigger, buf, sizeof(trigger)); 1679 strncpy(mce_helper, buf, sizeof(mce_helper));
1679 trigger[sizeof(trigger)-1] = 0; 1680 mce_helper[sizeof(mce_helper)-1] = 0;
1680 len = strlen(trigger); 1681 len = strlen(mce_helper);
1681 p = strchr(trigger, '\n'); 1682 p = strchr(mce_helper, '\n');
1682 1683
1683 if (*p) 1684 if (*p)
1684 *p = 0; 1685 *p = 0;