aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86
diff options
context:
space:
mode:
authorPallipadi, Venkatesh <venkatesh.pallipadi@intel.com>2009-05-26 13:33:35 -0400
committerH. Peter Anvin <hpa@zytor.com>2009-05-26 16:12:12 -0400
commit2171787be2e71ff71159857bfeb21398b61eb615 (patch)
tree671bde892ae47316d9fbf2b5f105d6c365d07b60 /arch/x86
parent46176b4f6bac19454b7b5c35f68594b85850a600 (diff)
x86: avoid back to back on_each_cpu in cpa_flush_array
Cleanup cpa_flush_array() to avoid back to back on_each_cpu() calls. [ Impact: optimizes fix 0af48f42df15b97080b450d24219dd95db7b929a ] Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/mm/pageattr.c17
1 files changed, 3 insertions, 14 deletions
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 0f9052bcec4b..e17efed088c5 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -204,30 +204,19 @@ static void cpa_flush_range(unsigned long start, int numpages, int cache)
204 } 204 }
205} 205}
206 206
207static void wbinvd_local(void *unused)
208{
209 wbinvd();
210}
211
212static void cpa_flush_array(unsigned long *start, int numpages, int cache, 207static void cpa_flush_array(unsigned long *start, int numpages, int cache,
213 int in_flags, struct page **pages) 208 int in_flags, struct page **pages)
214{ 209{
215 unsigned int i, level; 210 unsigned int i, level;
211 unsigned long do_wbinvd = cache && numpages >= 1024; /* 4M threshold */
216 212
217 BUG_ON(irqs_disabled()); 213 BUG_ON(irqs_disabled());
218 214
219 on_each_cpu(__cpa_flush_range, NULL, 1); 215 on_each_cpu(__cpa_flush_all, (void *) do_wbinvd, 1);
220 216
221 if (!cache) 217 if (!cache || do_wbinvd)
222 return; 218 return;
223 219
224 /* 4M threshold */
225 if (numpages >= 1024) {
226 if (boot_cpu_data.x86 >= 4)
227 on_each_cpu(wbinvd_local, NULL, 1);
228
229 return;
230 }
231 /* 220 /*
232 * We only need to flush on one CPU, 221 * We only need to flush on one CPU,
233 * clflush is a MESI-coherent instruction that 222 * clflush is a MESI-coherent instruction that