diff options
author | Daniel J Blueman <daniel.blueman@gmail.com> | 2011-05-18 19:31:31 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-05-20 07:40:41 -0400 |
commit | b64ce24daffb634b5b3133a2e411bd4de50654e8 (patch) | |
tree | f83c6d41c8a40e3f58a76eb97a001731b9393988 /arch/x86 | |
parent | 257313b2a87795e07a0bdf58d0fffbdba8b31051 (diff) |
x86, ioapic: Fix potential resume deadlock
Fix a potential deadlock when resuming; here the calling
function has disabled interrupts, so we cannot sleep.
Change the memory allocation flag from GFP_KERNEL to GFP_ATOMIC.
TODO: We can do away with this memory allocation during resume
by reusing the ioapic suspend/resume code that uses boot time
allocated buffers, but we want to keep this -stable patch
simple.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: <stable@kernel.org> # v2.6.38/39
Link: http://lkml.kernel.org/r/20110518233157.385970138@sbsiddha-MOBL3.sc.intel.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/kernel/apic/io_apic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 45fd33d1fd3a..df636209193e 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c | |||
@@ -621,14 +621,14 @@ struct IO_APIC_route_entry **alloc_ioapic_entries(void) | |||
621 | struct IO_APIC_route_entry **ioapic_entries; | 621 | struct IO_APIC_route_entry **ioapic_entries; |
622 | 622 | ||
623 | ioapic_entries = kzalloc(sizeof(*ioapic_entries) * nr_ioapics, | 623 | ioapic_entries = kzalloc(sizeof(*ioapic_entries) * nr_ioapics, |
624 | GFP_KERNEL); | 624 | GFP_ATOMIC); |
625 | if (!ioapic_entries) | 625 | if (!ioapic_entries) |
626 | return 0; | 626 | return 0; |
627 | 627 | ||
628 | for (apic = 0; apic < nr_ioapics; apic++) { | 628 | for (apic = 0; apic < nr_ioapics; apic++) { |
629 | ioapic_entries[apic] = | 629 | ioapic_entries[apic] = |
630 | kzalloc(sizeof(struct IO_APIC_route_entry) * | 630 | kzalloc(sizeof(struct IO_APIC_route_entry) * |
631 | nr_ioapic_registers[apic], GFP_KERNEL); | 631 | nr_ioapic_registers[apic], GFP_ATOMIC); |
632 | if (!ioapic_entries[apic]) | 632 | if (!ioapic_entries[apic]) |
633 | goto nomem; | 633 | goto nomem; |
634 | } | 634 | } |