aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86
diff options
context:
space:
mode:
authorMarcelo Tosatti <mtosatti@redhat.com>2010-05-03 22:04:27 -0400
committerAvi Kivity <avi@redhat.com>2010-05-19 04:36:33 -0400
commitf1d86e469b60f9e1afed5c17a6e723c2c9c55ceb (patch)
tree6a0714f44067f2991d4b6910f646ccc691bd3deb /arch/x86
parent84ad33ef5dbc12665ad42ee07a2daed473d3ec54 (diff)
KVM: x86: properly update ready_for_interrupt_injection
The recent changes to emulate string instructions without entering guest mode exposed a bug where pending interrupts are not properly reflected in ready_for_interrupt_injection. The result is that userspace overwrites a previously queued interrupt, when irqchip's are emulated in userspace. Fix by always updating state before returning to userspace. Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/kvm/x86.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 6b2ce1d2d748..dff08e527ec7 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4653,7 +4653,6 @@ static int __vcpu_run(struct kvm_vcpu *vcpu)
4653 } 4653 }
4654 4654
4655 srcu_read_unlock(&kvm->srcu, vcpu->srcu_idx); 4655 srcu_read_unlock(&kvm->srcu, vcpu->srcu_idx);
4656 post_kvm_run_save(vcpu);
4657 4656
4658 vapic_exit(vcpu); 4657 vapic_exit(vcpu);
4659 4658
@@ -4703,6 +4702,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
4703 r = __vcpu_run(vcpu); 4702 r = __vcpu_run(vcpu);
4704 4703
4705out: 4704out:
4705 post_kvm_run_save(vcpu);
4706 if (vcpu->sigset_active) 4706 if (vcpu->sigset_active)
4707 sigprocmask(SIG_SETMASK, &sigsaved, NULL); 4707 sigprocmask(SIG_SETMASK, &sigsaved, NULL);
4708 4708