diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2008-01-30 07:33:39 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:33:39 -0500 |
commit | a89780f3b84f9a421e2608580b55f12b3ac4f9c2 (patch) | |
tree | 1e98414b29b773d5d1d234b3390f454e369ae756 /arch/x86/xen | |
parent | 261a5ec36befbe6bae069be14f45e618dcd35146 (diff) |
xen: fix mismerge in masking pte flags
Looks like a mismerge/misapply dropped one of the cases of pte flag
masking for Xen. Also, only mask the flags for present ptes.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/xen')
-rw-r--r-- | arch/x86/xen/mmu.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index 3e9e095c295c..e6184735545f 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c | |||
@@ -241,8 +241,10 @@ unsigned long long xen_pgd_val(pgd_t pgd) | |||
241 | 241 | ||
242 | pte_t xen_make_pte(unsigned long long pte) | 242 | pte_t xen_make_pte(unsigned long long pte) |
243 | { | 243 | { |
244 | if (pte & 1) | 244 | if (pte & _PAGE_PRESENT) { |
245 | pte = phys_to_machine(XPADDR(pte)).maddr; | 245 | pte = phys_to_machine(XPADDR(pte)).maddr; |
246 | pte &= ~(_PAGE_PCD | _PAGE_PWT); | ||
247 | } | ||
246 | 248 | ||
247 | return (pte_t){ .pte = pte }; | 249 | return (pte_t){ .pte = pte }; |
248 | } | 250 | } |
@@ -288,10 +290,10 @@ unsigned long xen_pgd_val(pgd_t pgd) | |||
288 | 290 | ||
289 | pte_t xen_make_pte(unsigned long pte) | 291 | pte_t xen_make_pte(unsigned long pte) |
290 | { | 292 | { |
291 | if (pte & _PAGE_PRESENT) | 293 | if (pte & _PAGE_PRESENT) { |
292 | pte = phys_to_machine(XPADDR(pte)).maddr; | 294 | pte = phys_to_machine(XPADDR(pte)).maddr; |
293 | 295 | pte &= ~(_PAGE_PCD | _PAGE_PWT); | |
294 | pte &= ~(_PAGE_PCD | _PAGE_PWT); | 296 | } |
295 | 297 | ||
296 | return (pte_t){ pte }; | 298 | return (pte_t){ pte }; |
297 | } | 299 | } |