Merge remote-tracking branch 'efi/chainsaw' into x86/efi

Resolved Conflicts:
	drivers/firmware/efivars.c
	fs/efivarsfs/file.c

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

11 files changed, 417 insertions, 21 deletions

diff --git a/arch/x86/platform/Makefile b/arch/x86/platform/Makefile
index 8d874396cb29..01e0231a113e 100644
--- a/arch/x86/platform/Makefile
+++ b/arch/x86/platform/Makefile
@@ -2,10 +2,12 @@
 obj-y   += ce4100/
 obj-y   += efi/
 obj-y   += geode/
+obj-y   += goldfish/
 obj-y   += iris/
 obj-y   += mrst/
 obj-y   += olpc/
 obj-y   += scx200/
 obj-y   += sfi/
+obj-y   += ts5500/
 obj-y   += visws/
 obj-y   += uv/
diff --git a/arch/x86/platform/efi/efi-bgrt.c b/arch/x86/platform/efi/efi-bgrt.c
index d9c1b95af17c..7145ec63c520 100644
--- a/arch/x86/platform/efi/efi-bgrt.c
+++ b/arch/x86/platform/efi/efi-bgrt.c
@@ -11,20 +11,21 @@
  * published by the Free Software Foundation.
  */
 #include <linux/kernel.h>
+#include <linux/init.h>
 #include <linux/acpi.h>
 #include <linux/efi.h>
 #include <linux/efi-bgrt.h>
 
 struct acpi_table_bgrt *bgrt_tab;
-void *bgrt_image;
-size_t bgrt_image_size;
+void *__initdata bgrt_image;
+size_t __initdata bgrt_image_size;
 
 struct bmp_header {
         u16 id;
         u32 size;
 } __packed;
 
-void efi_bgrt_init(void)
+void __init efi_bgrt_init(void)
 {
         acpi_status status;
         void __iomem *image;
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 430cd784a0de..fff986da6239 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -80,9 +80,10 @@ int efi_enabled(int facility)
 }
 EXPORT_SYMBOL(efi_enabled);
 
+static bool __initdata disable_runtime = false;
 static int __init setup_noefi(char *arg)
 {
-        clear_bit(EFI_BOOT, &x86_efi_facility);
+        disable_runtime = true;
         return 0;
 }
 early_param("noefi", setup_noefi);
@@ -412,8 +413,8 @@ void __init efi_reserve_boot_services(void)
                  * - Not within any part of the kernel
                  * - Not the bios reserved area
                 */
-                if ((start+size >= virt_to_phys(_text)
-                                && start <= virt_to_phys(_end)) ||
+                if ((start+size >= __pa_symbol(_text)
+                                && start <= __pa_symbol(_end)) ||
                         !e820_all_mapped(start, start+size, E820_RAM) ||
                         memblock_is_region_reserved(start, size)) {
                         /* Could not reserve, skip it */
@@ -730,7 +731,7 @@ void __init efi_init(void)
         if (!efi_is_native())
                 pr_info("No EFI runtime due to 32/64-bit mismatch with kernel\n");
         else {
-                if (efi_runtime_init())
+                if (disable_runtime || efi_runtime_init())
                         return;
                 set_bit(EFI_RUNTIME_SERVICES, &x86_efi_facility);
         }
@@ -839,7 +840,7 @@ void __init efi_enter_virtual_mode(void)
         efi_memory_desc_t *md, *prev_md = NULL;
         efi_status_t status;
         unsigned long size;
-        u64 end, systab, end_pfn;
+        u64 end, systab, start_pfn, end_pfn;
         void *p, *va, *new_memmap = NULL;
         int count = 0;
 
@@ -892,10 +893,9 @@ void __init efi_enter_virtual_mode(void)
                 size = md->num_pages << EFI_PAGE_SHIFT;
                 end = md->phys_addr + size;
 
+                start_pfn = PFN_DOWN(md->phys_addr);
                 end_pfn = PFN_UP(end);
-                if (end_pfn <= max_low_pfn_mapped
-                    || (end_pfn > (1UL << (32 - PAGE_SHIFT))
-                        && end_pfn <= max_pfn_mapped)) {
+                if (pfn_range_is_mapped(start_pfn, end_pfn)) {
                         va = __va(md->phys_addr);
 
                         if (!(md->attribute & EFI_MEMORY_WB))
diff --git a/arch/x86/platform/goldfish/Makefile b/arch/x86/platform/goldfish/Makefile
new file mode 100644
index 000000000000..f030b532fdf3
--- /dev/null
+++ b/arch/x86/platform/goldfish/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_GOLDFISH)  += goldfish.o
diff --git a/arch/x86/platform/goldfish/goldfish.c b/arch/x86/platform/goldfish/goldfish.c
new file mode 100644
index 000000000000..1693107a518e
--- /dev/null
+++ b/arch/x86/platform/goldfish/goldfish.c
@@ -0,0 +1,51 @@
+/*
+ * Copyright (C) 2007 Google, Inc.
+ * Copyright (C) 2011 Intel, Inc.
+ * Copyright (C) 2013 Intel, Inc.
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/irq.h>
+#include <linux/platform_device.h>
+
+/*
+ * Where in virtual device memory the IO devices (timers, system controllers
+ * and so on)
+ */
+
+#define GOLDFISH_PDEV_BUS_BASE  (0xff001000)
+#define GOLDFISH_PDEV_BUS_END   (0xff7fffff)
+#define GOLDFISH_PDEV_BUS_IRQ   (4)
+
+#define GOLDFISH_TTY_BASE       (0x2000)
+
+static struct resource goldfish_pdev_bus_resources[] = {
+        {
+                .start  = GOLDFISH_PDEV_BUS_BASE,
+                .end    = GOLDFISH_PDEV_BUS_END,
+                .flags  = IORESOURCE_MEM,
+        },
+        {
+                .start  = GOLDFISH_PDEV_BUS_IRQ,
+                .end    = GOLDFISH_PDEV_BUS_IRQ,
+                .flags  = IORESOURCE_IRQ,
+        }
+};
+
+static int __init goldfish_init(void)
+{
+        platform_device_register_simple("goldfish_pdev_bus", -1,
+                                                goldfish_pdev_bus_resources, 2);
+        return 0;
+}
+device_initcall(goldfish_init);
diff --git a/arch/x86/platform/olpc/olpc-xo15-sci.c b/arch/x86/platform/olpc/olpc-xo15-sci.c
index 2fdca25905ae..fef7d0ba7e3a 100644
--- a/arch/x86/platform/olpc/olpc-xo15-sci.c
+++ b/arch/x86/platform/olpc/olpc-xo15-sci.c
@@ -195,7 +195,7 @@ err_sysfs:
         return r;
 }
 
-static int xo15_sci_remove(struct acpi_device *device, int type)
+static int xo15_sci_remove(struct acpi_device *device)
 {
         acpi_disable_gpe(NULL, xo15_sci_gpe);
         acpi_remove_gpe_handler(NULL, xo15_sci_gpe, xo15_sci_gpe_handler);
diff --git a/arch/x86/platform/sfi/sfi.c b/arch/x86/platform/sfi/sfi.c
index 7785b72ecc3a..bcd1a703e3e6 100644
--- a/arch/x86/platform/sfi/sfi.c
+++ b/arch/x86/platform/sfi/sfi.c
@@ -35,7 +35,7 @@
 static unsigned long sfi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
 
 /* All CPUs enumerated by SFI must be present and enabled */
-static void __cpuinit mp_sfi_register_lapic(u8 id)
+static void __init mp_sfi_register_lapic(u8 id)
 {
         if (MAX_LOCAL_APIC - id <= 0) {
                 pr_warning("Processor #%d invalid (max %d)\n",
diff --git a/arch/x86/platform/ts5500/Makefile b/arch/x86/platform/ts5500/Makefile
new file mode 100644
index 000000000000..c54e348c96a7
--- /dev/null
+++ b/arch/x86/platform/ts5500/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_TS5500)    += ts5500.o
diff --git a/arch/x86/platform/ts5500/ts5500.c b/arch/x86/platform/ts5500/ts5500.c
new file mode 100644
index 000000000000..39febb214e8c
--- /dev/null
+++ b/arch/x86/platform/ts5500/ts5500.c
@@ -0,0 +1,339 @@
+/*
+ * Technologic Systems TS-5500 Single Board Computer support
+ *
+ * Copyright (C) 2013 Savoir-faire Linux Inc.
+ *      Vivien Didelot <vivien.didelot@savoirfairelinux.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License as published by the Free Software
+ * Foundation; either version 2 of the License, or (at your option) any later
+ * version.
+ *
+ *
+ * This driver registers the Technologic Systems TS-5500 Single Board Computer
+ * (SBC) and its devices, and exposes information to userspace such as jumpers'
+ * state or available options. For further information about sysfs entries, see
+ * Documentation/ABI/testing/sysfs-platform-ts5500.
+ *
+ * This code actually supports the TS-5500 platform, but it may be extended to
+ * support similar Technologic Systems x86-based platforms, such as the TS-5600.
+ */
+
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/leds.h>
+#include <linux/module.h>
+#include <linux/platform_data/gpio-ts5500.h>
+#include <linux/platform_data/max197.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+/* Product code register */
+#define TS5500_PRODUCT_CODE_ADDR        0x74
+#define TS5500_PRODUCT_CODE             0x60    /* TS-5500 product code */
+
+/* SRAM/RS-485/ADC options, and RS-485 RTS/Automatic RS-485 flags register */
+#define TS5500_SRAM_RS485_ADC_ADDR      0x75
+#define TS5500_SRAM                     BIT(0)  /* SRAM option */
+#define TS5500_RS485                    BIT(1)  /* RS-485 option */
+#define TS5500_ADC                      BIT(2)  /* A/D converter option */
+#define TS5500_RS485_RTS                BIT(6)  /* RTS for RS-485 */
+#define TS5500_RS485_AUTO               BIT(7)  /* Automatic RS-485 */
+
+/* External Reset/Industrial Temperature Range options register */
+#define TS5500_ERESET_ITR_ADDR          0x76
+#define TS5500_ERESET                   BIT(0)  /* External Reset option */
+#define TS5500_ITR                      BIT(1)  /* Indust. Temp. Range option */
+
+/* LED/Jumpers register */
+#define TS5500_LED_JP_ADDR              0x77
+#define TS5500_LED                      BIT(0)  /* LED flag */
+#define TS5500_JP1                      BIT(1)  /* Automatic CMOS */
+#define TS5500_JP2                      BIT(2)  /* Enable Serial Console */
+#define TS5500_JP3                      BIT(3)  /* Write Enable Drive A */
+#define TS5500_JP4                      BIT(4)  /* Fast Console (115K baud) */
+#define TS5500_JP5                      BIT(5)  /* User Jumper */
+#define TS5500_JP6                      BIT(6)  /* Console on COM1 (req. JP2) */
+#define TS5500_JP7                      BIT(7)  /* Undocumented (Unused) */
+
+/* A/D Converter registers */
+#define TS5500_ADC_CONV_BUSY_ADDR       0x195   /* Conversion state register */
+#define TS5500_ADC_CONV_BUSY            BIT(0)
+#define TS5500_ADC_CONV_INIT_LSB_ADDR   0x196   /* Start conv. / LSB register */
+#define TS5500_ADC_CONV_MSB_ADDR        0x197   /* MSB register */
+#define TS5500_ADC_CONV_DELAY           12      /* usec */
+
+/**
+ * struct ts5500_sbc - TS-5500 board description
+ * @id:         Board product ID.
+ * @sram:       Flag for SRAM option.
+ * @rs485:      Flag for RS-485 option.
+ * @adc:        Flag for Analog/Digital converter option.
+ * @ereset:     Flag for External Reset option.
+ * @itr:        Flag for Industrial Temperature Range option.
+ * @jumpers:    Bitfield for jumpers' state.
+ */
+struct ts5500_sbc {
+        int     id;
+        bool    sram;
+        bool    rs485;
+        bool    adc;
+        bool    ereset;
+        bool    itr;
+        u8      jumpers;
+};
+
+/* Board signatures in BIOS shadow RAM */
+static const struct {
+        const char * const string;
+        const ssize_t offset;
+} ts5500_signatures[] __initdata = {
+        { "TS-5x00 AMD Elan", 0xb14 },
+};
+
+static int __init ts5500_check_signature(void)
+{
+        void __iomem *bios;
+        int i, ret = -ENODEV;
+
+        bios = ioremap(0xf0000, 0x10000);
+        if (!bios)
+                return -ENOMEM;
+
+        for (i = 0; i < ARRAY_SIZE(ts5500_signatures); i++) {
+                if (check_signature(bios + ts5500_signatures[i].offset,
+                                    ts5500_signatures[i].string,
+                                    strlen(ts5500_signatures[i].string))) {
+                        ret = 0;
+                        break;
+                }
+        }
+
+        iounmap(bios);
+        return ret;
+}
+
+static int __init ts5500_detect_config(struct ts5500_sbc *sbc)
+{
+        u8 tmp;
+        int ret = 0;
+
+        if (!request_region(TS5500_PRODUCT_CODE_ADDR, 4, "ts5500"))
+                return -EBUSY;
+
+        tmp = inb(TS5500_PRODUCT_CODE_ADDR);
+        if (tmp != TS5500_PRODUCT_CODE) {
+                pr_err("This platform is not a TS-5500 (found ID 0x%x)\n", tmp);
+                ret = -ENODEV;
+                goto cleanup;
+        }
+        sbc->id = tmp;
+
+        tmp = inb(TS5500_SRAM_RS485_ADC_ADDR);
+        sbc->sram = tmp & TS5500_SRAM;
+        sbc->rs485 = tmp & TS5500_RS485;
+        sbc->adc = tmp & TS5500_ADC;
+
+        tmp = inb(TS5500_ERESET_ITR_ADDR);
+        sbc->ereset = tmp & TS5500_ERESET;
+        sbc->itr = tmp & TS5500_ITR;
+
+        tmp = inb(TS5500_LED_JP_ADDR);
+        sbc->jumpers = tmp & ~TS5500_LED;
+
+cleanup:
+        release_region(TS5500_PRODUCT_CODE_ADDR, 4);
+        return ret;
+}
+
+static ssize_t ts5500_show_id(struct device *dev,
+                              struct device_attribute *attr, char *buf)
+{
+        struct ts5500_sbc *sbc = dev_get_drvdata(dev);
+
+        return sprintf(buf, "0x%.2x\n", sbc->id);
+}
+
+static ssize_t ts5500_show_jumpers(struct device *dev,
+                                   struct device_attribute *attr,
+                                   char *buf)
+{
+        struct ts5500_sbc *sbc = dev_get_drvdata(dev);
+
+        return sprintf(buf, "0x%.2x\n", sbc->jumpers >> 1);
+}
+
+#define TS5500_SHOW(field)                                      \
+        static ssize_t ts5500_show_##field(struct device *dev,  \
+                        struct device_attribute *attr,          \
+                        char *buf)                              \
+        {                                                       \
+                struct ts5500_sbc *sbc = dev_get_drvdata(dev);  \
+                return sprintf(buf, "%d\n", sbc->field);        \
+        }
+
+TS5500_SHOW(sram)
+TS5500_SHOW(rs485)
+TS5500_SHOW(adc)
+TS5500_SHOW(ereset)
+TS5500_SHOW(itr)
+
+static DEVICE_ATTR(id, S_IRUGO, ts5500_show_id, NULL);
+static DEVICE_ATTR(jumpers, S_IRUGO, ts5500_show_jumpers, NULL);
+static DEVICE_ATTR(sram, S_IRUGO, ts5500_show_sram, NULL);
+static DEVICE_ATTR(rs485, S_IRUGO, ts5500_show_rs485, NULL);
+static DEVICE_ATTR(adc, S_IRUGO, ts5500_show_adc, NULL);
+static DEVICE_ATTR(ereset, S_IRUGO, ts5500_show_ereset, NULL);
+static DEVICE_ATTR(itr, S_IRUGO, ts5500_show_itr, NULL);
+
+static struct attribute *ts5500_attributes[] = {
+        &dev_attr_id.attr,
+        &dev_attr_jumpers.attr,
+        &dev_attr_sram.attr,
+        &dev_attr_rs485.attr,
+        &dev_attr_adc.attr,
+        &dev_attr_ereset.attr,
+        &dev_attr_itr.attr,
+        NULL
+};
+
+static const struct attribute_group ts5500_attr_group = {
+        .attrs = ts5500_attributes,
+};
+
+static struct resource ts5500_dio1_resource[] = {
+        DEFINE_RES_IRQ_NAMED(7, "DIO1 interrupt"),
+};
+
+static struct platform_device ts5500_dio1_pdev = {
+        .name = "ts5500-dio1",
+        .id = -1,
+        .resource = ts5500_dio1_resource,
+        .num_resources = 1,
+};
+
+static struct resource ts5500_dio2_resource[] = {
+        DEFINE_RES_IRQ_NAMED(6, "DIO2 interrupt"),
+};
+
+static struct platform_device ts5500_dio2_pdev = {
+        .name = "ts5500-dio2",
+        .id = -1,
+        .resource = ts5500_dio2_resource,
+        .num_resources = 1,
+};
+
+static void ts5500_led_set(struct led_classdev *led_cdev,
+                           enum led_brightness brightness)
+{
+        outb(!!brightness, TS5500_LED_JP_ADDR);
+}
+
+static enum led_brightness ts5500_led_get(struct led_classdev *led_cdev)
+{
+        return (inb(TS5500_LED_JP_ADDR) & TS5500_LED) ? LED_FULL : LED_OFF;
+}
+
+static struct led_classdev ts5500_led_cdev = {
+        .name = "ts5500:green:",
+        .brightness_set = ts5500_led_set,
+        .brightness_get = ts5500_led_get,
+};
+
+static int ts5500_adc_convert(u8 ctrl)
+{
+        u8 lsb, msb;
+
+        /* Start conversion (ensure the 3 MSB are set to 0) */
+        outb(ctrl & 0x1f, TS5500_ADC_CONV_INIT_LSB_ADDR);
+
+        /*
+         * The platform has CPLD logic driving the A/D converter.
+         * The conversion must complete within 11 microseconds,
+         * otherwise we have to re-initiate a conversion.
+         */
+        udelay(TS5500_ADC_CONV_DELAY);
+        if (inb(TS5500_ADC_CONV_BUSY_ADDR) & TS5500_ADC_CONV_BUSY)
+                return -EBUSY;
+
+        /* Read the raw data */
+        lsb = inb(TS5500_ADC_CONV_INIT_LSB_ADDR);
+        msb = inb(TS5500_ADC_CONV_MSB_ADDR);
+
+        return (msb << 8) | lsb;
+}
+
+static struct max197_platform_data ts5500_adc_pdata = {
+        .convert = ts5500_adc_convert,
+};
+
+static struct platform_device ts5500_adc_pdev = {
+        .name = "max197",
+        .id = -1,
+        .dev = {
+                .platform_data = &ts5500_adc_pdata,
+        },
+};
+
+static int __init ts5500_init(void)
+{
+        struct platform_device *pdev;
+        struct ts5500_sbc *sbc;
+        int err;
+
+        /*
+         * There is no DMI available or PCI bridge subvendor info,
+         * only the BIOS provides a 16-bit identification call.
+         * It is safer to find a signature in the BIOS shadow RAM.
+         */
+        err = ts5500_check_signature();
+        if (err)
+                return err;
+
+        pdev = platform_device_register_simple("ts5500", -1, NULL, 0);
+        if (IS_ERR(pdev))
+                return PTR_ERR(pdev);
+
+        sbc = devm_kzalloc(&pdev->dev, sizeof(struct ts5500_sbc), GFP_KERNEL);
+        if (!sbc) {
+                err = -ENOMEM;
+                goto error;
+        }
+
+        err = ts5500_detect_config(sbc);
+        if (err)
+                goto error;
+
+        platform_set_drvdata(pdev, sbc);
+
+        err = sysfs_create_group(&pdev->dev.kobj, &ts5500_attr_group);
+        if (err)
+                goto error;
+
+        ts5500_dio1_pdev.dev.parent = &pdev->dev;
+        if (platform_device_register(&ts5500_dio1_pdev))
+                dev_warn(&pdev->dev, "DIO1 block registration failed\n");
+        ts5500_dio2_pdev.dev.parent = &pdev->dev;
+        if (platform_device_register(&ts5500_dio2_pdev))
+                dev_warn(&pdev->dev, "DIO2 block registration failed\n");
+
+        if (led_classdev_register(&pdev->dev, &ts5500_led_cdev))
+                dev_warn(&pdev->dev, "LED registration failed\n");
+
+        if (sbc->adc) {
+                ts5500_adc_pdev.dev.parent = &pdev->dev;
+                if (platform_device_register(&ts5500_adc_pdev))
+                        dev_warn(&pdev->dev, "ADC registration failed\n");
+        }
+
+        return 0;
+error:
+        platform_device_unregister(pdev);
+        return err;
+}
+device_initcall(ts5500_init);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
+MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index dbbdca5f508c..0f92173a12b6 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1467,7 +1467,7 @@ static ssize_t ptc_proc_write(struct file *file, const char __user *user,
         }
 
         if (input_arg == 0) {
-                elements = sizeof(stat_description)/sizeof(*stat_description);
+                elements = ARRAY_SIZE(stat_description);
                 printk(KERN_DEBUG "# cpu:      cpu number\n");
                 printk(KERN_DEBUG "Sender statistics:\n");
                 for (i = 0; i < elements; i++)
@@ -1508,7 +1508,7 @@ static int parse_tunables_write(struct bau_control *bcp, char *instr,
         char *q;
         int cnt = 0;
         int val;
-        int e = sizeof(tunables) / sizeof(*tunables);
+        int e = ARRAY_SIZE(tunables);
 
         p = instr + strspn(instr, WHITESPACE);
         q = p;
diff --git a/arch/x86/platform/uv/uv_time.c b/arch/x86/platform/uv/uv_time.c
index 5032e0d19b86..98718f604eb6 100644
--- a/arch/x86/platform/uv/uv_time.c
+++ b/arch/x86/platform/uv/uv_time.c
@@ -15,7 +15,7 @@
  *  along with this program; if not, write to the Free Software
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
  *
- *  Copyright (c) 2009 Silicon Graphics, Inc.  All Rights Reserved.
+ *  Copyright (c) 2009-2013 Silicon Graphics, Inc.  All Rights Reserved.
  *  Copyright (c) Dimitri Sivanich
  */
 #include <linux/clockchips.h>
@@ -102,9 +102,10 @@ static int uv_intr_pending(int pnode)
         if (is_uv1_hub())
                 return uv_read_global_mmr64(pnode, UVH_EVENT_OCCURRED0) &
                         UV1H_EVENT_OCCURRED0_RTC1_MASK;
-        else
-                return uv_read_global_mmr64(pnode, UV2H_EVENT_OCCURRED2) &
-                        UV2H_EVENT_OCCURRED2_RTC_1_MASK;
+        else if (is_uvx_hub())
+                return uv_read_global_mmr64(pnode, UVXH_EVENT_OCCURRED2) &
+                        UVXH_EVENT_OCCURRED2_RTC_1_MASK;
+        return 0;
 }
 
 /* Setup interrupt and return non-zero if early expiration occurred. */
@@ -122,8 +123,8 @@ static int uv_setup_intr(int cpu, u64 expires)
                 uv_write_global_mmr64(pnode, UVH_EVENT_OCCURRED0_ALIAS,
                                 UV1H_EVENT_OCCURRED0_RTC1_MASK);
         else
-                uv_write_global_mmr64(pnode, UV2H_EVENT_OCCURRED2_ALIAS,
-                                UV2H_EVENT_OCCURRED2_RTC_1_MASK);
+                uv_write_global_mmr64(pnode, UVXH_EVENT_OCCURRED2_ALIAS,
+                                UVXH_EVENT_OCCURRED2_RTC_1_MASK);
 
         val = (X86_PLATFORM_IPI_VECTOR << UVH_RTC1_INT_CONFIG_VECTOR_SHFT) |
                 ((u64)apicid << UVH_RTC1_INT_CONFIG_APIC_ID_SHFT);