diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2010-04-06 15:24:08 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-04-08 12:23:42 -0400 |
commit | 73a0e614580fb650846be1e9315f6b7b6069b9cc (patch) | |
tree | 058e95bd3c0f88eee83f9b1f39afdcdd355392d5 /arch/x86/pci | |
parent | cf90bfe2ebaf9d32f37acbebb7425c280fd6cd30 (diff) |
x86/PCI: ignore Consumer/Producer bit in ACPI window descriptions
ACPI Address Space Descriptors (used in _CRS) have a Consumer/Producer
bit that is supposed to distinguish regions that are consumed directly
by a device from those that are forwarded ("produced") by a bridge.
But BIOSes have apparently not used this consistently, and Windows
seems to ignore it, so I think Linux should ignore it as well.
I can't point to any of these supposed broken BIOSes, but since we
now rely on _CRS by default, I think it's safer to ignore this bit
from the start.
Here are details of my experiments with how Windows handles it:
https://bugzilla.kernel.org/show_bug.cgi?id=15701
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'arch/x86/pci')
-rw-r--r-- | arch/x86/pci/acpi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c index c7b1ebfb7da7..334153ca4c30 100644 --- a/arch/x86/pci/acpi.c +++ b/arch/x86/pci/acpi.c | |||
@@ -71,8 +71,7 @@ resource_to_addr(struct acpi_resource *resource, | |||
71 | if (ACPI_SUCCESS(status) && | 71 | if (ACPI_SUCCESS(status) && |
72 | (addr->resource_type == ACPI_MEMORY_RANGE || | 72 | (addr->resource_type == ACPI_MEMORY_RANGE || |
73 | addr->resource_type == ACPI_IO_RANGE) && | 73 | addr->resource_type == ACPI_IO_RANGE) && |
74 | addr->address_length > 0 && | 74 | addr->address_length > 0) { |
75 | addr->producer_consumer == ACPI_PRODUCER) { | ||
76 | return AE_OK; | 75 | return AE_OK; |
77 | } | 76 | } |
78 | return AE_ERROR; | 77 | return AE_ERROR; |