diff options
author | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-06-06 14:20:35 -0400 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-07-11 13:19:31 -0400 |
commit | 9b6519db5e226c0c83acddf788b7091b751fbb75 (patch) | |
tree | 8424f6e499bc96e6fe68d554f39dbf422b553d46 /arch/x86/pci | |
parent | a0ee05670915006564962114d4211dd578a8b28a (diff) |
xen/pci: Move the allocation of IRQs when there are no IOAPIC's to the end
.. which means we can preset of NR_IRQS_LEGACY interrupts using
the 'acpi_get_override_irq' API before this loop.
This means that we can get the IRQ's polarity (and trigger) from either
the ACPI (or MP); or use the default values. This fixes a bug if we did
not have an IOAPIC we would not been able to preset the IRQ's polarity
if the MP table existed.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'arch/x86/pci')
-rw-r--r-- | arch/x86/pci/xen.c | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 54d5f3131060..e585bf5778ec 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c | |||
@@ -441,18 +441,6 @@ int __init pci_xen_initial_domain(void) | |||
441 | #ifdef CONFIG_ACPI | 441 | #ifdef CONFIG_ACPI |
442 | xen_setup_acpi_sci(); | 442 | xen_setup_acpi_sci(); |
443 | __acpi_register_gsi = acpi_register_gsi_xen; | 443 | __acpi_register_gsi = acpi_register_gsi_xen; |
444 | #endif | ||
445 | if (0 == nr_ioapics) { | ||
446 | for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { | ||
447 | pirq = xen_allocate_pirq_gsi(irq); | ||
448 | if (WARN(pirq < 0, | ||
449 | "Could not allocate PIRQ for legacy interrupt\n")) | ||
450 | break; | ||
451 | irq = xen_bind_pirq_gsi_to_irq(irq, pirq, 0, "xt-pic"); | ||
452 | } | ||
453 | return 0; | ||
454 | } | ||
455 | #ifdef CONFIG_ACPI | ||
456 | /* Pre-allocate legacy irqs */ | 444 | /* Pre-allocate legacy irqs */ |
457 | for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { | 445 | for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { |
458 | int trigger, polarity; | 446 | int trigger, polarity; |
@@ -465,6 +453,15 @@ int __init pci_xen_initial_domain(void) | |||
465 | true /* allocate IRQ */); | 453 | true /* allocate IRQ */); |
466 | } | 454 | } |
467 | #endif | 455 | #endif |
456 | if (0 == nr_ioapics) { | ||
457 | for (irq = 0; irq < NR_IRQS_LEGACY; irq++) { | ||
458 | pirq = xen_allocate_pirq_gsi(irq); | ||
459 | if (WARN(pirq < 0, | ||
460 | "Could not allocate PIRQ for legacy interrupt\n")) | ||
461 | break; | ||
462 | irq = xen_bind_pirq_gsi_to_irq(irq, pirq, 0, "xt-pic"); | ||
463 | } | ||
464 | } | ||
468 | return 0; | 465 | return 0; |
469 | } | 466 | } |
470 | 467 | ||